Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS

["Jeremy Soller" <jeremy@system76.com>]

Reviewed-by: Jeremy Soller <jeremy@system76.com>

On Thu, Sep 19, 2019, at 8:15 PM, Kubacki, Michael A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
> 
> Adds the ACPI device for the Synaptics touchpad. With this change,
> the touchpad device is functional in the OS.
> 
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  
> Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
>  Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl       
>               | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git 
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> index 96a3232fe5..d309bf4e1d 100644
> --- 
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> +++ 
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> @@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
>    //
>    mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
>  
> -  mGlobalNvsArea.Area->Ps2MouseEnable     = FALSE;
> +  mGlobalNvsArea.Area->Ps2MouseEnable     = PcdGet8 (PcdPs2KbMsEnable);
>    mGlobalNvsArea.Area->Ps2KbMsEnable      = PcdGet8 (PcdPs2KbMsEnable);
>  }
>  
> diff --git 
> a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl 
> b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> index 6fbaf3a97f..3ef9aed1e6 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> @@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
>  
>        }
>  
> -      Device(PS2M)    // PS/2 Mouse
> +      Device(SYNM)    // Synaptics Mouse
>        {
> -        Name(_HID,"MSFT0003")
> -        Name(_CID,EISAID("PNP0F03"))
> +        Name(_HID,"SYN1221")
> +        Name(_CID,EISAID("PNP0F13"))
>  
>          Method(_STA)
>          {
> -- 
> 2.16.2.windows.1
> 
> 
> 
> 
>