From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=KkljAX8x;
 spf=permerror, err=too many SPF records (domain: system76.com, ip: 66.111.4.26, mailfrom: jeremy@system76.com)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26])
 by groups.io with SMTP; Mon, 23 Sep 2019 15:34:55 -0700
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
	by mailout.nyi.internal (Postfix) with ESMTP id 7D0BB21EB2;
	Mon, 23 Sep 2019 18:34:54 -0400 (EDT)
Received: from imap2 ([10.202.2.52])
  by compute1.internal (MEProxy); Mon, 23 Sep 2019 18:34:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iXHqqL
	JiTRlxLU6uABwKr1kQk5zY0WPqghSzp2KXrxM=; b=KkljAX8xXatJVAFuA0DUQC
	ozJsxCJwUZ5jlyqPL4B2QX7t6mL/OMGIyGBFzQc4B5gmlXKiIiDMaQKU/WU4v0sB
	LAQcAILBBVAOis/PhUBubkO2//req5MeRVafbSGBNWE2o9QFqdBeoPO3JveEq1h1
	yzY6MS9NwmCTgRczvTDhGFv2cdhSipi4C+GwO1ur7GJQiGpp5b7W9WwV55M80UR2
	Q6gmuwGuAjMplF7su5bSPiNtfQmIHiQJqEQJ5/igWn87xzVR48HJ13Fwqq7ySFrS
	ieDjbvv2neVdgFwSZ/yMP+Y9Kba1HAsBSbAHHgbNXV+CEBh7nMOSIJQ3hkrXomTg
	==
X-ME-Sender: <xms:jkiJXXzAEDtVQVd_tmw8L4NvrFESwxUGqwxTGyYW9VQkEX8FqSOpUg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdelgdduudcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedflfgvrhgv
    mhihucfuohhllhgvrhdfuceojhgvrhgvmhihsehshihsthgvmhejiedrtghomheqnecuff
    homhgrihhnpehtihgrnhhotghorhgvrdhorhhgpdhgrhhouhhpshdrihhonecurfgrrhgr
    mhepmhgrihhlfhhrohhmpehjvghrvghmhiesshihshhtvghmjeeirdgtohhmnecuvehluh
    hsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:jkiJXaeaYP3Fb_BHCmj3ZcpFq256C0WN6P8MrzIDXwrcisRRgyU4cQ>
    <xmx:jkiJXVJhQE3q6aJrDiIsfW4jocIOWsnPr7OHeS6wAVRnjSfpDe1WIA>
    <xmx:jkiJXb0hHm5-4yLqEoOHLCdTPQCTJnMvs9ZATB3-F95uloHpaB3S_Q>
    <xmx:jkiJXY4aA4J3wRQk3VVYWa4IYRg2W4EKhtC8QFnFA-OUEFtcgYgJ5A>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
	id 08A89E00A5; Mon, 23 Sep 2019 18:34:54 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-238-g170a812-fmstable-20190913v1
Mime-Version: 1.0
Message-Id: <3ef3222e-84ca-471d-987c-968ed74008e3@www.fastmail.com>
In-Reply-To: <20190920021538.27096-1-michael.a.kubacki@intel.com>
References: <20190920021538.27096-1-michael.a.kubacki@intel.com>
Date: Mon, 23 Sep 2019 16:34:33 -0600
From: "Jeremy Soller" <jeremy@system76.com>
To: devel@edk2.groups.io, "Michael A Kubacki" <michael.a.kubacki@intel.com>
Cc: "Ankit Sinha" <ankit.sinha@intel.com>,
 "Nathaniel L Desimone" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
Content-Type: text/plain

Reviewed-by: Jeremy Soller <jeremy@system76.com>

On Thu, Sep 19, 2019, at 8:15 PM, Kubacki, Michael A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
> 
> Adds the ACPI device for the Synaptics touchpad. With this change,
> the touchpad device is functional in the OS.
> 
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  
> Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
>  Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl       
>               | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git 
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> index 96a3232fe5..d309bf4e1d 100644
> --- 
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> +++ 
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> @@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
>    //
>    mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
>  
> -  mGlobalNvsArea.Area->Ps2MouseEnable     = FALSE;
> +  mGlobalNvsArea.Area->Ps2MouseEnable     = PcdGet8 (PcdPs2KbMsEnable);
>    mGlobalNvsArea.Area->Ps2KbMsEnable      = PcdGet8 (PcdPs2KbMsEnable);
>  }
>  
> diff --git 
> a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl 
> b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> index 6fbaf3a97f..3ef9aed1e6 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> @@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
>  
>        }
>  
> -      Device(PS2M)    // PS/2 Mouse
> +      Device(SYNM)    // Synaptics Mouse
>        {
> -        Name(_HID,"MSFT0003")
> -        Name(_CID,EISAID("PNP0F03"))
> +        Name(_HID,"SYN1221")
> +        Name(_CID,EISAID("PNP0F13"))
>  
>          Method(_STA)
>          {
> -- 
> 2.16.2.windows.1
> 
> 
> 
> 
>