public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	devel@edk2.groups.io, rebecca@bsdio.com
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
Date: Tue, 23 Jul 2019 14:13:54 +0200	[thread overview]
Message-ID: <3f016997-2efc-80b5-5c3c-d2a3c1e4fc1d@redhat.com> (raw)
In-Reply-To: <156386807742.18770.2693281149113511817@jljusten-skl>

On 07/23/19 09:47, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> Laszlo, want me to add your r-b?

Yes, please:

http://mid.mail-archive.com/86503359-2f97-a602-b918-abb8cb3d6da2@redhat.com
https://edk2.groups.io/g/devel/message/44239

(At the time of writing my email, your R-b was already on the list, but
I hadn't seen it yet -- you sent your R-b between my prior IMAP sync and
my reading of the v2 patch.)

Thanks!
Laszlo

> On 2019-07-22 17:32:25,  wrote:
>> Enable multithreaded builds by default when building OvmfPkg
>> using build.sh.
>> This can drastically reduce build times. For example, on a
>> modern ThreadRipper system the time required to build decreases
>> from 3 minutes to 1 minute.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>>  OvmfPkg/build.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 4fcbdd2bc9..bacab5e22a 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -40,7 +40,7 @@ ARCH_X64=no
>>  BUILDTARGET=DEBUG
>>  BUILD_OPTIONS=
>>  PLATFORMFILE=
>> -THREADNUMBER=1
>> +THREADNUMBER=0
>>  LAST_ARG=
>>  RUN_QEMU=no
>>  ENABLE_FLASH=no
>> -- 
>> 2.22.0
>>
>>
>> 
>>


  reply	other threads:[~2019-07-23 12:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23  0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
2019-07-23  7:47 ` [edk2-devel] " Jordan Justen
2019-07-23 12:13   ` Laszlo Ersek [this message]
2019-07-23  9:49 ` Laszlo Ersek
2019-07-24 12:21 ` Philippe Mathieu-Daudé
2019-07-24 22:04   ` Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f016997-2efc-80b5-5c3c-d2a3c1e4fc1d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox