From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 23 Jul 2019 05:13:56 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76B44C1EB202; Tue, 23 Jul 2019 12:13:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 716D660BEC; Tue, 23 Jul 2019 12:13:55 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default To: Jordan Justen , Ard Biesheuvel , devel@edk2.groups.io, rebecca@bsdio.com References: <20190723003225.46171-1-rebecca@bsdio.com> <156386807742.18770.2693281149113511817@jljusten-skl> From: "Laszlo Ersek" Message-ID: <3f016997-2efc-80b5-5c3c-d2a3c1e4fc1d@redhat.com> Date: Tue, 23 Jul 2019 14:13:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <156386807742.18770.2693281149113511817@jljusten-skl> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Jul 2019 12:13:56 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/23/19 09:47, Jordan Justen wrote: > Reviewed-by: Jordan Justen > > Laszlo, want me to add your r-b? Yes, please: http://mid.mail-archive.com/86503359-2f97-a602-b918-abb8cb3d6da2@redhat.com https://edk2.groups.io/g/devel/message/44239 (At the time of writing my email, your R-b was already on the list, but I hadn't seen it yet -- you sent your R-b between my prior IMAP sync and my reading of the v2 patch.) Thanks! Laszlo > On 2019-07-22 17:32:25, wrote: >> Enable multithreaded builds by default when building OvmfPkg >> using build.sh. >> This can drastically reduce build times. For example, on a >> modern ThreadRipper system the time required to build decreases >> from 3 minutes to 1 minute. >> >> Signed-off-by: Rebecca Cran >> --- >> OvmfPkg/build.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh >> index 4fcbdd2bc9..bacab5e22a 100755 >> --- a/OvmfPkg/build.sh >> +++ b/OvmfPkg/build.sh >> @@ -40,7 +40,7 @@ ARCH_X64=no >> BUILDTARGET=DEBUG >> BUILD_OPTIONS= >> PLATFORMFILE= >> -THREADNUMBER=1 >> +THREADNUMBER=0 >> LAST_ARG= >> RUN_QEMU=no >> ENABLE_FLASH=no >> -- >> 2.22.0 >> >> >> >>