From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c09::244; helo=mail-qk0-x244.google.com; envelope-from=vladimir.olovyannikov@broadcom.com; receiver=edk2-devel@lists.01.org Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8663F20337377 for ; Wed, 25 Jul 2018 12:48:24 -0700 (PDT) Received: by mail-qk0-x244.google.com with SMTP id c192-v6so5698013qkg.12 for ; Wed, 25 Jul 2018 12:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=vmg8KPOjYFOEJKPfPRwuVa8vmFFOu2DPPJ55746ZdxI=; b=d8pEhNLLz8wafL6smTSRExPN5IMjL4DtvjfrBOAVlGralur75kmNuyjSnLrU1ExB0m D6mWyuo03p7weto1S3L5XV6ytrByHFGm1IrwZHoTfkAkUf91O4FBI37KmUz8P8TqGhbd fX1kpMCIFaaaqFgAxvPhq7CuX6XtjIns1v6q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vmg8KPOjYFOEJKPfPRwuVa8vmFFOu2DPPJ55746ZdxI=; b=QYhkarp3E8tyjnyriQ7IqhJXgd4U/ztLlGrab7xUMeITPiRcjuRm1evTGi1HlAGtie 3Ny53SX+w1VdoR1+fOlyrjcTVpbDOdWhE5Cu+x0a014ADdSmROcTk93MoAsVIYG8kRY2 g41uuz/Pbg6KEcBBW9rr/IgsIyav8FS0FbDocGitkyRh6Gpzm6QjbHikGmMWLkOy11Yt RW4kb/ee04sMUyGO/wMaYTAXKvKUv/4nVnBApmbVNtdAEoP7OJnySYFVlxyva6NUE4M3 mJ8YF8hj0zL+Y5czFpQUjVAvzH7mKpXyp+KUY6Y23EX7n/cwzrDRkYFQXfwaJ70zlWIz fkUw== X-Gm-Message-State: AOUpUlFueC+LEKYH7+iyJcme4RuAH+vs4ayEzYww1CpFcEhgNc4H0myj T+BTLsP8npk0rWl/cU0EZsDsrWf0c1iy6A== X-Google-Smtp-Source: AAOMgpdPsjRNnJDM0ErkM10A4a7UFSfsIZ5oIauscMFOvdNaRzgcz18EyR3s66ZWNuGAITc3waz69g== X-Received: by 2002:a37:9187:: with SMTP id t129-v6mr20481312qkd.112.1532548102703; Wed, 25 Jul 2018 12:48:22 -0700 (PDT) Received: from LBRMN-LNXUB114.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id o124-v6sm9247931qkd.61.2018.07.25.12.48.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Jul 2018 12:48:21 -0700 (PDT) From: Vladimir Olovyannikov To: edk2-devel@lists.01.org Cc: Vladimir Olovyannikov Date: Wed, 25 Jul 2018 12:47:49 -0700 Message-Id: <3f19ff149bc5e3fce4f0d868de07ddb95c123d70.1532547558.git.vladimir.olovyannikov@broadcom.com> X-Mailer: git-send-email 2.18.0 Subject: [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 19:48:24 -0000 FvSimpleFileSystem on read always allocates a FileBuffer, and never frees it. This causes memory leaks. It is especially bad for reading scripts line-by-line. In some cases memory leak can exceed 1GB. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vladimir Olovyannikiov --- .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c index 746f2ced708a..fde208594737 100644 --- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c @@ -704,6 +704,7 @@ FvSimpleFileSystemRead ( Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo, &FileSize, &FileBuffer); if (EFI_ERROR (Status)) { + FreePool (FileBuffer); return EFI_DEVICE_ERROR; } @@ -714,6 +715,8 @@ FvSimpleFileSystemRead ( CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize); File->Position += *BufferSize; + FreePool (FileBuffer); + return EFI_SUCCESS; } } -- 2.18.0