From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.11617.1605121727214494010 for ; Wed, 11 Nov 2020 11:08:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bhXx7Yy2; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605121726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iLFYlVmTPvnf60hDLyEL2v0zagfeC2Yl+dUt7SspOpY=; b=bhXx7Yy2mJb+AGlBbPFCx8hvZr579axSBcfxSb6D2YpCuE6Gdc5y8TPuNX0caLuDDnhMjk zdzV/2Cg6++Srnr1zN5+MfxYPp0EoKt5oTke/u5cmQn7khF/8jYMIQxhulyI8ZjOWqdvbE UhDb/+S4nbH/iGUwQyOkVRBgECJqfV4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-HENxWpHdNwuMP2HBILitFQ-1; Wed, 11 Nov 2020 14:08:43 -0500 X-MC-Unique: HENxWpHdNwuMP2HBILitFQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1944287950E; Wed, 11 Nov 2020 19:08:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-85.ams2.redhat.com [10.36.113.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F22973661; Wed, 11 Nov 2020 19:08:39 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64 To: "Zurcher, Christopher J" , "Yao, Jiewen" Cc: "devel@edk2.groups.io" , gaoliming , "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , Ard Biesheuvel References: <20201103215834.7533-1-christopher.j.zurcher@intel.com> <1644D590FF4B7423.25549@groups.io> <7D73B5FD-CBCA-4E8C-B73B-930722C9FCF7@intel.com> <903654d9-f903-734c-1d07-2f83a8c40099@redhat.com> From: "Laszlo Ersek" Message-ID: <3f261875-8195-f017-225a-07fa4c1c859b@redhat.com> Date: Wed, 11 Nov 2020 20:08:38 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/11/20 02:43, Zurcher, Christopher J wrote: > I don't want to speak for Laszlo but I filed an issue against OpenSSL that the NASM build should not assume win64: > https://github.com/openssl/openssl/issues/12712 If that's viable, it's clearly the best solution. > > The issue was triaged as a bug by OpenSSL, so I think the long-term plan would be to fix OpenSSL to not set win64 flag by default on all NASM builds, at which point I think we should be able to use the same NASM files for VS and GCC. I'm not sure if the classification as a bug means the fix could be made in 1.1.1x builds or if it could only go into 3.x. Either way, it still (hopefully) gives us a path for re-simplifying. Thanks! Laszlo > > Thanks, > Christopher Zurcher > >> -----Original Message----- >> From: Yao, Jiewen >> Sent: Tuesday, November 10, 2020 09:08 >> To: Laszlo Ersek ; Zurcher, Christopher J >> >> Cc: devel@edk2.groups.io; gaoliming ; Wang, Jian J >> ; Lu, XiaoyuX ; Kinney, Michael >> D ; Ard Biesheuvel >> Subject: RE: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native >> instruction support for X64 >> >> Laszlo. >> If you disagree, what is your proposal? >> >> >>> -----Original Message----- >>> From: Laszlo Ersek >>> Sent: Tuesday, November 10, 2020 8:31 PM >>> To: Yao, Jiewen ; Zurcher, Christopher J >>> >>> Cc: devel@edk2.groups.io; gaoliming ; Wang, >>> Jian J ; Lu, XiaoyuX ; Kinney, >>> Michael D ; Ard Biesheuvel >>> >>> Subject: Re: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native >>> instruction support for X64 >>> >>> On 11/07/20 03:24, Yao, Jiewen wrote: >>>> The reason we choose NASM is that we can use same assembly in windows >>> build and Linux build. However if this NASM cannot be used in Linux, then >>> the benefit does not exist any more. You can generate GAS to support GCC >>> build, and check in .S file. >>> >>> I disagree with this idea. To me (as an exclusive GCC user), uniformity >>> of assembly files is *much* more important than getting native >>> instruction support in OpenSSL with all toolchains at the exact same time. >>> >>> If we enable native instruction support for (a) VS and CLANGPDB now, and >>> (b) for GCC later, then that's two steps, with each step being in the >>> forward direction. Performing just (a) for now creates no technical >>> debt. A feature gap is not technical debt; you cannot mistake a missing >>> feature for a working feature. >>> >>> If we re-add .S files now, for whatever purpose, that's a step *back*, >>> however. It creates technical debt. A working feature on an invalid >>> basis *can* be mistaken for a working feature, and we shouldn't do that >>> (unless there are strong business needs for some participants, *AND* we >>> have a *very specific* plan and timeline for backing out the hack). I >>> really don't have any trust in technical debt being "paid" in edk2 >>> anytime soon, though. >>> >>> Thanks >>> Laszlo >