public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Brijesh Singh <brijesh.singh@amd.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel@lists.01.org
Cc: brijesh.singh@amd.com, Tom Lendacky <Thomas.Lendacky@amd.com>,
	Justen Jordan L <jordan.l.justen@intel.com>
Subject: Re: [PATCH v2 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO
Date: Thu, 5 Jul 2018 11:48:39 -0500	[thread overview]
Message-ID: <3f31bd4d-061f-ba81-8589-9f5815eabdae@amd.com> (raw)
In-Reply-To: <e0a1f956-a7fe-f261-bfe7-a853544cfb66@redhat.com>



On 7/5/18 9:41 AM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> On 07/05/18 16:05, Brijesh Singh wrote:
>> [...]
> I'll need some time before I can look at this -- meanwhile, can you
> please repost the series with a dedicated cover letter email? If you
> wish you can include a short summary description and v2/v3 etc updates
> there; however, the main point is that the patches be nicely collected
> in a threaded list view. Patches #2 and #3 shouldn't be children of
> Patch #1. And, people should be able to comment on the series as a whole
> -- for that, cover letters which they can respond to are the best.
>
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05
>
>   git config format.coverletter true
>
> or
>
>   git config format.coverletter auto
>
>
> When you do this, please collect all the CC's across the patch emails,
> sort them uniquely, and add them manually to the cover letter too.
>
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
>
> (Note that the references above are not official edk2 material; I'm just
> linking them for better explaining my request.)

Sure, I will resend series with cover-letter. thanks




      reply	other threads:[~2018-07-05 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 14:05 [PATCH v2 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO Brijesh Singh
2018-07-05 14:05 ` [PATCH v2 2/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM build Brijesh Singh
2018-07-05 14:05 ` [PATCH v2 3/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is active Brijesh Singh
2018-07-05 14:41 ` [PATCH v2 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO Laszlo Ersek
2018-07-05 16:48   ` Brijesh Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f31bd4d-061f-ba81-8589-9f5815eabdae@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox