From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0044.outbound.protection.outlook.com [104.47.37.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48BAF21CFA603 for ; Wed, 16 Aug 2017 08:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XWOYJZcZeDcDfNzmdcWjMm2VYzzw/LSvNrd+mBAfesg=; b=Jg1885BpCzztIu8TbryLq29aX57qvNI8hiSW6VuaT7gx5hwoFGopH3/lSBID+u+WBBjbPNaEOIgsOmHaT6Hm5QfL3dG0YuBSIWkKIAu6EJTatWbkQTqKyZ7ODqxBbPYKVOqeCUlEH9XiwwYHTCITMnI/YqgaTG9bLfHsyu+UQkc= Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0160.namprd12.prod.outlook.com (10.162.3.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 16 Aug 2017 15:53:16 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-9-git-send-email-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: <3f415b26-10d3-d7de-baeb-0170fa43f3a0@amd.com> Date: Wed, 16 Aug 2017 10:53:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR2201CA0043.namprd22.prod.outlook.com (10.172.59.17) To SN1PR12MB0160.namprd12.prod.outlook.com (10.162.3.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 533173f3-9389-4fb8-c940-08d4e4bee93b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR12MB0160; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0160; 3:l1b8zFStwiE+5luhd1f2JgNPMQu8y8AXParJBv1LsXZfsi/BTMJ5mno/b5hQuAnPSfI2BK1BylPK5i886yirvsm0uWcyuvpm+0hqeiTzXZEtO/hpqfoFcguHA98qnQ9WbUGalDgmvztQM3CqAGWJBDskTSGkmQk6o27ZDhU1Ux4uGQNdxJ7UH7ToV6ShaqgcvYV+nFrEJMxnbd+sRqscS+RxjHR+WcU33hsXD+1m3rOIt2xkACL9e//8oqDUbpCi; 25:dRJps1n10cvF08sqZA3f2oJlvqlOtQo8esZQGgDEV8MTa9kZCX+f21GGwb38q8AZSNwE6CnQKjvvOHONbayRZWxeF4XugEydfCv3ICcVoGjbAUiLijwoHb2QMMkbVgxEW1mvJCdlAByfIKs8BeABfPesyIy/s3n8fhy+3TAUK8/1w6JzLCiRq0iYRbMlIwtJjy9+y3hFGxx/tprp8572Iuh8W3b3noOTctSSvGuSMPmXM/ydoFa5nMNnBXE2liOj0GFAiDLTdsuxXLTBKrHyoVxmAFpXD1A8xtPncUh9gE9dTUp3RwhH5o2PNM/Y/M7XY5iaCpLbuqWguuSyglSYsw==; 31:eT6jEHtpDS8wH2IbnCqIiE1aQ18KqbrSVy9gLMM317kmAhI0bKg4AGonqV0q7SAkOPehC0x+eNqJLJY6OqSRtS997zYf2mgWYo3P1dc3RNwiJzTeIdksLlRCmciPAPfgBscub6A13Dd99YZehVK5Br9Q1zDH0GVlH8jqMqMn+aVGSG4I8gZ3Dh4Muqv84bs19EzbilbxoiH7z/Ge/fWACH5iSml1md2PmK8A8gLN86A= X-MS-TrafficTypeDiagnostic: SN1PR12MB0160: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0160; 20:ewKmuoOEoQYcdM7+MhqjeXhVTbofNKKMv9UMfurNh5zuOOFOHJ1u60h0MVWKN+5dmB760b+w/mi84zVtuzYFUtotT64ObIlCJmxBb/bJ+bnDAw747/s67brzGDVJrpN1A5R1jPcOqtcyKxXRjJ+2G1PWdEXDNMmkv5CnarsilsiGVI62MziFjlZzwV0vVwoTz6X4CEsIlwl4LezTE0uBry4ox+wxkMC085M5Ox9Gq9D0CyUfsBcT6KFTVfbb/wbqaIJo8prp4uTHWGr9/SMT+3Vc7roCQSu1NJScr7lOhplpqUD1JRGx7Ij12Qrw26B+KRFm0Bowm22ljVavQnmF8E4Ue7EqwtMPr7V861Vkk/PQo3elYBlwZv50HZk7N/sR5DIYmGG4W7g9nLQs8KotR+W+W1bQO43GqpETCnTxUZYyBkjBx8jAf19RiLTgdXej3Elzinb9i5XG039fAmZhMkjy0mRb90JOruDyUSX7OHqfeBhbiMRYBYse9aRfgc4l; 4:KvhLd1kvF2DCWr2seD1VexbRA93S1M6m8m3IEWAxxDb5xD0KZhSvuK2cUB5xWokO77Qlb1zZq6tLp5j8T6a1QuvOFYywsZ+4z17PHaO3Fx/dF16Z7sQW8ODzFmt+Fuz7MD1ghTqEFi+3Pg7Nb7qqt2h62ojVo0RkU0dX0H0TccLCR5WNaqjCvJGeyz6kcFziT7552QF7bWL5EeXE8X/G0wzZK6b1oXdvHwm24XaN15rooX7DRcWsTH6KSyEmvuX7 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR12MB0160; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR12MB0160; X-Forefront-PRVS: 0401647B7F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39860400002)(24454002)(189002)(377454003)(199003)(25786009)(90366009)(6486002)(77096006)(65956001)(229853002)(65806001)(66066001)(42186005)(4326008)(189998001)(65826007)(50466002)(47776003)(23676002)(5660300001)(3846002)(6116002)(86362001)(110136004)(6246003)(105586002)(53936002)(31696002)(7350300001)(106356001)(31686004)(33646002)(53546010)(6666003)(4001350100001)(64126003)(2950100002)(97736004)(54906002)(68736007)(230700001)(8676002)(81156014)(81166006)(83506001)(50986999)(54356999)(76176999)(478600001)(36756003)(305945005)(101416001)(2906002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0160; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTYwOzIzOlFjZzRKMVdWMWdXRXlONFgzSlYzRDQwcWds?= =?utf-8?B?KzcrU3pwb0FWSGJDLytBUGc0ZmJwOVluSEs5akp3NGVlOG9JeHM5VXZMYlAx?= =?utf-8?B?bVc2bkdwYVBlTEVqeVZYNGNDREJXcm5aVTluL2cvMlNVSlhMRzZUSzFkUXlu?= =?utf-8?B?dkgzMWsrMlZ1OCtCaFkwOWNYcGVDbHBIREhTRDBpSHRDT1NXNGt6WWNlZE00?= =?utf-8?B?RU9ocWgyM043TGF3UENYbzBiMHRJUVJoNEl5WkpYdVBXS3BWQTc4OWRNZWhi?= =?utf-8?B?cnlJZ0N1UHFwVWlvYjcvSmhBZEZERm8yeGZmOWp5MkxNREpGNlc3MGRpcStC?= =?utf-8?B?Zlc0TlEwcjR2cUliUXdCd2NhOUMrS00vODg3UFBUYkVDMkhYNVFtWktiL05m?= =?utf-8?B?S0VDSUJ1d3FtVjJiVTJ5R1VsbFdXa1hBcGhvanZNN0JPbWdSWVdNUkl2bXpl?= =?utf-8?B?ZFNmb1VaSWxyazdJRGlnR0Nqc05iUDRNc094TDFmK1dOOEY5WmxMNitmVllr?= =?utf-8?B?dnpNNFVEUUxnMkd2aU43YnNQNzNnazVEWThTcVphQnFnSXBMK0o1U3ExeTVJ?= =?utf-8?B?YnhHTVJLM2toSVNDQmF0Vk9GNXZuZlRLS2hqMDloTDUrOExjaGtvOEVwRm02?= =?utf-8?B?bzYvUG9kSmJpTFpuanFYZzdwRy9TWkxlenJUakxNUjVsZlhzQ1VtRWlkUDI1?= =?utf-8?B?KzhmYm95N1RFajVMNTdiQW1uTHFBWjhrdXllMFo2aDB6VERRMSt3STRkejJu?= =?utf-8?B?Nzg3czJMMVlLVVU4Z3pEYmIrTWw4aWhSYU16UWk5M3FCdjFIa2hncTM0enBi?= =?utf-8?B?K2lIaXlyMjVRT1hlLzB6L0F3S1N3UHFSZUtSTkYrZVJaSC9NbDQ4WjFyS2pz?= =?utf-8?B?WnpPdEtTeGFVdVhVRmt4SkovbXRLZy9DYUozZ3ZhZEE3Qi84YlNEZzhIVzFO?= =?utf-8?B?NithUlRTZ1hwdmphWWNERHM1aCtQL04zZVF1dWVVN0pwYTZrNU01L1VJaEtC?= =?utf-8?B?b0RzOWlLYlNVM2k2b1gwdENMc0xrVVBXRWovN0l3cFZFZzZSTDZFZmVFcXF6?= =?utf-8?B?M2lwbUJnYTJJTTVyK0xrOFFVeVJ3VkxzbSs3UWx3eUZpT2tBVmJDSFlDSlRK?= =?utf-8?B?aDI0Kzk5bVFoeUlmZnQxdGV3SjVrdHZhN1RwMk9Femc3bVAvOC8weUlYRVlq?= =?utf-8?B?cG5wKzRXQ2F5ZjQwZ2tJVHFHZWgxNWZPSkVRcStTWWdrZVAwN2crVmxrTTh6?= =?utf-8?B?R0F6VW0vaHQ2clJSVWQvcXU3RVpyU0JxUmVZWGdzdncxZUhLc25BTDZuS0hD?= =?utf-8?B?cHRFL3puU3dxZGszTldBNnI3YWJmZVBWNCtnSExSd3lYQ2M5aEs4VGVlZzFM?= =?utf-8?B?TTBaelk5UWo2TDBJa3VMajhDY1FaNlJvV0EybTVIaVBjMjZGWW95K0FhejdT?= =?utf-8?B?UDVoL2tLOGVHeTlObDQ0TXpILzFzem5PaHA5ODFvdjBuS3lnRUNHQkxxakVH?= =?utf-8?B?ck5nTmI3dmlmZWY1cXdaQldLYVpndDFmSE82VGFRWmQ2cS9pejJQbEtkK1J5?= =?utf-8?B?N2FWa296d0Npb0FqcHFFQUN4SzllUDBvMy82V2h1N2o3bDlZbW4yZ0FSMkRn?= =?utf-8?B?TnRtN0FMU09lcGs2WE9aakEvaWc2R3loWFQ4V3FmcGJpaEx4VmV2UTYyNHps?= =?utf-8?B?cFFTckhWM0RiQTFxRFVPWmFMZnFQZkEwMnVBRVZUakVaYy94T2xtV0NnQlFw?= =?utf-8?B?MHlzZjhvQmVaOUhVMG10cnp1aWYvTWxId0VQUUNLOGJNK0VwbWx1ejEvdmRi?= =?utf-8?B?bnFwWWk5ajBvWi9ZUVE3WHJUZzdqckVOV3ZSM2NZSjZwWGFjZzZ3KzJkREhm?= =?utf-8?B?SnJPS25lQTJjQjNkWkQrd0pxKzhkVHRIc3RTU2pxVDhpLzVvVVM3enRKNi91?= =?utf-8?B?RUR6UHdlVDdRPT0=?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0160; 6:iUj5Pm0eoJA+wOIPj08ijYFvM9EiMXMHUrL4dEVY0TplGCYFNWsaok+udXgCMr84e7OmpJ7iGiZvtdwgy/C80yv7he7i6LMBNK+2hNYeSunxP9zwOHZw/ClWoN6kYD4qZKm5cDoKkfcVjNCKIdAr8P59+yIww23DDwA0p/7wA/xqZrAbWBGTA6lhD1IGn3GR0HGlOmWVtyNgHTgkzVdzG9+S7/k3aJnz/JmBlVo6CNl6vZl5dpHXclR1IXUbww+nvC1r+axcX66lhHAyu+59uK9MLnxNmXe+tufie4uhzjL9TqGON/iFmHSyc+e4SGj++Sp87IrZHB69WMRGX3ONbA==; 5:PEN4sYOa7oUjNW53QghFWWONdNiXTxifwRXH9SPXadXG9WtRmALW6a2zPiEo0NxpH4XoX17pgM5y8ilWus+jzMY3+PoCc3cKfOGOd158sxWcTdcpEedn3NWMXPjqxENSjP1APRpW18pWQt1D6lXdQw==; 24:s1vGdT5vYo5+3LeD/3TRm3d5NTeTnivqgbv2akpFkk1UfTH4HhYwPUP71NBvbnpW+kmv6HzHrtO9omS8Up/m/m218SR1iSe4TACsihSLVkg=; 7:KMbtMfgFQ8/wcGshrVYHF7IcuxYaF0k2XjERamP/J43eYV5dpJ3i8neZhLHYC3TVjco1Clmt7w5ysudMShZPybVuDR9IUwM07zGfktV5H1uvrJ6u/4yKUm9LGoFurcO4HOu4k3f6WSAwetbv6AHxbkfVLncfFXFbB3oB/HVXtRwvpgLbhQv+oFSOOaWqfxS2qdv+2b8teVgDJ6NfIL7JZ1Bg6Zk5ta+BciVAT8ZpSUo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0160; 20:1nzsLRgD4aBkYN3CuG/6sKtX2HS8yG58eq5Bm4EYzQDXxNK8brm3RfPrw5Szd0bd718ot69vgu/Yap2yLQvOVYJR3ih/Z3KZ5zGm997fvg9WPjeY6ikrRWJmKQ8GaM+oEj6Nc9kuVSfURWegRh01Wx5yq6OxeywGQvWqDFsfyKAzcdnB4z/OgNMmxURLbBdVRVQDhC278EdFo2SEzsdnWEgvcr20/ZqLj+Y7DJiIZAYGfiFAc3CZF0JfbDi+mRWK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 15:53:16.5261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0160 Subject: Re: [PATCH v2 08/23] OvmfPkg/VirtioPciDeviceDxe: implement IOMMU-like member functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 15:50:53 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/16/2017 10:32 AM, Laszlo Ersek wrote: >> + >> +EFI_STATUS >> +EFIAPI >> +VirtioPciUnmapSharedBuffer ( >> + IN VIRTIO_DEVICE_PROTOCOL *This, >> + OUT VOID *Mapping >> + ) > > (1) Is this an Easter egg for your reviewer? :) "Mapping" should be IN, > not OUT. > > This oversight is surprising -- or, well, an Easter egg :) -- because > the function declaration, in > "OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h" above, is correct. > Surprisingly, it didn't took you long time to find hidden Easter Egg, I should work harder next time :) Since now you have found it hence I will quietly go and fix patch 9 as well ;) -Brijesh