From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5C2EFD801B4 for ; Tue, 3 Sep 2024 18:03:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9jgkhGKNtrXkqpob+msA72a4u29PQRgOEooqyatugLg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1725386639; v=1; x=1725645837; b=Gh2O9JAfIyl33kzL++KJJcIPJmBKyo8uJiSRx4pVQKMiPisNIUGfuhoBa+wT65rleWYLOYq7 RaLYQTmN3KZB0EK7Jcr83HOmWzOv3vlWErfFvtI/JvygDVNjiwsgpIpEP5Pe4dx76C0PlR3jJgt Yl36YDWOo6bQW1jj8QtVxLH/fheKpm5fLTCXsZEM11U1pjNbI7JQE5XUfP4L4GkBSeqQenRx86L xKUOvq+JxJdjhT6M5q+Zu2yOXMw7BcEcx+fLBAWLTebKg3E3g4KabF+8tVPPUoLCMonCMX5CbGu wmvN6t1fqXt3YAL7vdbXexdnyhkGDS/3ak/NWg8g5+I8A== X-Received: by 127.0.0.2 with SMTP id woBaYY7687511xMEFNTQfsl5; Tue, 03 Sep 2024 11:03:57 -0700 X-Received: from BL2PR02CU003.outbound.protection.outlook.com (BL2PR02CU003.outbound.protection.outlook.com [52.101.51.75]) by mx.groups.io with SMTP id smtpd.web11.6050.1724910935454461110 for ; Wed, 28 Aug 2024 22:55:35 -0700 X-Received: from PH7PR01MB7584.prod.exchangelabs.com (2603:10b6:510:1d0::11) by CO1PR01MB6662.prod.exchangelabs.com (2603:10b6:303:d7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.28; Thu, 29 Aug 2024 05:55:31 +0000 X-Received: from PH7PR01MB7584.prod.exchangelabs.com ([fe80::5fd8:2985:3bee:7e78]) by PH7PR01MB7584.prod.exchangelabs.com ([fe80::5fd8:2985:3bee:7e78%3]) with mapi id 15.20.7918.019; Thu, 29 Aug 2024 05:55:30 +0000 Message-ID: <3f848071-8670-42f0-ba66-73cdfdba727a@amperemail.onmicrosoft.com> Date: Thu, 29 Aug 2024 12:55:21 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support To: Nhi Pham , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, chuong@os.amperecomputing.com, rebecca@os.amperecomputing.com References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> From: Chuong Tran In-Reply-To: <20240807064731.4049764-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To DM4PR01MB7596.prod.exchangelabs.com (2603:10b6:8:60::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR01MB7584:EE_|CO1PR01MB6662:EE_ X-MS-Office365-Filtering-Correlation-Id: 67764e37-c208-4caf-3236-08dcc7ef2ed0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?TjNhTXFYTGRPcjFEZjkvMnNkUmp0UTJ4RVBLZCtJU2FEU3lkL2MzRi9PTjlF?= =?utf-8?B?eTVkWUtWMWZRR01IQTY0NjBKSEJMdmVmUEdka2dueURnVWp0ei8vNlZ0WGtr?= =?utf-8?B?bHhxd09kSXRrc213TU1XaDh5K3RTMWs2cG5NTWpvMExRdnFYcVJ0bkNGSjZP?= =?utf-8?B?OTdieU9QMzhCK3BvMWROTU91Y2sxTmFNaXdPbGRQSUJVY1lpTm0vZlJSK1Nw?= =?utf-8?B?ckdoeHF3cjZjenJ4NVplMzh1d29va3RZa213QW8vRHVreFhERy9ZTS9Kb1Ro?= =?utf-8?B?RFZpOVFwRFpjZ1JWdGtoTFREK0JiTnRoYThwYjN2VjhHM2RmZGhuTDkwb1Ux?= =?utf-8?B?dC9pUDErcjlmV0l2YWFVb1kzSzBDN2xDVWhjcnpSU0VEenREL21iVHV6RnRQ?= =?utf-8?B?aTA1cUdsaHREYjg1QTBPL3JpVkxxNm8zdjNmVW1nS05EYWFVRVhHeS9WY1Bj?= =?utf-8?B?S2RYWTN1NjVhRnBNdmhHWnNod1kweWNlTjg1L2JEeUNDN2VzdEtEd0VHeURu?= =?utf-8?B?ZWpDMlpUd2M4YVZpdDFDODFjekhSNlQwTkppT3BoVi9kWHVLcHh4NDQ3eWRt?= =?utf-8?B?TDRYa3V4Z3VGMTlPWmo0bzRrdklvWmF5VENhc1JteHJtaFJMMCtuL0h2UmIy?= =?utf-8?B?NGNtUmFlU0F0bzRmbHl6dzBSNVE3bFRORVZZekZzU042ek8wbkhpa1pPL3Nm?= =?utf-8?B?L3BwS2tjNVJqbjZ3RnZzRzhnam5HM2Zhc2d2WSs5OTVDMlZlaXY1UUFhSmt3?= =?utf-8?B?NlVBODhrcXArbGpNR0h5cTJkNFoyMTlMcUlBSzYrbC9CUWJXREVWNEQvbjVC?= =?utf-8?B?RWdYcmtmZDNYOE8zcWNtUDN0U3M5SEhZSXltQk03bWI0S29uL0ZRWTJJRHZx?= =?utf-8?B?MFlRbWVLWWU4MUEwQmsrQ2xXKzVxS3A2L2crdDBaaUlucWJrMldNY25EbmlY?= =?utf-8?B?OEhuVUxGTTgzUk5qb1htUE04NWFNcVhOS2Jjc1lmOGNjVkxCaVMwbFRuekNO?= =?utf-8?B?eE1ZbE1ZLzMvbFFNa1B3OWdyNUZBRXBKQUh6ZForK0d2K0ZqaWpmM3BiUlpJ?= =?utf-8?B?dXY0cytsZHR4d0F6dTFVYjN2S0ZyUmpSL3VBayt2UVd0cHBydFRmMFB5ZFor?= =?utf-8?B?UldzYWUycU1LYnJzMlFCWWxJWlUyeGp2U24raVg2MGZSdjk2a1JYdjlEUFFE?= =?utf-8?B?LytGQU4vRm1Ca0Rwak5rY1BUYVBiWnB0RGRLZzkvdlNnL3pvRDFza3lUOHla?= =?utf-8?B?UHhhYWJUMTUrZHlSdUMyQi9PQWVTY0szbElsRC9va3YrbEF4MG1TKzlSUTM1?= =?utf-8?B?RWszcEluM2RaVkRQV1lSSlFxV1JIdGxnUWFBUGVpUFcvOUQ2d1FhOVpJNVpJ?= =?utf-8?B?UVR3Z0hsUUkrSmQrUXR3NDExWGdkc3VFSzJPdWNFWGQ5MUFIQmhxcnRLMHE2?= =?utf-8?B?NmppcmVzNmxjZGdkVFoxVFlZWWJqbjFpanNKUG53L2FiMUhndHUzdGk4TE50?= =?utf-8?B?d09hRTlyOHNOWnlsK0dMVlRwQ1I3NlR2aG9rQ2dtUUdKU0tiR3IxL3JzUVZP?= =?utf-8?B?UDVmSU9pTzExaCtkaklIMEFUaTAzbUQwNm9KZUNrb0tNeUw4ZUpKTExaelE3?= =?utf-8?B?bWh5NWJnTXlPck10eE5pd1hDcFpNZ3RTalQzdi9vQzZLY3V1RVZwd0gzdG12?= =?utf-8?B?SHJxMDEyZjNWQXFxMEp1VnJGdWt1T1JmN3R4Yld4SkRabzY0bEliSFUrbHJZ?= =?utf-8?B?VzduSzRuOWZxUEp3OG1OK0ZIbnp1bllQbzVYa1NXUCtUZTRMN0d1alZ2YXJs?= =?utf-8?B?RTZEbERBQjZkZm9FUTNOUT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWxXMkZRaHhFY0oyRzJNYkpSVDhQTGF5OEVyMFlsZ3NYazl5dHFTclllR2Fx?= =?utf-8?B?OXJMaURoMzBibFBPejlUeVVSYVZHM2R2bTFxRnpZMWlnbHVQTXhnU1lsaitW?= =?utf-8?B?QkYvWU9QbDhlK1k0c2hVV0hZRXJHQ2RtOGh3SElXSHFFdm45YXBObldrVUVs?= =?utf-8?B?NHJIQXJDOHJ6WWlZbktLMW9udU5TV2dwZjBHald2NFVzMHBJcE42MnU5Yk9V?= =?utf-8?B?ZmVjSjJXbWxLaG01b3VsckhBbTVDTExPYUN4b1E4UHJPK3lWbFZkdXR0N0kr?= =?utf-8?B?Wm4yLzA1TzFMOW85YlpCcUpjcmZ5Z3VZRXY2SkwyVXl0dHhJNVpxa0o5UUg3?= =?utf-8?B?eno1Y3lZYlhlNjljOFc2d29FUGFUcEtYRXlSUWJUdEd0bmhMZWFFUEJmSDlG?= =?utf-8?B?Mm41bExKMUQxbEFPT1lodjVKbTA2UWdRT1E0elNrSkZKemRIU3lzVGRtTk1L?= =?utf-8?B?YlY3TFB6dXZJbjRVUmhpUDlzN0hQYzVlWVUxMXdxSXdxOUc0bjdjTUl2Uk4z?= =?utf-8?B?M1BldnU0RWMrRXJ4VDBoWks1bjhwTE83K0hFK1dOM0VjNGhRbzJucVIwdUxR?= =?utf-8?B?VkZjUlo0cGRnekI0Ly9PcWVsbnhPemtPY2hjeWJWbjdXODhEMHpOaUFZQ2k4?= =?utf-8?B?ZHJUc0ZYYU1wUitWK1RNTGpHLzJXd2pabjMxTmNNSFNQdGFXdWJyaEJxUEls?= =?utf-8?B?UW8zZ1gyNHF3U3l1YWwrSGZXQU1qSFJuMUxrK3pRVDdMQm0rTmg2S3BpWUdw?= =?utf-8?B?SWpTOGc3amxSK1VqUnBIT0lIMHNKd2VVc1lmRWVYenZwYitwRy9GL0hTejJP?= =?utf-8?B?eVZiajdRb01EbkROWUt3Ymt3M3pneDBuUUQzSlFPZ0V1Nm1jTmxEZUR5ZmJi?= =?utf-8?B?bW9qb3lpbkRicUJ6emRROVZydmZBM1Y2SjFCTWo4MFgyaWl2cWpUMUN5cTlH?= =?utf-8?B?djJqYkZ2WHJGa1VQbGEwWkR5TWxDWXNKTWxZSGFJQ1dKeVAwdjEyMGloZkNX?= =?utf-8?B?OE10eGt1TzhJcWlqZmdTSk9BOGRKOEZHT3V6YmJyL2t6OC8xOHpMcU9MK3dU?= =?utf-8?B?S0dOeHdMZ1RvNkN1ODN2cUtmcU1IREU0SlpleE9PZUIrdFVIVTdzK1dhT1U4?= =?utf-8?B?RnR4WFZjRENqLzcxV0c5WngxaWxUOW5pYW9RUDJKR2NWckQzZ2phaCtnY3o3?= =?utf-8?B?TVEyaWtzWFR3ZjNCamVEMWtwYzNiQnJRdTRjMk4xak41SUluL3kzL05ERlZ0?= =?utf-8?B?RVJhTGEzdVk3ZVMyNTU1dmRRRDBzOWtPblI2V2dFWmd3U0dRaUxaYVZMZktV?= =?utf-8?B?Wk1aUnp2YzZjRkY5ZHUzaHVyTUd3VW5FWCsvMDdXbVhJN0gydWdTWUtVNFFX?= =?utf-8?B?OFdpOW1MV0hJZG1mQXhERE1FVGsyRmJzalpMZ05Bd0t6OG8zZXIwZjFGK2N3?= =?utf-8?B?Z3QwbnJBQlorREF6cGE4aVRKR3VUbVhkajNSRG1sM3JzMXpuK3A2cUExYzhT?= =?utf-8?B?Z0lGaWRNaS96M0xkc243Wk5pT0Eyb1ROYjZBUG9pYUx5MzYvZlFYWVppbzRF?= =?utf-8?B?cjlXeWNXc2x1c1dyYlBZb2tNa29tRlNJeHBZNkFiVFFpZ0JTSE13N3J6TEVB?= =?utf-8?B?amt6M1duU25VMDlFdForam11aE02dGRLVGlvSk5kMWxZQVB1S3h6SW1VSjVj?= =?utf-8?B?YjlWRkR3cklvZXY0QWtEdWNRdEw4b2x3WG9XRm5KY3RBVjhQMWJVNGYxaUFi?= =?utf-8?B?YTFXdlV4YTcwWjVsenFzbGJ4VlZ5UmZBdmk5SlZyb0MrVTBRYi85blNIa1o2?= =?utf-8?B?LzgzQ1lTcCtwSzJVNVlDY2MwaXVER3RxeVVkdjE2Y0ZabmIrNzlzd2Y3MEwr?= =?utf-8?B?MmpmaWR4dHNuOVIvMldBUVlPb2V2bEVKbHp2UFRUUlJTQnEwc0QxNzlkNEtW?= =?utf-8?B?NG96NXJQejhRbmhPQmh2a2d6L1lKZmVjOWpBdWV2SzN0c3FmcmQxMGRpSm9j?= =?utf-8?B?RDBuc2didkY2Q3EwNHdLU3V4Qi9FazdpdWJTaGFLa2dpVWVPRWpaVGlhd2RR?= =?utf-8?B?cmFOUjNjd3BnRWJxblVzNUljL2FYMGI0amJUSldlNUtlNERsYzQxN0dsU3FF?= =?utf-8?B?ZzEzaUVhRm50aVlac0dGZ1Jra255L0dKajNxbW5YOUdQSzVMM2JpOW9vMW5t?= =?utf-8?Q?y50wdOsDxDB0W7PPGNX1d94=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67764e37-c208-4caf-3236-08dcc7ef2ed0 X-MS-Exchange-CrossTenant-AuthSource: DM4PR01MB7596.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2024 05:55:30.7657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jfln08k1j/0Jm0JlnVR/D+7BVgOr7RDZgXGW/a2Oj19ySGqBxwYCPULneuNwmy5sJ36YLlfmQ1GMHBOq7wMzn/KW/ItE9w+vM0vwUcvwN4Oh+A+pYIvqn3PZkyq+BmSH X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6662 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 03 Sep 2024 11:03:56 -0700 Resent-From: chuong@amperemail.onmicrosoft.com Reply-To: devel@edk2.groups.io,chuong@amperemail.onmicrosoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hxMXIPnKpFKrP4scMKS8L2Bex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=Gh2O9JAf; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none For this patch series: Reviewed-by: Chuong Tran Regards, Chuong On 8/7/2024 1:47 PM, Nhi Pham wrote: > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform. > > v2: > - Refine the changes of the DwI2cLib per Leif's comments and update the > commit message accordingly. > - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. > > NOTE: Regarding the controller/target terminology, the function > prototype and comment are derived from edk2/MdePkg. In this patch set, I > am trying to avoid misusing the terms in the implementation instead of > altering the function prototype and comment with the PPI and Protocol. > > Nhi Pham (5): > AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation > AmpereSiliconPkg: Define PCDs for SMBUS and BMC > AmpereAltraPkg: Add SmbusHc PEI and DXE drivers > JadePkg: Add PlatformBmcReadyLib to support BMC ready check > Ampere/Jade: Enable IPMI SSIF > > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec = | 15 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc = | 23 ++ > Platform/Ampere/JadePkg/Jade.dsc = | 2 + > Platform/Ampere/JadePkg/Jade.fdf = | 17 ++ > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib= .inf | 29 ++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf = | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf = | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h = | 95 +++++++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h = | 11 +- > Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c = | 6 +- > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib= .c | 30 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c = | 261 ++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c = | 277 ++++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c = | 263 +++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c = | 129 ++++++++- > 15 files changed, 1227 insertions(+), 17 deletions(-) > create mode 100755 Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/= PlatformBmcReadyLib.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cDxe.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cPei.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cCommon.h > create mode 100644 Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/= PlatformBmcReadyLib.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cCommon.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cDxe.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cPei.c > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120479): https://edk2.groups.io/g/devel/message/120479 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-