From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.820.1591734966984073604 for ; Tue, 09 Jun 2020 13:36:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QP+uALKK; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591734966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yvS4EeFeHTUWyDc1/5x00XbuSvcc9dDthWLl97CmwmM=; b=QP+uALKKfREbSWQQSusLcaMVMrilKz7b8tvILEQfKjJ3CuAInBpmObQelv/tyuR25eV3te ZRBZbRYIze0ElF4388Dzm3/jUrYF0Zrqdp+yQOZ1cpkpXOCfQJTD1+JebcT0gpZDgEid5R K04tw0i++DZWrokBu5HvcMrANUOnDvw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-hlx-uG4iPhSlv8Ti7GIqwQ-1; Tue, 09 Jun 2020 16:36:04 -0400 X-MC-Unique: hlx-uG4iPhSlv8Ti7GIqwQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3418A0BE4; Tue, 9 Jun 2020 20:36:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-194.ams2.redhat.com [10.36.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C4D689296; Tue, 9 Jun 2020 20:36:00 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg: remove unused files To: devel@edk2.groups.io, ard.biesheuvel@arm.com Cc: Bob Feng , Liming Gao , Leif Lindholm , Ilias Apalodimas , Julien Grall , Jiewen Yao References: <20200608173413.1100679-1-ard.biesheuvel@arm.com> <20200608173413.1100679-5-ard.biesheuvel@arm.com> From: "Laszlo Ersek" Message-ID: <3f996df3-43cf-d20a-5982-0e1c78aeec0a@redhat.com> Date: Tue, 9 Jun 2020 22:36:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200608173413.1100679-5-ard.biesheuvel@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/08/20 19:34, Ard Biesheuvel wrote: > We no longer use ELF PIE executables to implement the self-relocating > PrePi so drop the custom linker script and visibility override header > file. > > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/Include/Platform/Hidden.h | 22 ----------- > ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds | 41 -------------------- > 2 files changed, 63 deletions(-) > > diff --git a/ArmVirtPkg/Include/Platform/Hidden.h b/ArmVirtPkg/Include/Platform/Hidden.h > deleted file mode 100644 > index 7a7bdb42b8bd..000000000000 > --- a/ArmVirtPkg/Include/Platform/Hidden.h > +++ /dev/null > @@ -1,22 +0,0 @@ > -/** @file > - > - Copyright (c) 2018, Linaro Limited. All rights reserved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __PLATFORM_HIDDEN_H > -#define __PLATFORM_HIDDEN_H > - > -// > -// Setting the GCC -fvisibility=hidden command line option is not quite the same > -// as setting the pragma below: the former only affects definitions, whereas the > -// pragma affects extern declarations as well. So if we want to ensure that no > -// GOT indirected symbol references are emitted, we need to use the pragma, or > -// GOT based cross object references could be emitted, e.g., in libraries, and > -// these cannot be relaxed to ordinary symbol references at link time. > -// > -#pragma GCC visibility push (hidden) > - > -#endif > diff --git a/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds b/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds > deleted file mode 100644 > index c9a15ca3493a..000000000000 > --- a/ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds > +++ /dev/null > @@ -1,41 +0,0 @@ > -/** @file > - > - Copyright (c) 2015, Linaro Ltd. All rights reserved.
> - > - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -SECTIONS > -{ > - PROVIDE(__reloc_base = .); > - > - . = PECOFF_HEADER_SIZE; > - .text : ALIGN(CONSTANT(COMMONPAGESIZE)) { > - *(.text .text*) > - *(.got .got*) > - *(.rodata .rodata*) > - *(.data .data*) > - *(.bss .bss*) > - > - . = ALIGN(0x20); > - PROVIDE(__reloc_start = .); > - *(.rel .rel.*) > - *(.rela .rela.*) > - PROVIDE(__reloc_end = .); > - } > - > - .note (INFO) : { *(.note.gnu.build-id) } > - > - /DISCARD/ : { > - *(.note.GNU-stack) > - *(.gnu.hash) > - *(.gnu_debuglink) > - *(.interp) > - *(.dynamic) > - *(.dynsym) > - *(.dynstr) > - *(.hash) > - *(.comment) > - } > -} > Reviewed-by: Laszlo Ersek