From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.13224.1594221977686081827 for ; Wed, 08 Jul 2020 08:26:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqB+Rg7Q; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594221976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eci/gtG8HEBKm7wmfb4YkWOfJZQXN00VzEv2aeqMZe4=; b=eqB+Rg7QYFI+bKqNifiia+UQwLWowSslqqAQm3BrrtzRmq6CDwglm2OBDTRoBxwKY7a6rR uEL03ttoX0dUGm8U8A9EqxidQYEmC6RkbY66YV5oBLe33PJSpZWr4hY6KDB4ySl7lcqxVp ePydTPr9etXcUR03hSiV03oE0QPwof0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-tr7bHixROMqGmopXk1CUbw-1; Wed, 08 Jul 2020 11:26:15 -0400 X-MC-Unique: tr7bHixROMqGmopXk1CUbw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07AF0107ACF5; Wed, 8 Jul 2020 15:26:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-73.ams2.redhat.com [10.36.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1449A60E1C; Wed, 8 Jul 2020 15:26:12 +0000 (UTC) Subject: Re: [PATCH 06/11] OvmfPkg/LsiScsiDxe: Report Targets and LUNs To: Gary Lin Cc: devel@edk2.groups.io, Jordan Justen , Ard Biesheuvel References: <20200701040448.14871-1-glin@suse.com> <20200701040448.14871-7-glin@suse.com> <20200708023450.GP18504@GaryWorkstation> From: "Laszlo Ersek" Message-ID: <3f9e6b3d-b8e7-2ba2-bdbf-c250d3e893e9@redhat.com> Date: Wed, 8 Jul 2020 17:26:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200708023450.GP18504@GaryWorkstation> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/08/20 04:34, Gary Lin wrote: > On Tue, Jul 07, 2020 at 11:04:21AM +0200, Laszlo Ersek wrote: >> On 07/01/20 06:04, Gary Lin wrote: >>> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >>> index 65bb2bb0eb4c..ae7d1d648d22 100644 >>> --- a/OvmfPkg/OvmfPkg.dec >>> +++ b/OvmfPkg/OvmfPkg.dec >>> @@ -174,6 +174,11 @@ [PcdsFixedAtBuild] >>> ## Microseconds to stall between polling for MptScsi request result >>> gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40 >>> >>> + ## Set the *inclusive* number of targets and LUNs that LsiScsi exposes for >>> + # scan by ScsiBusDxe. >>> + gUefiOvmfPkgTokenSpaceGuid.PcdLsiScsiMaxTargetLimit|7|UINT8|0x3b >>> + gUefiOvmfPkgTokenSpaceGuid.PcdLsiScsiMaxLunLimit|0|UINT8|0x3c >>> + >>> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8 >>> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9 >>> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFirmwareFdSize|0x0|UINT32|0xa >>> >> >> Commit 093cceaf79b5 ("OvmfPkg/MptScsiDxe: Report targets and one LUN", >> 2020-05-05) introduced PcdMptScsiMaxTargetLimit with token value 0x39. >> That was OK. >> >> Commit 505812ae1d2d ("OvmfPkg/MptScsiDxe: Implement the PassThru >> method", 2020-05-05) then introduced PcdMptScsiStallPerPollUsec with >> token value 0x40. That was not OK -- but I missed it. (The token value >> should have been 0x3a; as 0x39 is not succeeded by 0x40 but by 0x3a.) >> >> Token value 0x3a remains unused at this point. >> >> (5) So please introduce the new PCDs with token values 0x3a and 0x3b, to >> keep the token space dense. >> > I actually was thinking about making PcdMptScsiStallPerPollUsec 0x3a in > another patch. Since it's not related to LsiScsi, I didn't do it in this > series. Sounds like you prefer to keeping 0x40 for > PcdMptScsiStallPerPollUsec? If you can post a separate patch for changing the PcdMptScsiStallPerPollUsec token value to 0x3a, that's best! Thanks Laszlo