From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 15 Apr 2019 09:17:06 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F6DE30BCE6F; Mon, 15 Apr 2019 16:17:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-136.rdu2.redhat.com [10.10.121.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51B619C71; Mon, 15 Apr 2019 16:17:00 +0000 (UTC) Subject: Re: [PATCH 00/10] patches for some warnings raised by "RH covscan" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Anthony Perard , Bob Feng , Jordan Justen , Julien Grall , Liming Gao , Michael D Kinney , Yonghong Zhu References: <20190412233128.4756-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <3fa8cb1e-9f18-74c6-d6a5-68a7687012d9@redhat.com> Date: Mon, 15 Apr 2019 18:16:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 15 Apr 2019 16:17:06 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/13/19 01:36, Ard Biesheuvel wrote: > On Fri, 12 Apr 2019 at 16:31, Laszlo Ersek wrote: >> >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 >> Repo: https://github.com/lersek/edk2.git >> Branch: covscan_bz_1710 >> >> "covscan" is an internal service at Red Hat that lets associates run >> static analysis tools on Fedora/RHEL packages. It drives a number of >> static analyzers. >> >> While covscan's existence is not "secret" (if you google it, you get a >> bunch of hits in the Red Hat Bugzilla), I can *not* use or offer covscan >> as a general upstream tool; for that the TianoCore community will have >> to build its own service / environment. >> >> Anyway, "covscan" happened to drop a bunch of reports on me for... >> "reasons", and so I turned a short 10 hour workday into yet anoher >> normal 15 hour workday (stealing some free time whence there was none) >> in order to do something, up-stream, about the warnings that affected >> OvmfPkg. No claim is made about the completeness of the scan's coverage. >> >> Some of the patches seek to suppress warnings, some strive to remedy >> valid-looking issues. We should not spend much time on this series. >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Bob Feng >> Cc: Jordan Justen >> Cc: Julien Grall >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Yonghong Zhu >> >> Thanks >> Laszlo >> >> Laszlo Ersek (10): >> MdePkg/PiFirmwareFile: express IS_SECTION2 in terms of SECTION_SIZE >> MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE >> BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE >> MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE >> OvmfPkg/Sec: fix out-of-bounds reads >> OvmfPkg/QemuVideoDxe: avoid arithmetic on null pointer >> OvmfPkg/AcpiPlatformDxe: suppress invalid "deref of undef pointer" >> warning >> OvmfPkg: suppress "Value stored to ... is never read" analyzer >> warnings >> OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code >> OvmfPkg/BasePciCapLib: suppress invalid "nullptr deref" warning >> > > Thanks for the cleanup. I wasn't cc'ed on all patches, Sorry about that, it wasn't trivial to figure out whom to CC on what, and I opted for sticking with Maintainers.txt (AFAIR). > but this looks good afaict. > > Where needed, > > Acked-by: Ard Biesheuvel Thanks! Laszlo > > >> BaseTools/Source/C/Include/Common/PiFirmwareFile.h | 7 +++++- >> MdePkg/Include/Pi/PiFirmwareFile.h | 26 ++++++++++++++++---- >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 7 ++++++ >> OvmfPkg/AcpiPlatformDxe/Xen.c | 14 ++++++++++- >> OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c | 7 ++++++ >> OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c | 5 ++++ >> OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c | 4 +++ >> OvmfPkg/Library/VirtioLib/VirtioLib.c | 5 ++++ >> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 5 ++++ >> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 5 ++++ >> OvmfPkg/QemuVideoDxe/VbeShim.c | 2 +- >> OvmfPkg/SataControllerDxe/SataController.c | 5 ++++ >> OvmfPkg/Sec/SecMain.c | 6 ++--- >> OvmfPkg/VirtioGpuDxe/Gop.c | 6 +++++ >> OvmfPkg/VirtioNetDxe/SnpReceive.c | 5 ++++ >> 15 files changed, 98 insertions(+), 11 deletions(-) >> >> -- >> 2.19.1.3.g30247aa5d201 >>