From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.40]) by mx.groups.io with SMTP id smtpd.web11.200.1663953762218222167 for ; Fri, 23 Sep 2022 10:22:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DnbNlClD; spf=pass (domain: arm.com, ip: 40.107.21.40, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gi/dE4VXrF8aVUAvD36UOushau6iO1V7PtH6pKKTJpc0a3TqGqDvg7zAd6BB/9eJ6uy2XM9xRcS6vsxWiZ4BKxz5QEX3NQg2pO1cV4hTof+dZ2ekNWOL2ggKQBk6BVr6y/vY3XVLCJXSXywIkiHH78K7l4YIx2qOGUuYNMhll4jh6svzFfB9z4QPsyma+IiimzTDuV78zShlOxvaxZ0EWolycE28xc7xrs2Gtn6dxTR3nK2sbCEkcZDo7/PUYnPduq1Z4nvZD4Wzc6RHnSoULuymHeMMuH71Lm84UqQTm6pq8eINPCJ1EBgIs1uPpzF/hd/8Z6gH+L4ff3lIzdwFzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WPp98n928ePbf2Gb13bmKDfWhTx2I3YvZjN9QhF+Rdw=; b=jeJHCz1bjMNBFImMWkEd25ZY0HkFhf27t4tG/MNsXaPDxQG9YZGi3m7jp7hfw3odSwgMygtMhRC6ctejUEtZuQLz9El45IbzNKoi6pfoYpobq9uLNxSS7aNOfh5D/6svw1fjZNvAetvUPNmUPKgrKJNm/xmv8nMQKi2GcLyIpsMVrj9n++Zn8lTFF0jpVUZskaa0Sy9McP+kzhWjy2Llp2l05bqQnfPFWP/DmEs6A9TOLCiPX32wCxONLnObdrxAEo1qcXHwUlp5qehC1JtNjSY/mFtulJkrkRqykmuqGmgzs25OlZZDOoH/MiUrVP1qi3csbAAws1ggf8/kv+1Sgg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WPp98n928ePbf2Gb13bmKDfWhTx2I3YvZjN9QhF+Rdw=; b=DnbNlClD/lynK9uyRZmJzfAR5yafLlIkyoAgz3O4HzMcz7JZ8IPnhHQRTRb1OP3TD+ZSwTVJWmWspkqNAIAIXNCqV9oLsLUp3PoIp4P5UyHEDGijNH2kVhDBEmp1bUX4O7oOQ3NkVvrNvjjcKOLv7pCUBY0wL07yUP/AkUksy+4= Received: from DB6P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::21) by AS8PR08MB6616.eurprd08.prod.outlook.com (2603:10a6:20b:319::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Fri, 23 Sep 2022 17:22:38 +0000 Received: from DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::44) by DB6P191CA0011.outlook.office365.com (2603:10a6:6:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 17:22:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT065.mail.protection.outlook.com (100.127.142.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 17:22:38 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Fri, 23 Sep 2022 17:22:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2b6eac811b206e0d X-CR-MTA-TID: 64aa7808 Received: from dbaa6cc544d3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93BE619E-B71A-4BBD-9B06-1BE0D3CE393E.1; Fri, 23 Sep 2022 17:22:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbaa6cc544d3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Sep 2022 17:22:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmTtrlB9CpZzK85E49wjjvplVW2Q+5rqDTLgxJi2/h2z6wU/Q8MW+0Xv1SYb/gWOABKGaVsxnNmdAjrWV/2bNaNE4S7lUFHu2EIHTt9cTWPwPIs2zVbPlmXme9hEs+UbeRwseKIwWqNLxZQ4SgB8lkEcGULLNedyO9Kl7bL5Pj9ZJzwaSCTWiv7XP75deIvw0E19wHWZP7wCdrY2mw5KAjXZMK0D6W+NCpoXKfKL4Uie5Cyvy3U8z9bNLJqsuSE8T5+k0f1pGA8EOWbDCXeGq3IFB1JyNhX2zp5l4fuUALlLHxPR8ch/iRUPkqXIcMH5i5eWsq+k+wV6hbojh9F3FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WPp98n928ePbf2Gb13bmKDfWhTx2I3YvZjN9QhF+Rdw=; b=d3SdLeP3IYV47kzxCe1DzNMelK0HkK1J9/cSsC58RWoKw3zUdvCQk+C9usB/3bIyOsDy09hAI5xWUMaPwRkgQF29lqgKwRl27LRGmsjox8Iev4C28wUCGYVjRQNsYjR3Pm8yFHSuu+9yn8YMfHqU3vTUJ9vHZqLXEuvFjaj6H1DrxyXdccHgQOALlSH4nY0bXpUfC1XfKZeV3tIXYe5kJUzvVHqGJAKLQGn7JFN1sI5y3Q3YGlX/1BZrt6Ruqrv/ZpeKHmk0xO60B6y+DZ7ThpHS75Yf2JXaQZdnIjbxTO+rybenlDb/HFmMsajSdqa0bS+PDuRHwY6BSLB0p08hsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WPp98n928ePbf2Gb13bmKDfWhTx2I3YvZjN9QhF+Rdw=; b=DnbNlClD/lynK9uyRZmJzfAR5yafLlIkyoAgz3O4HzMcz7JZ8IPnhHQRTRb1OP3TD+ZSwTVJWmWspkqNAIAIXNCqV9oLsLUp3PoIp4P5UyHEDGijNH2kVhDBEmp1bUX4O7oOQ3NkVvrNvjjcKOLv7pCUBY0wL07yUP/AkUksy+4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM9PR08MB6164.eurprd08.prod.outlook.com (2603:10a6:20b:287::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 17:22:29 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%7]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 17:22:29 +0000 Message-ID: <3fab602c-aeb9-6010-8251-18907f92d310@arm.com> Date: Fri, 23 Sep 2022 18:22:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v5 0/3] DynamicTablesPkg: _CPC support To: Jeff Brasen , "devel@edk2.groups.io" Cc: "ardb+tianocore@kernel.org" , "Alexei.Fedorov@arm.com" , "pierre.gondois@arm.com" , "nd@arm.com" References: <9e752a96-e578-6641-19b9-7de75137fb22@arm.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P265CA0081.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AM9PR08MB6164:EE_|DBAEUR03FT065:EE_|AS8PR08MB6616:EE_ X-MS-Office365-Filtering-Correlation-Id: b301d0e6-90c3-4359-2973-08da9d8836cb X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mHwEBYNt+CRwuwkG1Yy2dEPernEfhW5KuekyvLqgZfh/1NZqRyD2J2gk26IeNP24WdXzkJO8wVlxIiUayUyyaLS+p8XgRIm9WJLVGmX64x8SSx+kaSQIW/vE8vRAW0F2rNH3HZWdHGadCXzOuSMFrDCwjzIT7Vw8YtPV12L3ZcF4RboO4CuhE4SjfZ5hqyWGGEeNJ7ShjwZXGeWAxz71qEiUQpli3tlQ2W48TX+xaTqYwZpq/WJt9qSKQo+JTWwPUKTHL02M9BS6IM5lc+tAanSr7gzT03Zoe6QgZnnA14zMWnGa6fscRoT85V452segGsyW4kCXuAwqbYVdjAbevLgDE2rbBoldjhXNFMyngQh6qqfOujHdSXHV66D4qU3tay6Z4FBS3f8ECrwuBAdt/dmXTW4Q7a80wbC/nSxOBkmXmtF42ac7knEWdHem2dgFPrbwbUKKecnJiQcrBaK4GffWJc2uT7622h+/6TVoZWOVSDZfzyue+u0wbPDa5SIlW+l/MaIPy0d/38XlalxcrID+Fdsnj8UIQG5xnLv0vUZGq35H11Yl2WycvRIjhS8FSh6i/Czx+Ioe2FRb7MJ3Ye4csCJ1KZhoyVoG62bhOocRiS6tq7wgqXMMGyb32zYkaci6bq/H+8xyIAV1s10nqFCzbkqj75pLcx20VH83GrHLbesjH4vWyTzbPkBGPl21s/9hdxo3ZM2/HSKOSDw9h1LV/NrkRizEKVIqfTjTqQj36ccA2jFyetLXuCEMa9TAR6Zc6iDncaHB3nlFuBWJmdVJkifgkkZHkxO/I0QfioUlDMVwqcmewZsjs3XWo91nHHDLc0uy6NAyquv8H4XFMZTqxsHDLCvhOLHX2R2TExTV2KWL7v/ylsu/ea6gv6s+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(53546011)(36756003)(86362001)(6666004)(31696002)(38100700002)(41300700001)(44832011)(8936002)(5660300002)(110136005)(316002)(54906003)(45080400002)(8676002)(66556008)(66476007)(66946007)(4326008)(966005)(6486002)(83380400001)(6506007)(2616005)(478600001)(2906002)(26005)(6512007)(186003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6164 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 96b69d9a-481a-4a3f-b3f0-08da9d883140 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gxDlxUpZlG1NoKDuO1dOYp5ZzrDE0AeAPc9Lr8uKYjwGthTSzLD3/HaTjTPuGZbf1vdqmg7W0+xhMy+YUupTJqS72SGDr7RbfufxvDzeilMU07JMYBIiIFlzBXaq6SHEw7IntO1ItL+RRgl2oWRHK/QD03mT+fbOK238zAjry6XxOaiRXRB2LaAnSNiPSC/Q2jgF1fGH1x/1wNSIbtRInu/ECF1f/UR49I0X+j4v4bgYFhYmPySwUviSLsvrf/OzEXk7AQvLM5LCeArlBp590zCQKgF6gjlgIZlxj5R3z3kzYOmfwSYiN3ZIDJdsOoRIaP5ml/+gVgvftGZzxAnjB/06iePdwb/fnJZhjU5C9F4YBT2AK7Pp4nK2W0cY5YnMDZjQAknO236Q1jbBZjyrIVTzE6aj+y1A2dzMxMGw0HnmhnNY7x+jE5OIl8Ik8l07B/6g1e0PoNd3kNQe06WavFeulQNlZMMxV0ldDm30C/pwewEAd5EKZB5Zl2rBVlWJKkWIM5joZPhweOvpKkMdFcDfnM+E4EVjYkFHI63XZfJtFOGKwgpGfZaYM6zLQGW2zkdG4/C56UQsOguUB8qI1HdSWOYTTK6dRqFZF6a81Yklqhq/1toFerRrRviB7oILvb8J6iXTfulg5aLhb8k7yvsPOPNvlBRo5rn1EVVepyrH+u2j9raQiTQAujavCkUo6rNoSaUIkxhsW2/3Pg1LtyfV8JPMT59HL33YS7fvHGBQaoImagib6zsJvFfNvwXKZFUhEV1mmcm3Ot+WVdIcs6SApjAnOBTFFZ9C3zg0io1Mil3T5X7Z+Ngjhpdgz/koK8KYCYeaCb6Efx97Y8JxZA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(47076005)(316002)(336012)(40460700003)(82310400005)(186003)(54906003)(83380400001)(110136005)(356005)(81166007)(8936002)(6512007)(86362001)(26005)(6506007)(53546011)(36860700001)(478600001)(70586007)(70206006)(2616005)(966005)(6486002)(82740400003)(6666004)(41300700001)(2906002)(31686004)(45080400002)(31696002)(5660300002)(44832011)(36756003)(40480700001)(8676002)(4326008)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 17:22:38.6743 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b301d0e6-90c3-4359-2973-08da9d8836cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6616 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Merged as 953438e4665c..2500ce101178 Thanks. Regards, Sami Mujawar On 23/09/2022 06:05 pm, Jeff Brasen wrote: > Those changes look good to me. > > Thanks, > Jeff > >> -----Original Message----- >> From: Sami Mujawar >> Sent: Friday, September 23, 2022 10:55 AM >> To: Jeff Brasen ; devel@edk2.groups.io >> Cc: ardb+tianocore@kernel.org; Alexei.Fedorov@arm.com; >> pierre.gondois@arm.com; nd@arm.com >> Subject: Re: [PATCH v5 0/3] DynamicTablesPkg: _CPC support >> >> External email: Use caution opening links or attachments >> >> >> Hi Jeff, >> >> Thank you for the updated patch series. >> >> I have made some minor changes: >> >> 1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to >> DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from complaining. >> >> 2. Minor update to the documentation for CpcToken in >> CM_ARM_GICC_INFO. >> >> I have scheduled a pull request >> (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> ub.com%2Fsamimujawar%2Fedk2%2Fpull%2Fnew%2FREVIEW_2369_dynami >> c_cpc_support_v5&data=05%7C01%7Cjbrasen%40nvidia.com%7Cfa438c >> 463975467b580908da9d84760a%7C43083d15727340c1b7db39efd9ccc17a%7C0 >> %7C0%7C637995489497585332%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC >> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000% >> 7C%7C%7C&sdata=hwqiwMp1xW4hu1uTcJMiHhCpMnHCYh6jjmRDi1allx >> Q%3D&reserved=0) >> for checking that edk2 CI is happy with the changes. >> >> Please let me know if you are ok with the above changes, and I will push >> these changes. >> >> For this series: >> >> Reviewed-by: Sami Mujawar >> >> Regards, >> >> Sami Mujawar >> >> On 22/09/2022 09:36 pm, Jeff Brasen wrote: >>> Add generator for creating the _CPC object for CPU nodes. >>> >>> If viewing this review by a pull request is helpful one exists here: >>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> ub.com%2FNVIDIA%2Fedk2%2Fpull%2F12&data=05%7C01%7Cjbrasen% >> 40nvidia >> .com%7Cfa438c463975467b580908da9d84760a%7C43083d15727340c1b7db39 >> efd9cc >> c17a%7C0%7C0%7C637995489497585332%7CUnknown%7CTWFpbGZsb3d8ey >> JWIjoiMC4w >> LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C >> %7C%7C >> &sdata=7gI38kSJx1GjNPVikW1UX8nT8D2KIADcyta8MM4TI5c%3D& >> reserved >>> =0 >>> >>> Change Log: >>> v1 - Initial Revision >>> v2 - Added revision to object, improved error handling, changed to ACPI 6.4 >> structures. >>> v3 - Minor review feedback >>> v4 - Convert CpcInfo to structure and use that for APIs >>> v5 - Cleanup parameter checks, add token to parser >>> >>> Jeff Brasen (3): >>> DynamicTablesPkg: Add CM_ARM_CPC_INFO object >>> DynamicTablesPkg: AML Code generation to add _CPC entries >>> DynamicTablesPkg: SSDT CPU _CPC generator >>> >>> .../Include/ArmNameSpaceObjects.h | 60 ++- >>> DynamicTablesPkg/Include/Library/AmlCpcInfo.h | 124 +++++ >>> .../Include/Library/AmlLib/AmlLib.h | 54 ++ >>> .../SsdtCpuTopologyGenerator.c | 133 ++++- >>> .../Common/AmlLib/CodeGen/AmlCodeGen.c | 475 >> ++++++++++++++++++ >>> .../ConfigurationManagerObjectParser.c | 115 ++++- >>> 6 files changed, 921 insertions(+), 40 deletions(-) >>> create mode 100644 DynamicTablesPkg/Include/Library/AmlCpcInfo.h >>>