From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.1263.1688578446891038821
 for <devel@edk2.groups.io>;
 Wed, 05 Jul 2023 10:34:06 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=I+5Vs+DM;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 168A020C08E6;
	Wed,  5 Jul 2023 10:34:05 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 168A020C08E6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1688578446;
	bh=UwMLGQRv3Vbefg9ZGcVfCl3uIX7QUGYCe+g6ReJpqK4=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=I+5Vs+DM9ERoCGFjbauUM1Zvl6AMX3iwPZZbB/8zADwwmxF1MDMUJVWPUemzeVQz+
	 6/FjHUUXyO1aRhPlV0VdreZSzP0qCGNCe47tKVogKJgV7kVedn9L7Ub27GvLNdcYdo
	 mP9TNGPPrIcCkGW59RgOfjqi/SqZXPZoeaAKFTTs=
Message-ID: <3fef44f5-9d42-2395-4322-21b5fd9ae9eb@linux.microsoft.com>
Date: Wed, 5 Jul 2023 13:34:05 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [edk2-devel] [PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry
To: devel@edk2.groups.io, joey.vagedes@gmail.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>
References: <20230626213434.8-1-joey.vagedes@gmail.com>
 <20230626213434.8-3-joey.vagedes@gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230626213434.8-3-joey.vagedes@gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/26/2023 5:34 PM, Joey Vagedes wrote:
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>   UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> index be839d1af0a7..40a396dd9f71 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> @@ -5,6 +5,9 @@
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>   ##
> 
>   {
> 
> +    "PrEval": {
> 
> +        "DscPath": "UnitTestFrameworkPkg.dsc",
> 
> +    },
> 
>       ## options defined .pytool/Plugin/LicenseCheck
> 
>       "LicenseCheck": {
> 
>           "IgnoreFiles": []
>