From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe46::60f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E734C21B03871 for ; Thu, 25 May 2017 11:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wKSxEuf2KJIe91Q+BeR+EO+O1PYBOc1OdlSymkwRc60=; b=puVa0ULL7aWqi/OvYL8mXfeyo1vKUWo2xC4K+XDWWSUI4OIsNxWOooT5//7EO/waW3lPROqidPBJ6KjChvD2ej9RmwwsR/tUd77n05lXmv4ym1QUZq0hkxDyCnXM312kmeNYpny9C375O1vSRa4d9c0uXpDh7SMfKxP0hwbaGPo= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Thu, 25 May 2017 18:23:43 +0000 CC: , , To: Laszlo Ersek , , References: <1495466592-21641-1-git-send-email-brijesh.singh@amd.com> <1495466592-21641-5-git-send-email-brijesh.singh@amd.com> <868ad318-c652-55c2-4b4c-eeeec2f826c6@redhat.com> From: Brijesh Singh Message-ID: <3ff4a976-44c5-634b-cc76-d40039a996b7@amd.com> Date: Thu, 25 May 2017 13:23:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR16CA0037.namprd16.prod.outlook.com (10.172.42.151) To SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PR12MB0157: X-MS-Office365-Filtering-Correlation-Id: 23204a67-d066-4d76-a994-08d4a39b2d52 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 3:fvxswbXNrSDoyKiJEtkn9kYAo7EekXgiW2hp2+RN30F24uSL29Z02TixIwfMuF6G5XGkEl961V+YHruMZBCdZaKe+6qklPHdIlBOS1kxHIFpbYU1m6JY5e8Tj5XeHW77JeFDF0uIT3GwXGn255TauZwUDIq9BhCWbxFvP+Xsg33+lNgt0swqKdRq+VIV7SQeCPo2xoJHpTSsxoVsOt2Q/2L65+qklIuxPSsj7dz4UZlIHAiOQUj9txy1szr1qjfWAYPX0kblSGhGKQY/DG0j+An3icsycRDx1L0Hfq33etvnT4pFve6+c3u0DvdWg5w+lpxtrMLCmgpSjlWMM3Ei8Z7H+CDN4GwxH4JDgfryYFM=; 25:5y+DuWFmiZpBLxgyj1sJR0W4TgZ6NWffmDTF7VraQbPtNMP+I3TXyzEMIQ3Knq1m9tbKh8XxGp/7cTwOTRos0yirU4g5Da4fa1nJhmyDK1MOTYZiS/cRMi9ETR2G8ZViuUlbGHqbmFFcsL9lQVP0sKlY8qWQfGgvfxUmHe/+8SXBSc1Z+pwVlvmyquurecEBd4TXSoG2vxAPFPPN236Zd2V9RhPJXHer5uxDdTtFtI57sQ88ZGpWc06SFQsrblyRTDgYQNus2U1fmPzkK5TJ5KXmZXAx4kAlE8j2HZUvg5qxatJEekKhtnHV/u/OYYamrpenPJjQyOCYuV8E8+XkvYZOtIIMjkR8bp5qpG3qRySEZ6m234F/B4sXTM+gKUmnRLAlo00QNK51O1b0NGgwGkA2Vqhgk/WIHtqX2yrzN5TKiZfTSaBnNBGO/xqI2t8kkV01PwGBjnfGlAgrXgnEplKmbTIyZCp/AbgaA2AFZdY= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 31:gn6N45uU2jdVC9JX0LceU1BjcFqWlMT5wQ6EvvU5rs+e/t6PHSVEaDmgeaaumpbVr33Qt9E6RTT4PYe7lb6uOs2LFLmiwwAQD+S3yHjVFgAcub86QqOfvowT/GDFkYXimq3XbSYFZl/uc74bpry4LKRaNj/uJcldDsKaRr8I66eDTgTJLr2CtSNS69y4k4SMZ4VY7ZoQl0MHd4spKecrLV+k+LlqqXqUGTgmb37P4F0=; 20:F7LoZwyngFF+BwxgQ+ibU0kVIG/2yy+lgdRix5+jPlIc6IV/j8XTIV2wAFkcD43J2uifFpqOTdjfGPyquu7w/uLeL12wwsrQ2xJjMKospzcfsAPAoVVVm1h093CiRAq3LNcg2o+wXHslX/udfjt8k1WMddTGPdxOEqx4u6aBS8fT74Fy7Jdl2Yj+kie1xZ2SawdBQRl4vfkQ9mkQbjHkmCFIK8p7/A6KgpSbEqfOhbgE0KGorVV9Q3wVBhQkqFdx0iN4n2xWzqdn6QvHSLN1K8nVDQyCXAaqUYWmDKeN6he1jOKlvbbNhq9kLUHfSalbuKbRl3SQYY8sq1ebb4IVhViksp9HFlWAhKS76+AyqFQEmdELkVPsPmbpP6donqv9MaHTx45jSMA5tHwBqXW6SbGgf39ZcwRdmJtpetIpEwKakjZvTvDrwSobm4HDHYTG7UlUsxcM06fam9HkifO94TdS8OPntVWC74S1fLjN4i8jPn3O4GQeOEpq1XqHH7sY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148); SRVR:SN1PR12MB0157; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 4:Yh0nnjAynZI+vVNjEyhuLV3JKE+KDAD/a7sedjXEZ2Kl/WRgKUHeUm2K0/D483V/luHheg7y3AxhHlgVCSRP9JyLR0k6D8RyU2DTuliy9ruYaLQxiBpA1a/QSVi8bwmnysNXh9UfMGzIEkyvnx4igkd3MtwroiQMVLi6ZLNd1i6WGyPW57LYztEHbbO01mWc6/xCy4lAXIn9WGK3Wsmf9StTZLzphsbiE39LxRonP7TY00IE16LnsU8lYodo9rQ5bOcAFW9IRbA9TgmluvBKSsVQe5TxezIZ3oYrZNs7IZlLzFxQ7VSGLIHEYOEmrhtNkSkt1Q4fLQ/gTP59ASnpOHcNEnxcXYCDzpR6Pc2XSHeOWV8SE9nH3W3Bmz90YabySZVY0BtSVdcwEdFSHEUTzTyA1qUYWBmoFGvGvNDIjyi8MhcnpdxSxsfL4+o1WfqU6E8SjHJsDNmLE5/VpmozLE/fE6e0R63+5aZElWzehAhH0j2ShGiuShYT2IQF4GFEFbDm0K5VjWtXpvpVNDXpKBDkey1zlyJf9ppRfsKUxdM2UdrHXUcR26zEQxoF6DqQn78sOUF3gr0V93IIlGKJWSYCyYEMB0qK1nd/cBfaLIHApKCUYdiVl0EYPq5DFo4PbLNT+xi/CDOkVSquv5WYwcm1yhGDCI0T/Spa9LLIBfO9ZirQ6zeGOYuNPFiebUSmNY8IIOq0FuhF+cfHdN0VBi+cS5j54/PnYvDvhmIM2xEwwd4rPD8/5kkjrRXXPYtzyD1+6ohojjssyCfKl284jecaRXU4RI6Gva9L3+Ed0wq7+buD8cQFAwqXh8bruhI8 X-Forefront-PRVS: 0318501FAE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39860400002)(39840400002)(39450400003)(39850400002)(39400400002)(39410400002)(24454002)(377454003)(3846002)(23676002)(6666003)(189998001)(77096006)(50466002)(38730400002)(36756003)(2950100002)(31686004)(83506001)(33646002)(50986999)(93886004)(230700001)(31696002)(86362001)(6486002)(8676002)(76176999)(90366009)(7736002)(305945005)(65956001)(65806001)(6246003)(2201001)(47776003)(66066001)(4326008)(54356999)(65826007)(5660300001)(53546009)(81166006)(6306002)(478600001)(53936002)(42186005)(54906002)(25786009)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0157; H:[10.236.136.62]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU3OzIzOk5XbWhSMXpjaXk1T2s1dTgxWkNkRmlXYkdI?= =?utf-8?B?VTZJNUZWeUdHWWRZNTVmMURxdGhrcks4NlZueW1jMXpnMEEybHhiRC9JclNZ?= =?utf-8?B?ZnFEa09XRi9xNnByVmtROERhTGxFZVRDZnM5QlRMallCbW1lWWFhbGtWZmpx?= =?utf-8?B?YnJKTUU2dDlkTkRHcVRrdHYzSDB4bXV2UDU5aHIzcGEzV3gwVTFlZEdkREY2?= =?utf-8?B?c2MrdW4wckVqMFhrdEJCVDNXVFpoaUpONjI0bS9wRVgvcGF3bFJCVGN6RUJ4?= =?utf-8?B?QmdrYTJJdGg2SEViWnRUa3JObUQwUHNmKzZhUjhqZzdVcGQ1VVA4bHdVcU5E?= =?utf-8?B?bzE1c1dsdVM4dDJ0dVdxRko5ZzluKzg2cS91dkpPalI2R1dObDRlL1I2UWVX?= =?utf-8?B?WHZIRFk3UzhVaVoyYzVzZ2tKUFdqWGROTUovdVFpeXA3cTFvL3l5RFhodE5Q?= =?utf-8?B?b1JKeksyeGQxTWQ0bU9rWnJINEFwYStYdEZpM3B4Z1IwdytiVVptSDJJQndx?= =?utf-8?B?WHBva2s3VG9CdWwzMzhFZm1MOFNnc3VUTFJNMVZTWkhxSC82dkYyRFp0NmU5?= =?utf-8?B?dnZiUkt5RFZYTnV1Vm5wc3JNSTFZaExNdFZSbnhDUU44VTN6bG1GTE8yaXg1?= =?utf-8?B?R0tEMExwdXJVQVJZZEpESmF1MTg0N0JrZCtlb3FJRVQxMXlBWStNM21yUCtM?= =?utf-8?B?K3h6NDcyOFRobTBzSU1SWisvYUZWbHA3QU9TeU0rK21XMm9QcTNxdjNOZEJp?= =?utf-8?B?RGlpTDN3OUd5MG4yWWRrTC9zWVoxbThhSlB3WVV4bVEweEtTeVo5YnNjRVFl?= =?utf-8?B?Wmx4bTJTQ3BBUjhVQ2ZNNWdsVDA5dlBqcGtFKy9RWDFJZDd0Y1FYWGYwdGNP?= =?utf-8?B?YjR1TFU4aC9FRUN5SmVlWFlsSThsWkZhY0ZleEpobm9ITWp3eHl4Y1VXZHpN?= =?utf-8?B?V1pNVzNqQzNBeHYvaE5jU1dOZmFLUEZyRzN3d1hrV0JZVERTNGl3SUxtVnZC?= =?utf-8?B?TkpTem5DVkNocHQ4Qit4NlYxRzJ6ejBHTGdtTVFTcHRPT3lKaGNrTWthajJR?= =?utf-8?B?MTUzTithMFJWMUdpMXphMGdLN1kxbU4zVktTRUdqRjRna3c1ekpGZy9DUk82?= =?utf-8?B?ZzdaTmNmTDJrM2lmS2NwaXEvT2lXS1VrZk5VTjUxSStSMDl6aTNHSC83RXhC?= =?utf-8?B?TTFNcHZ0Yys0TlpOT0V2NHRRR1BQcUt1QTY5MFNRS1VaVlllcFc0S09hdHJJ?= =?utf-8?B?T2k1TWZnOWl2SWpNR245dTl0OWNDTk8xUmVEY3d5aGxuYmN6N25DeGJGdUtv?= =?utf-8?B?UXMwR0ZjdGhSWkZQSEphci9SRGU0aWQ5TTQvdVNIVWRMMExaS1MzR2pORTZZ?= =?utf-8?B?NWEraUhzdTBQVHRzVDBEdWgwMEJscnVQcSs5R3BUS0o0MjRXN05pL1NmRURm?= =?utf-8?B?SGZ0Y1ZMYldXM0hpQytkWDhvYnRqQllvMHp3c1NObk5xa3VONUNHa3RnUTFD?= =?utf-8?B?LzZISUNxQzR2b0VpbFJ0eXJYUUhLYzBQSzFrYTgwYmp5OHdzTGFRc3U4SWRU?= =?utf-8?B?cmx6Z2ZaVEwzd2hENER6YjNmQVFCUFJWczFzRjlqVE1HMnVKcGZOSmJuRyt2?= =?utf-8?B?RjhhNVFvTDEvS3Y2UVpNUERPMU54V21obDBsUi9XZy9lN2lsUUxzN2NtL2dY?= =?utf-8?B?U1kweDNTWVdaMVRpdHFhWXJwdkd3VFJoaTIrVkFRRStVSXlIdVU2emdpS1lV?= =?utf-8?Q?LsIuUF6osEAdJ2j23dgrS6A6wj7bsy4/j83ns=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 6:cS5YAwI2agSJS28+BVRARYqjyrvH/ZusG2GIVhZLJ9HrSkm5xZbRVCc+Mlstp1gLKiK6igq2sPldXqW0j5hyBCzQ6yiPwRN77c6ejt8fJGJH5jOzLt9igXqtXRMmM64N8UumlLR1RPcBfyytqpgwyAeB9wMSNZ990eIn4zvOgaNaIMlk+ppfojagzzIPelAJnzuk1WTHxYlHeey7N7yfDGdGFUmr0XjqVTF1zeNPflwAtcHzyXVWf3Fpk3b6JEfmgKm/lu2AwDTB79HsLO2jQLN1OFei9vAWU3HG9V5LqldYtoEbcJabrye/M5N3nBC/kknjBWugv0Jat7k6e0S0SC+2jKhCsRPYlHfd2OW8fiiH1RUGpR2UZI+Udh3D/zsVqGc38rh2BCBR1dkYqduG9xADIsrexai899z3wylZpVjAhNWXWUpJjP8yyk7j8dwYjeUNWMVIfu1Wxsd6lv/Qx4Y7KH6S7dNJFEf7YKHqebUUxyj9ZqJXlO2e1U/DhWEP7sLR1iwXe5z3KD6//re8fHjCSIx4JoIC2AKpEJpQWkk=; 5:TokR2opYYg47K0ionwpQCtimmqWc0Sb3lggtoo5dhFmZDn2en9SPxiFRaseosGtIHJBbpQ5R6gfByYFkTcmUebLF5MwDuZDEkNUbgPxOSbPs9iZSmar+HI7IsyIsvOLkpzBGxyVh2RvgDo/5RTYDaB1v3Iy7N7Qk9Sy6mhsAzZ8=; 24:qRNnvZOny4xbo7AOVkHqDnfvGn+ZGZNkSQoit3Xxr4soZiOJwDR0Yrp5yCiWB+6uUKWxeukPGAkzgZ5AyfQFxr7ELLMpSM6mCr4mNO3r4TY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 7:DJjzQWHmZ3pKR7gLEHBKuidxhL1tQCqI3ovlC3tXwH3eXK8JvrDxCqu97vo1Tm6dPKzZiPzvG26dgZEDMLuTA3Tknc/c1AEgkHvMzv//5g8FZ/RjKQq+msW890V7lwBuSqEB0C9mRhkAuI3r/gn8kIGG0rZxF8GTxU4K0IfWAT1dYlCm4961ECemRYYs27zAbK+bSxONT0Ue2PsJhjXcOHwQllbH4yRk9Mgv6M8GnNk5aqeVIXfH6V6/YjhiptSfpxXFMsT7gztJ7b+kIZGqCY6bX/vJUvmkthX+EXvOelJ7FYtikFZo6Qh3Gt7Jb0RW10YuIwgd+3YC9glbJxpN/g==; 20:47+bZ6vbqRjLKpTsX42fvLEUOW+iofSS4nHlqlsZyVpQFG8L9ZSMaNXurnnnz4S/UWtew0z/kVUqOCZ0N+LFpjqQKnISnup7GhubajqBfZExGQ9HYJq2+hVOPXLUALwAcNOr4btXs+fByIg0bcIvsxm+OxVl7EVgKtVOXU0Qp5+reYUf4pVC/ZwLTRs3mUgdhPfYo9x3ZcdP3CDUFRAGPiL/zlWRPTBEdHoW3JgW/kKt2/7Y/qQW2q0idPLc8uyA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2017 18:23:43.8160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0157 Subject: Re: [PATCH v5 04/14] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 18:23:48 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/25/2017 10:10 AM, Laszlo Ersek wrote: > > The canonical way to write this DEBUG invocation is: > > DEBUG (( > DEBUG_VERBOSE, > "%a:%a Set C-bit Cr3 %Lx Base %Lx Length %Lx flush %d\n", > gEfiCallerBaseName, > __FUNCTION__, > Cr3BaseAddress, > PhysicalAddress, > Length, > Flush > )); > > (Do not miss the indentation of the closing paren(s)!) > > Please refer to . > > If it all fits on a single line, not exceeding 80 characters, then you > can keep it on a single line. > > Otherwise, if you don't fit on a single line, then you have to break > every argument to a separate line. If your format string (or any other > argument) doesn't fit on a line in itself, then you have to break it up > too. > > Earlier I'd been using a "meet in the middle" style, where I wouldn't > exceed 80 characters per line, and would indent the continuations by 2 > additional spaces, but still wouldn't break each argument to a new line. > Example: > > DEBUG ((DEBUG_VERBOSE, > "%a:%a Set C-bit Cr3 %Lx Base %Lx Length %Lx flush %d\n", > gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, Length, > Flush)); > > In my opinion, this would be the best compromise, since (a) it keeps > lines under 80 chars width, (b) conforms to the indentation requirement, > (c) doesn't waste vertical space like the official layout above. > > However, this style had not been approved, and I abandoned it in favor > of the canonical style, when I filed > . I will follow your recommendation. I will wait for Jordan's response on your IoMmu patch suggestion and include all fixes in v6. Thank you so much for feedback. -Brijesh