public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "Aktas, Erdem" <erdemaktas@google.com>,
	Oliver Steffen <osteffen@redhat.com>,
	 "Yao, Jiewen" <jiewen.yao@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>,
	 Liming Gao <gaoliming@byosoft.com.cn>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging
Date: Thu, 1 Feb 2024 15:14:39 +0100	[thread overview]
Message-ID: <3jj3lyr7gmuzzdp6f7dnj3ow6sox5uikdx7ysb6xuoxryghuzn@r3jatiaty24n> (raw)
In-Reply-To: <PH0PR11MB5064BCB95ED7E6C10FEECF59C5432@PH0PR11MB5064.namprd11.prod.outlook.com>

On Thu, Feb 01, 2024 at 05:44:30AM +0000, Xu, Min M wrote:
> On Wednesday, January 31, 2024 4:24 PM, Gerd Hoffmann wrote:
> > On Wed, Jan 31, 2024 at 06:19:38AM +0000, Xu, Min M wrote:
> > > On Tuesday, January 30, 2024 8:32 PM, Gerd Hoffmann wrote:
> > > >
> > > > Patch #1 has been submitted separately last week.
> > > > Intewl raised concerns that removing or renaming the PCD breaks
> > > > platforms, so I'm just doing the minimal fix here.
> > > >
> > > > Patch #2 + #3 update OvmfPkg ResetVector and PlatformInitLib for
> > > > 5-level paging support.
> > > >
> > > > Tom, Min: can you test this patch set with SEV / TDX?
> > > >
> > > We test the patch in TDX with PcdUse5LevelPageTable TRUE. It failed if the
> > td-guest is configured with multiple vCpus. We're investigating what
> > happened.
> > 
> > My first guess would be we need to somehow propagate to the APs that
> > cr4.la57 must be set.
> Yes, we make a quick poc that set the LA57 for APs. It works in multiple vCPUs scenario.

Pushed branch with two experimental patches:
  https://github.com/kraxel/edk2/commits/devel/paging-5lvl/

One for tdx, writing different values into TDX_WORK_AREA_PGTBL_READY for
4-level and 5-level paging modes.

One for sev, which adds a 2-level page directory for the first gigabyte
and places it at the same physical address it has in 4-level paging.
With that SevClearPageEncMaskForGhcbPage should work unmodified in
5-level mode.

Test results are welcome.

thanks & take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114947): https://edk2.groups.io/g/devel/message/114947
Mute This Topic: https://groups.io/mt/104052206/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-02-01 14:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 12:31 [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging Gerd Hoffmann
2024-01-30 12:32 ` [edk2-devel] [PATCH v2 1/5] MdeModulePkg/DxeIplPeim: fix PcdUse5LevelPageTable assert Gerd Hoffmann
2024-01-30 12:32 ` [edk2-devel] [PATCH v2 2/5] MdeModulePkg/DxeIplPeim: rename variable Gerd Hoffmann
2024-01-30 18:58   ` Laszlo Ersek
2024-01-30 12:32 ` [edk2-devel] [PATCH v2 3/5] OvmfPkg/ResetVector: improve page table flag names Gerd Hoffmann
2024-01-30 19:04   ` Laszlo Ersek
2024-01-30 19:46   ` Pedro Falcato
2024-01-30 22:28     ` Laszlo Ersek
2024-01-31  8:14       ` Gerd Hoffmann
2024-01-31 11:22         ` Laszlo Ersek
2024-01-31 17:50           ` Pedro Falcato
2024-01-30 12:32 ` [edk2-devel] [PATCH v2 4/5] OvmfPkg/ResetVector: add 5-level paging support Gerd Hoffmann
2024-01-30 19:13   ` Laszlo Ersek
2024-02-01 15:44   ` Lendacky, Thomas via groups.io
2024-02-01 16:33     ` Gerd Hoffmann
2024-02-01 23:31     ` Laszlo Ersek
2024-01-30 12:32 ` [edk2-devel] [PATCH v2 5/5] OvmfPkg/PlatformInitLib: " Gerd Hoffmann
2024-01-30 19:15 ` [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging Laszlo Ersek
2024-02-01 16:01   ` Lendacky, Thomas via groups.io
2024-01-31  6:19 ` Min Xu
2024-01-31  8:24   ` Gerd Hoffmann
2024-02-01  5:44     ` Min Xu
2024-02-01  8:45       ` Gerd Hoffmann
2024-02-01 14:14       ` Gerd Hoffmann [this message]
2024-02-02  8:30         ` Min Xu
2024-02-02  8:44           ` Gerd Hoffmann
2024-02-02 19:28             ` Lendacky, Thomas via groups.io
2024-02-12 15:13               ` Gerd Hoffmann
2024-01-31 12:02 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3jj3lyr7gmuzzdp6f7dnj3ow6sox5uikdx7ysb6xuoxryghuzn@r3jatiaty24n \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox