From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4D3DA7803DE for ; Thu, 1 Feb 2024 14:14:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=luW/XVHK4GvTboGu31QSRSEFfFXx/hpriTzY5Dh3AHE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706796890; v=1; b=kMImPs2Gn7ucTN7xIE5kwiuEdVFx2ETWZsMqntbBW2G9YU9UVkgINoc9VSxpIYObcg+Xficr YqLcjtqv8ZONiIU/M0ivSFr6kaZgfHooMURxFHuBsP5vhaj/BFMaWNEmfjA8xCv+GsN6wMbqDlo tYYvveP3JiV2/Ktz6sOdljbM= X-Received: by 127.0.0.2 with SMTP id WHEgYY7687511xfhnXq97HVC; Thu, 01 Feb 2024 06:14:50 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16241.1706796889176782864 for ; Thu, 01 Feb 2024 06:14:49 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-xzRGsuJoOnGo5IIhfcoC3Q-1; Thu, 01 Feb 2024 09:14:46 -0500 X-MC-Unique: xzRGsuJoOnGo5IIhfcoC3Q-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 896793806622; Thu, 1 Feb 2024 14:14:45 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 237AE2166B33; Thu, 1 Feb 2024 14:14:45 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E6B341800908; Thu, 1 Feb 2024 15:14:39 +0100 (CET) Date: Thu, 1 Feb 2024 15:14:39 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Aktas, Erdem" , Oliver Steffen , "Yao, Jiewen" , Ard Biesheuvel , Tom Lendacky , Michael Roth , Liming Gao , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging Message-ID: <3jj3lyr7gmuzzdp6f7dnj3ow6sox5uikdx7ysb6xuoxryghuzn@r3jatiaty24n> References: <20240130123204.764453-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dRuZeLv52xBVYMgSktKWvOUNx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kMImPs2G; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Feb 01, 2024 at 05:44:30AM +0000, Xu, Min M wrote: > On Wednesday, January 31, 2024 4:24 PM, Gerd Hoffmann wrote: > > On Wed, Jan 31, 2024 at 06:19:38AM +0000, Xu, Min M wrote: > > > On Tuesday, January 30, 2024 8:32 PM, Gerd Hoffmann wrote: > > > > > > > > Patch #1 has been submitted separately last week. > > > > Intewl raised concerns that removing or renaming the PCD breaks > > > > platforms, so I'm just doing the minimal fix here. > > > > > > > > Patch #2 + #3 update OvmfPkg ResetVector and PlatformInitLib for > > > > 5-level paging support. > > > > > > > > Tom, Min: can you test this patch set with SEV / TDX? > > > > > > > We test the patch in TDX with PcdUse5LevelPageTable TRUE. It failed if the > > td-guest is configured with multiple vCpus. We're investigating what > > happened. > > > > My first guess would be we need to somehow propagate to the APs that > > cr4.la57 must be set. > Yes, we make a quick poc that set the LA57 for APs. It works in multiple vCPUs scenario. Pushed branch with two experimental patches: https://github.com/kraxel/edk2/commits/devel/paging-5lvl/ One for tdx, writing different values into TDX_WORK_AREA_PGTBL_READY for 4-level and 5-level paging modes. One for sev, which adds a 2-level page directory for the first gigabyte and places it at the same physical address it has in 4-level paging. With that SevClearPageEncMaskForGhcbPage should work unmodified in 5-level mode. Test results are welcome. thanks & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114947): https://edk2.groups.io/g/devel/message/114947 Mute This Topic: https://groups.io/mt/104052206/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-