From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C66C941A2C for ; Fri, 1 Mar 2024 14:53:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YSnttw/Zt2DggzeBktj9ljatTJleD9SIuFbdzFqO7j4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709304778; v=1; b=q4UXhLJQlv6P7URd8YRUvhLJMYt57UknILySEZlUk/fDOU6aI0B6RiXrM3MPS6yXp4LkMTkv n4IWICUvRNCy4O8mwPytO9qHBzAGEELEEbq4D4cflMkqdaWJX/wFJkXpsUfNMLXOkaxGZkYkOfD ywqKDyYGmiKU/rU4wUIJ9njs= X-Received: by 127.0.0.2 with SMTP id k7u8YY7687511xy0jkNgv8lO; Fri, 01 Mar 2024 06:52:58 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.24830.1709304777945251367 for ; Fri, 01 Mar 2024 06:52:58 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-B2npNt3nMAmPCpfFXKE2mQ-1; Fri, 01 Mar 2024 09:52:54 -0500 X-MC-Unique: B2npNt3nMAmPCpfFXKE2mQ-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 857E328B72EF; Fri, 1 Mar 2024 14:52:53 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 472842166B5E; Fri, 1 Mar 2024 14:52:53 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4556E18009DC; Fri, 1 Mar 2024 15:52:52 +0100 (CET) Date: Fri, 1 Mar 2024 15:52:52 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Jiewen Yao , Oliver Steffen , Michael Roth , Erdem Aktas , Min Xu , Ard Biesheuvel , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer Message-ID: <3kazdjorbbsvwsutvfzhbgwpvcauwx65d2oe6j4t7wue3gvrb7@as3lvlcf7rqe> References: <20240301074402.98625-1-kraxel@redhat.com> <20240301074402.98625-10-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 79p87i6bHEK7PoZXsCk7AJ4Qx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=q4UXhLJQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > OneTimeCall CheckSevFeatures > > + cmp byte[WORK_AREA_GUEST_TYPE], 1 > > + jnz NoSevIa32 > > + OneTimeCall SevClearVcHandlerAndStack > > > > +NoSevIa32: > > ; > > ; Restore initial EAX value into the EAX register > > ; > > Did you miss Tom's review under v1? > > https://edk2.groups.io/g/devel/message/116176 Saw the mail only after sending out v2, updated my local branch meanwhile. > I'm ready to merge this (adding Tom's R-b, if you, Gerd, confirm that > that's what you want). As stated in the cover letter I think it's better to not (yet) merge patches 9+10 because BaseMemEncryptSevLib is not ready for 5-level paging. That way SEV will work fine (in 4-level paging mode) even when building with PcdUse5LevelPageTable=TRUE. thanks & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116260): https://edk2.groups.io/g/devel/message/116260 Mute This Topic: https://groups.io/mt/104660115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-