From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BFA6C941107 for ; Thu, 25 Apr 2024 07:53:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EhCNfDQuZYZF8AN8b57BntSFOHbwwe+WqyrYFdqDdrM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1714031629; v=1; b=tGWskVTC3URx87YNCOdCIFSZK6p7mKtDUatlkefRiiFAINqwyzBYz7MNxrLKztbkdZGYORvN 0MiLHZijwXvdNn2wMFVIP7QeTG0aY1NVY/zCgT33AHYNiCrmViZFf2y/qtp1sEIQ1AiXeju5yCp DKIdX7SHMRZUIw8Lwhpm0CClWpjPRJ5Z+5fGUvJS+WnmXqTJrIht3aJwAXLuMaPoFkj5pCZHvkx IwqTfyoYA47t3fc5Q0iTmxrlZQfqrZBmKsgFqpiNNPq7K0rsrHYUXKCLpmpS/pPaN91MnPQbJGK NASBY0huuMsEQ3yjctIw7Aoa/Cv5zOII8fWzUKJ1r846w== X-Received: by 127.0.0.2 with SMTP id EZ8TYY7687511xfj3KnZVvu5; Thu, 25 Apr 2024 00:53:49 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.11662.1714031628346630804 for ; Thu, 25 Apr 2024 00:53:48 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-MAX8Mq7YMKyeKbSOGDHBMw-1; Thu, 25 Apr 2024 03:53:36 -0400 X-MC-Unique: MAX8Mq7YMKyeKbSOGDHBMw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0B9C800935; Thu, 25 Apr 2024 07:53:35 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 500372166B34; Thu, 25 Apr 2024 07:53:35 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 953C3F6B9C; Thu, 25 Apr 2024 09:53:33 +0200 (CEST) Date: Thu, 25 Apr 2024 09:53:33 +0200 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Xianglai Li Subject: Re: [edk2-devel] [PATCH v2 3/7] OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version Message-ID: <3panc52jjcnvf7cml7wllbqirsr2bjnvn34ulonxp5jkz7hj5h@2y6deto2c5fp> References: <20240425041728.1385891-1-lichao@loongson.cn> <20240425041821.1386403-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240425041821.1386403-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Apr 2024 00:53:48 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9UvLx7acvRz9cWdsNDYv2xLgx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tGWskVTC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > +UINTN mFwCfgSelectorAddress; > +UINTN mFwCfgDataAddress; > +UINTN mFwCfgDmaAddress; Hmm, global variables for PEI? I think the point of storing these in the HOB is to avoid the need for global variables? Also does that work when running PEI in-place from flash? > +RETURN_STATUS > +EFIAPI > +QemuFwCfgInitialize ( > + VOID > + ) > +{ > + VOID *DeviceTreeBase; > + INT32 Node; > + INT32 Prev; > + CONST CHAR8 *Type; > + INT32 Len; > + CONST UINT64 *Reg; > + UINT64 FwCfgSelectorAddress; > + UINT64 FwCfgSelectorSize; > + UINT64 FwCfgDataAddress; > + UINT64 FwCfgDataSize; > + UINT64 FwCfgDmaAddress; > + UINT64 FwCfgDmaSize; First thing this function should do is check whenever the HOB already exists. Should that be the case there is no need to parse the device tree. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118277): https://edk2.groups.io/g/devel/message/118277 Mute This Topic: https://groups.io/mt/105724970/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-