From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.79]) by mx.groups.io with SMTP id smtpd.web10.7295.1663771631195701762 for ; Wed, 21 Sep 2022 07:47:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=jiAxQG9Y; spf=pass (domain: arm.com, ip: 40.107.20.79, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GXFizbppuiUBS4G7tqeIJOSFEMact+Ji3fXPpm8ou8FNqiyur7qb/Zj7o52RO1UWXta24L/cbC6nWMgiVIvDH0kTtswcR/cR4jNufRwO4OSrchRrMXMDeU7h9rvWQMZUGXbTqTn4rkll/g5JthOjKOtKc3xMz/PpHoaxStweU9xHvvoI8BaSSRvwlO5Dwaixaa9U+ZM/ReQuzXiNxy3BrK1BzVHUBYiKrSZChSbi9WJgFWkBZqrbaR8euv4o6HIgjNGw/qLwxSbMbL5Uj+y5TgwbpMWEH4SXkNRgGXjezHUsj0WLjMkz9awWzgGbemGLSG0lxEikyEOdrF2xxp3egQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnFRj6SNz4Z8dLri4Kz01qcRr/wqcgWU/8Xi45UpaX4=; b=OIcZjuC8QOWuJlgqFPTPR8bDH9enVKfes3qSqUyLx+FNwpXRkS8i28p/w/SL4Z8U4/OmtqSK8Rh3Yi+oYSzgF/QmoXDjOP8sh5zcycuIX23/VX/FTAWuRl7l7C7HV9eWuSB78rkBqVTjxOAUfSB/KLkipRV6nuS5ltOh3wUH1r8cCLncA2ZASDytg0wqBwodPkBnAZCO6gHqiU1i5EY5zQJdfRMsVcucVlCf2/9vpjH7eZwZioVostoid3MLWjf3Sba8ERvojBjTjt8KFcqaooJFGgRh9GXAlf1ggCgzkjB3LdYGuJrHfPtZMKYlrsLWMtjCNKVCUX4tUqAlKsug/Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnFRj6SNz4Z8dLri4Kz01qcRr/wqcgWU/8Xi45UpaX4=; b=jiAxQG9YN2lQEH40IXry28l3pq9Rfd8H/0mKwcB8Upqlh/4LVDj/kcnrfuAdSrJe2aguuaHA65j5qxkWhcl+luCO1cL5fkaQOPz1LSMuMmVlQ6Fgga122PWFUnx2CJos8ZMNRZPrzL+4m3o2Qc6coP1x5wOEy/HtipKdNdUAblM= Received: from AS8PR04CA0114.eurprd04.prod.outlook.com (2603:10a6:20b:31e::29) by DB9PR08MB7511.eurprd08.prod.outlook.com (2603:10a6:10:302::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 14:47:01 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::4a) by AS8PR04CA0114.outlook.office365.com (2603:10a6:20b:31e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.15 via Frontend Transport; Wed, 21 Sep 2022 14:47:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 14:47:01 +0000 Received: ("Tessian outbound 3c27ae03f5ec:v124"); Wed, 21 Sep 2022 14:47:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2f5fb5519468f097 X-CR-MTA-TID: 64aa7808 Received: from ceb8566e43dc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8ABECB92-BAE4-4D94-AC08-047279FF9FB8.1; Wed, 21 Sep 2022 14:46:54 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ceb8566e43dc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 21 Sep 2022 14:46:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AjFFY9pf3wJ10Delq+Z5vPdLLnEOrqyn7o8RXhqRXsIT95eaFYuz5TtI8XpWCm/mkcZovA4dnojW3jhaUXkg6NdKMYY7h9JIF25wWj6+u3oNJIYVWUcCF4QvDf62zzzOsMqvloJUbOcrs7EjWlbIOQHZ89FPa7IqRBPyKzyAvQsw9FTdJKeBcpcMNQlgfA3D+plNR2/Mo6o5Zu8mD6u8USQQ2NSM/69Q7D1Rjcg06zhpUf6ReuErtT+AgEQurrRJNEZg9pUpv+cgknpeQ8dRhhu4AUHRein/uPledIieeR+AdE66HLQ0qiGQw7ncYTcr05oDdSNkRm2glye4qc9bLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnFRj6SNz4Z8dLri4Kz01qcRr/wqcgWU/8Xi45UpaX4=; b=J7PTiQGNanIgCUQVNT0b7lJYlkhuTZw3w8kvj/9lQTEbGc/p8FCoDK/WgJyr0Sm48S6S6YKVfJ/E1sBqnzamqydA++LtNVW5uyeopb80oKWTiTO2jUv/V4ySeSOJpAa4uPpt35HvV0UrSfUO6PErtwci30wYmjC1apIUyUNZAOUXutnL5nWNx1K4dcraGjP8IKEJUuXDpHDjxgKwVc0jAiRXhxWl+RWsFy+oNx7LnRDYl+F3VedxGYytl4bCM9n8Iam9pa4Dfhy+8okhDS5dj266ATKQ7Ksa4H63T/4807XhsdcSlm65x6psN7UkLL04qoah9WAHDy7DfFlSh4f1jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnFRj6SNz4Z8dLri4Kz01qcRr/wqcgWU/8Xi45UpaX4=; b=jiAxQG9YN2lQEH40IXry28l3pq9Rfd8H/0mKwcB8Upqlh/4LVDj/kcnrfuAdSrJe2aguuaHA65j5qxkWhcl+luCO1cL5fkaQOPz1LSMuMmVlQ6Fgga122PWFUnx2CJos8ZMNRZPrzL+4m3o2Qc6coP1x5wOEy/HtipKdNdUAblM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6542.eurprd08.prod.outlook.com (2603:10a6:102:158::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 14:46:52 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 14:46:52 +0000 Message-ID: <4022d6ff-ab6c-d962-7501-aee9df1e25f9@arm.com> Date: Wed, 21 Sep 2022 15:46:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [edk2-platforms][PATCH v2 2/2] SbsaQemu/OemMiscLib: Fix typo of "AssetTagType02" To: Nhi Pham , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, "nd@arm.com" References: <20220919021904.2110188-1-nhi@os.amperecomputing.com> <20220919021904.2110188-3-nhi@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20220919021904.2110188-3-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB6542:EE_|AM7EUR03FT052:EE_|DB9PR08MB7511:EE_ X-MS-Office365-Filtering-Correlation-Id: 778b2bc4-edf7-454d-228a-08da9be02456 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DMI3iDwambFNlTfQCM2llPJ3Z7gkALjaEWzkJ6y8EoxJAxierVmIQXsvSjNRyplMVq0oh1pigdLKJj2lwL29+Js8sDPwM9IS3LrqH1p77LrZ3l7P7e6JTu0lNccZpboBRLBXKmFe05OSgjXayFNi60omU8QGd7mLcsG0dm/Vl8OH8VFixrEd+qt1rv8MJ4zAKdU2hE1heA6DPMb2wGxhqn6sW5hAI+qOXnlu0oJorxTpmVk4uyNtdn8QwY+/0CxUmiVZo1u5o8e/2sK3xodPBuQ/2iTKvRTTN3gYimMvHefKUNLRyBG1i31+TLGZj6lwHnuC4fJKKz4hFivI7g6LPxZxPJ9XPflMTBA/MZt55sEpE7+6pTRfEII3Zky1MnmLQqp3b3FKiQRrGWxnk7h/PcuOMxFzlShuw37+GeoLqfZo6FjLC+MgwMXvGiUUiJg5OqkUJIeYdVWnVrvuD9ZsRYfhyGYerPX8w6Mv4aZZeAeY1OsCTQf+01ZBKeTA1PtBycWezGq6MOQfO7GoAF7VmF0HZqQvSHhNgwknsDz4/7C2jUD6JUP9lzVP61r4exuY02rU8iCsVT3Hm5O0WfVbaJ0YAh4zFZYXLGY3zvUHSckgx9/5xf2zKh7wYVcz65AHU5ma9TQSrWFURvjV4j5/iMDooggTD4MPJzeajLcz2/qVk0Uk43rDTMUd/M7R2IAFsxTCY5mmdfxks2nP9l7GHqwKpBCIVo/AFd8snfW7SZBFYL7bjS8HYDsWf+k4zux6usrHbCYoVqm+r6Uprbs1o9St2OJ2jK6XO9SxzEpuKtA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(451199015)(66946007)(5660300002)(316002)(44832011)(8676002)(86362001)(8936002)(41300700001)(31696002)(66476007)(66556008)(4326008)(83380400001)(38100700002)(53546011)(6666004)(6506007)(6486002)(478600001)(2616005)(186003)(26005)(6512007)(31686004)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6542 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ad4597a-f609-4f1e-57b2-08da9be01ebe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fvJ59Lyzy6t1k0DfYA7ffDxSleI/0pd1RNGS0raNmh+fFCUIQvEaJtONqC4zm5hbK/TrV50Ia2C9459aDgtUCcqnflIq01vsR8Pqyk2sQmlcgE40/cNzERGtvTAwmbBkmXick/QD7o+BPg3bGr3aFDY0hv8LxGvuuyM4al8VzcBLV8L2uU8XmL8DB43fpuYJYNk33b0HspJksX7tVexDcmEy65H5p2/ptsPMOdF8mYxQGenQdt+3a7Nv6ASkXVtuQt0CS5MUdeh9zgKYixSDgHXpoQOJIpP9Bvbt/ZhhsY8OH/6jCEPT2ij/ZxJZawbuZcSdHmWkX6DW9hNYhetFzaU4hv/UiE7GCoJtMVskWm8/ghVN4742t6/QTRT4XBPoLZxf4QNAEIIvpe3yquPeG3KIK1lVteYsKfhpTwjRwXhVnZIgRy5b4Fmb/H+JU8t2/3OdFIRYPDco/whkPd2kWJ3WIRYowqz0arnqmgWr55+Qy4do5JMBYhceDR8VtZ9mcF57rnIQzK3SSRlwJAHrqfUeFubeuv2Ei6hWzimrL0o8qZokegBPkUMVD2S6z/3DRvzk83sLsFqfp/AbyQcGTebiSzD2JN0sXKbCmrgW+ar5G+f8Fik7WOKiU0TDcRRwF7d8PezoRJ8obzQvb9zKYrm1UjYd1GPEOHGigHp5t5Ivp6TH81QX29pf2j140NwsrLowN7pwlUz/ljUnzr4Au8RYpHT2k6FfepwFwH0RQs1cv+flaQGL8oQFuYSMFk2x0AqvKiJM2YtBX3pVfEqBXpPH5EZHuBANurvkvkf2J/SfkUCeQ7Ao9/R+dtSz1HRj X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(47076005)(336012)(186003)(2616005)(6506007)(6512007)(6666004)(26005)(53546011)(36860700001)(83380400001)(2906002)(44832011)(5660300002)(40480700001)(8936002)(6486002)(40460700003)(70206006)(82310400005)(478600001)(41300700001)(70586007)(4326008)(316002)(8676002)(31686004)(356005)(81166007)(31696002)(82740400003)(86362001)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 14:47:01.0325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 778b2bc4-edf7-454d-228a-08da9be02456 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7511 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/09/2022 03:19 am, Nhi Pham wrote: > This fixes the typo of AssetTagType02 according to the recent changes > from OemMiscLib.h in the edk2. > > Signed-off-by: Nhi Pham > Reviewed-by: Leif Lindholm > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index 3ccf22bf282d..c38f2851904f 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -201,7 +201,7 @@ OemUpdateSmbiosInfo ( > case FamilyType01: > String = (CHAR16*)PcdGetPtr (PcdSystemFamily); > break; > - case AssertTagType02: > + case AssetTagType02: > String = (CHAR16*)PcdGetPtr (PcdBaseBoardAssetTag); > break; > case SerialNumberType02: