From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0062.outbound.protection.outlook.com [104.47.37.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72C8E20945C0B for ; Thu, 14 Sep 2017 13:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ixsaSM/PbtWS3MuRdlyTLR/k8EEkI+ofbzeAdf2Vgl8=; b=DbClNbG9f9OZuyodeIdELUWKoaZoABbPsY0zEExnhfGt5a/CcW39APuw211KPcLavCFfkZBlrzSHZ0scR6iqRbkiZLkEwNbNF0UfEn9vyxud8rwH6/YmCkMqgZsp/4oeSBk29afLI3b0oEa+yUtE/suB+FcRptsboJD7QZ9VZGc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Thu, 14 Sep 2017 21:01:39 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <20170914110822.112540-1-brijesh.singh@amd.com> <20170914110822.112540-8-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: <403728b9-a7d8-cef3-ca25-579428b53d79@amd.com> Date: Thu, 14 Sep 2017 16:01:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR13CA0075.namprd13.prod.outlook.com (10.171.162.13) To BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3977ec0a-6328-4bde-d2c9-08d4fbb3cb94 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR12MB0147; X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 3:/U85viht1AfhBuaLwxQFTLjFQzjblvKrnKpKFz15D3bFl/IPBdXVoz3FwtrBMfnqB4Oit6kGwx1WqO/BDpDlxUZZzAJIJyip+FBIUqjtLHRDMizfgFi5uBcs+KjBOxaSj5Sk5jZ+k/9+zogmKUeoqWtKnnnEPVqbB/ckrxQHJNXngqhxmlLYZfPSXilBjmFQJt+2g7eQYynIOil/UnBRWlbLUVe+eyypg9Xfcgcnzc16PtcF/+KUgEuguGJLN65o; 25:q9Rn2QNN87SPvozRzrSUBSfXW/AV4KATrGH+F0s7+Xf4bpByoMZVwN7poozbCqr4KhCWivkDsf7xJm1NIn3DuS17aM4VWhcCvvQRIRyLbkvh93nh8WAnUaHTmyUkoFdIFuC8v36MBzsx++dn8EBZxjmPP6O6IlmtDmeMCccbgsvN9TvqE4RtTOaTOUEIfMjDnjBYsZbqotlgULlvHfwmOsbdJ5kKFWnOjm2rGkQkTRVZcunN7/rNP7sOU7ImVN4qlPAs1HVuL3eOl1xWrLP1KLCHMeVX6tolvMxPoSovL3WMnUKcdnhxG9cVrwfzgxti9mie5iY8EflTSS5VtIRSyA==; 31:RZVP7g4VbdYcsWQ1pQXgDA10lj1RyaLNGjKNNz47yH/BFixfPB94UiAG7TNI0qTQ3z0HMCHmmZrrH8D9uCnpPq5xjlhgCkn2O+gexMiXbm+skoroH4IFFq+ZXSzfs58KAjoekF4FlpN5nUTjzetV5+jKBRFaYm5tiqeN3aoUzHcyfwWsglDVkQfJe/SFVfs6u622F2S79lpON31UtxpgfhDVkfDYLhwmuAZrVv+odvM= X-MS-TrafficTypeDiagnostic: BY2PR12MB0147: X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:xjRKDJx3ROVKKEno1S9+XkyCIKdKWLFz3rmEVReoUsMnoqS8AaD+/FhCwZu4cQO0rGrzyEC4XK3mi9m7Xftr9GpZW1lfGa77XxVGpKo9aXxGH6LeHL55SOvVBSGJOOcHRftLe3dt9LZChJxVa9vw+6bCRuCvlPkrZlbhgltXPlSGIIel9/UnZW730GUTqeCLjPjVY3zyKOrNhrB/fTHPvkRAQoP08unWWZ6nhXdovriz+bdTeTeSrMhlQvX1n8pkV/1uB3ZzrrQnIxW9QsMlpFzE2dkgS04VNqL2J0p6NrRsgZOj8qRJ4YNFvLQojRmjzYs+HxDiHeSDXfdMzubmE31oDpNT7/3GiVjmqZ78fgefjQZ6OFBch4jFWkv7lgNl97nbQ7WwD8GpQvcTv7udBh07AFopxf7UprfduwbHo0bPqMQNH7PkD6QLnxZDJEzv12UmUoJvzMDHHs+us7zyyBJhCXwWLRSfBSLQ5+7poW7sMpOMz3TBv+QxlhBJ6Hkj; 4:vK2ofuuLoFT2LVaNgIU/zDQZAwzkmnh/l7L+sSOCjmaw1a+Y45vtQeFyr20bfsfV6dvpsmrAn13oRTXn6cbJPlMG8+wBAzx0/Ng8k1WJj8poKfsBqCUSyloPRmdQa/QnZv4xMEv6fvNBbfEgQsvX7au7Q7o066VNRbqPunnFZ++6Vkccpk/iiEeDpi8QleVgRJTCnXxpYBHBv9BDRLKP1XnQgycxWmsUdb8UQ8ZuWBOjxqFgNaTuS5KBLnRVu8fs X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR12MB0147; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR12MB0147; X-Forefront-PRVS: 0430FA5CB7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(346002)(376002)(199003)(189002)(24454002)(377454003)(16526017)(53936002)(53546010)(16576012)(3846002)(8936002)(8676002)(305945005)(50466002)(7736002)(4326008)(81156014)(81166006)(47776003)(66066001)(6246003)(110136004)(316002)(65956001)(65806001)(230700001)(23676002)(97736004)(83506001)(106356001)(6116002)(33646002)(6666003)(5660300001)(31696002)(54356999)(76176999)(50986999)(2950100002)(101416001)(65826007)(86362001)(64126003)(105586002)(68736007)(478600001)(189998001)(25786009)(54906002)(36756003)(2906002)(90366009)(229853002)(31686004)(6486002)(58126008)(77096006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR12MB0147; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ3OzIzOjdScUU5SmdnWjZSOHBQNFpmZVVZL0NzazY1?= =?utf-8?B?T3dTYldxQjUxamwwOEJJRVlWcXczbHljckdQVDZvbE5BZ0tqK2hRZmdKUDhi?= =?utf-8?B?TDZKT3pTdFEydzZrY1pMYlFFcmdMaVQ2aXNOelkzR1dLaVZjVCs3UlpuY0pW?= =?utf-8?B?Qmx0eTVWbzZDS1RLdzVZZE9DVEQxSGVZcW9IY0dXa3d6V1N6MmRyT2RvMkow?= =?utf-8?B?aUxJT0JiZzJGRDdQNi9kRytFampKOEZsRXl6MVR3NzFMWTZkUUM0ZTdHUDJS?= =?utf-8?B?SXZqRnVYNDNJRnRsdzBhZVVLV1hodlB1WVJEZFFieEtHS3RxQkxaSnpTVXFR?= =?utf-8?B?dHdzVUFPMHdEaTJzTDN2RmZ0U3pRTzNUeGJlbnRtMzV1azZZZXR2RWZYMkpF?= =?utf-8?B?RC9BTWFNMHl0cXdHd1NtWlMrNlQvcUNZYWFXYjkzU3FEeWZBY3NZTm5KL0Na?= =?utf-8?B?azUwYTU3YnJkUlJJWStCMTFXZ1N4K0w3aUxyN1VPZ3lOK25pbkRpdlVKYitS?= =?utf-8?B?OVhDYlNJTFJUbkMxNEpaTDR4dkFNUGFBY25sYk9oUnpKdzFkV2dyVGcyWWlo?= =?utf-8?B?VG5VOEppUGVheU9CWEFpeHFPZ3FmNU9lM1pzcVBOUXRrU2MrRGdoWGlteTlt?= =?utf-8?B?MXV4ajQ3Z2k1SzNzS0VKSmRFZmFydDhIaDVXSTdZU3J5Mjl3TTNDd0c3Z0Yw?= =?utf-8?B?eCt2aHdqbW4reEZ0K05aVTdETHNjNlVvb0tsQm9janpHZS9lSjQ1SjJlRDZH?= =?utf-8?B?WWRqcHFreG11Qmp1aU9IU2Q3czRiTDVheE0yR0NTd1FoelNvcUlIbndUNWVn?= =?utf-8?B?dWxkZS9lOFh6RU5yZlI1bHBLMnRESmxaalY4aktpVHdXaGxDT2JJWUx1U0xE?= =?utf-8?B?Qy9acWdNeGt2VXp0Q3hqVXA5d0pHeC9WQndjdWdXVGJQL0o4QkxyRlJObWg5?= =?utf-8?B?bkwweTlCdzdxVks4bFEwVytHakZYR0Zhdnh0TG5hbE9GR09iRnd3SDZCcDU4?= =?utf-8?B?Y09mcEYzTkQ0TTNXaTc0bFNzb3JaSFNvZGdtZGNlaFhmTFdZYnVYd0pwMEZ4?= =?utf-8?B?SEVMQ2QwMlYyVkV5Z0Nsc2tCVCtJQ2hOMEN3dFdOSGhoejg5YVBTSEFiclJq?= =?utf-8?B?OEJvbGd3YTd1S2hwSGhTNTh1dVFySUF6R01OckswVncxNUxidWEyNmw3U01y?= =?utf-8?B?QS9XSjFBYmpyaGJ3TFJ5ckVWeTB0QjlNakRoVk1RVTV4RHZobGE2UUpCR0Rm?= =?utf-8?B?NXdDNXlMV2V2bUNTb3pVNDJPeWk5ZzlTQ2NQZUx2WTJybnZVU0tVb0pneElR?= =?utf-8?B?YlBRZy9sZUJoVW0za2p0b3R6dm5Wc0dLbE82OWNnVExpRktsT2dMclBBR1Nw?= =?utf-8?B?N2x5VUY5Nk0vOEZqcE5NQjhKcG5RMlpiR0dCY20yMHJSTDg4OUlGaGhwYkxM?= =?utf-8?B?YkkyNHNxeGovRG9tUnp3OHcxMmE0UktGUFZINnBsMWNrTVVYcmhwTitMVFBn?= =?utf-8?B?RGl2WEtmRk8rSHJ5MGNBT2J2NHZiZlhudUlIL2xLTTRZYm1DYzNGTDdrK05E?= =?utf-8?B?SlpOWCtEa2loWFFCejVNeGl2SE4rd0NxaG9TVnpRV0VlbFBmd09xYWRrWmtU?= =?utf-8?B?YmtCanE5MHZvc2JDbW9LSFNrbmJwNGxGbGFSVHZCa2hwaUVYLzA2MEFSQ1ZC?= =?utf-8?B?ZHVnd3dzbS9teWtMYjhsMjNTYlRydGoyQjF2YklXamh6WGptQml5ODdzVERJ?= =?utf-8?B?QWQ3Y1hpRHFrTWJncm1oNXNBVTlPeGJXNmx5N1JSNlBiVmptNzJjQnBiMEMr?= =?utf-8?B?WDN1d01UamtXQTVqQWxhdGo1UzhrQzFQNmdZbEJ2Vk11VENNcTNMV2R1bTFM?= =?utf-8?Q?1+Aa+GGqo8Q=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 6:B4qq+OKD2xHpnEgFstXyKxN+r/dvKYfZsaEMMZcfpHJCPNgl03LVHxR52gcrHqaWBF5lMoUhx/5bIsiKWksXRdI4q9+tcerv/eXya4jh7V1ITKq4drcPAO6Iphh+4j5W/3HkrMd7oAR7b4Kl04M9sVZ7Xv3emqfZ+wSn5jS7SQ68aSuoRvNkrViZa+DYQvlG9CGKXElCyYTRrYbPj85t/BvjsCTiUNZF1lPYaiv5Q7NHfEU01/nOx/uOuKL1CALFMcqYZ+jNb2X7pKZkBueSormoSfbsT6p2qQD8cGOWQxg7ZBDePcwL2lNPlRQDs9qnjc8Q4RlxrU//zgauDVU6Nw==; 5:PCJt/a1m+rdhBZE2LW8fBzSjK6r50EszkzX3HVTOhwroIKlANZmneGJkjljxQW9PM7H++DvCnewNqRPzty0fu5awiJzaMIW1eCy36N/T1IjMaps8u46lbe+RQUqWMzZ2kGZKHM25nwOLdo/uyGqgmA==; 24:VRPb5RZwLNWR2IYheN1m5tmHAL2Hozgu4fBDkO06nsEUTi2byD01k3T3goTKirz1u5GBjMAzsgPxsqAmq4XfdUHm0eMqUOQmEziQrVcaYJw=; 7:EhAZKT30K01w9/X1NPP+3DpmlN+mqyXJkiK293HzkebYhSHyExi3t0FmEWYIaajWBCCQgEKEOsKW/jNcKCaEAJ3iAcdN5b6KWDecgEprL3StM1qeLiNd8UzJbD9l2EjU70Nx+A9CTuPbJmVaA48xB1gSeOsDpih42/gZsJifusTVSVpBkRIcRq3gs5DUdv5NEmwLymv19CltsZGbhvdlboCZdni+/itjG1Aw4mLjnCs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:Wf/rtaIxRVri6UoKdqMLGOu4M+EmLUNsj7XRb6sIHLt/SHF4yLXqJBBodZSmzOjfsEgyJvaRO3htZ1YG8hYHDhKVb64d4fEnrJeVvrMfBP6+f5O+s26uwpq9PdbZNoXHeuzFxaobN7Acf5KHKtGwzewQUQnTcF70obCyA8tSgNY5wVtr6V8dkwneqn3blr0AX/DfhMdgcjs5pNKbUvuwdS8TYLhvkmv6J/glxyLoYN7WSStNWVlQ8SZ+yLopXswh X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2017 21:01:39.4484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0147 Subject: Re: [PATCH v3 7/8] OvmfPkg/VirtioNetDxe: map caller-supplied Tx packet to device-address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 20:58:43 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/14/2017 03:58 PM, Laszlo Ersek wrote: ...> > The rest of VirtioNetGetStatus() looks good, but here's the other > misunderstanding: > > (2) Please *keep* the ASSERT() that you are adding above, and below it, > *add back* what you had in v2: > > Status = EFI_DEVICE_ERROR; > goto Exit; > > The rest looks good. > > Can you submit v4 soon please? :) > Yes, I should be submitting very soon :) -Brijesh