public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow
Date: Thu, 1 Aug 2024 09:47:22 -0600	[thread overview]
Message-ID: <4067e3b8-b8a3-45a1-b392-695c869ce81a@bsdio.com> (raw)
In-Reply-To: <60936941-62b3-4ed8-b1b2-4175ff70165f@quicinc.com>

On 8/1/24 8:51 AM, Leif Lindholm wrote:
> On 2024-08-01 13:49, Rebecca Cran wrote:
>> Would you like me to add a note to 
>> .github/workflows/AssignReviewers.yml to say that's where it came from?
>
> I'd like to see it added *somewhere*. Where it came from and the 
> (short) commit hash at the version you picked.

My only hesitation is that I think Mike's copy was more a temporary POC, 
so I'd consider the copy in edk2-platforms to be the official version.

> Ultimately we might want to add things like this to a common 
> repository either directly referenced by CI/codeforge or imported as 
> submodules, so that we aren't needing to copy code arounbd between 
> repositories.
> But that's not for this patch to resolve.

Agreed.


-- 
Rebecca Cran




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120189): https://edk2.groups.io/g/devel/message/120189
Mute This Topic: https://groups.io/mt/107583542/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-08-01 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-27 20:31 [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow Rebecca Cran
2024-07-27 20:31 ` [edk2-devel] [PATCH edk2-platforms v2 1/1] " Rebecca Cran
2024-08-01  9:45   ` Leif Lindholm
2024-08-01 12:49     ` Rebecca Cran
2024-08-01 14:51       ` Leif Lindholm
2024-08-01 15:47         ` Rebecca Cran [this message]
2024-07-30 10:49 ` [edk2-devel] [PATCH edk2-platforms v2 0/1] " Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4067e3b8-b8a3-45a1-b392-695c869ce81a@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox