From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.13891.1671610023449033961 for ; Wed, 21 Dec 2022 00:07:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eyH6xXN/; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671610022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vNzMnxj/IzhbJl4I7IvR2EngOzI8007gzyCQoCzvGQQ=; b=eyH6xXN/9PvzeDxtByHa7AfM+iRU0DmIaA1W4dpEq1ABAB0eKSq586nZ4aNRVP6dG3cKsP Os4/kL6rwp42P+Nwtxnm11XfiPPYPhKxHji90zygQOfufM63bwzRl/I3MBN2kQD/NQTGyU jLKyyGnU9pWnAoPoGRsVJKPk1CGOdJE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-308-7tXWwFyiNcCOus3hEd5ayg-1; Wed, 21 Dec 2022 03:07:00 -0500 X-MC-Unique: 7tXWwFyiNcCOus3hEd5ayg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 52C233C02B78; Wed, 21 Dec 2022 08:07:00 +0000 (UTC) Received: from [10.39.192.193] (unknown [10.39.192.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 384E5492B02; Wed, 21 Dec 2022 08:06:58 +0000 (UTC) Message-ID: <407d54f4-537d-375a-224c-184fb5e2dff1@redhat.com> Date: Wed, 21 Dec 2022 09:06:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested interrupt handlers To: Michael Brown , devel@edk2.groups.io, kraxel@redhat.com Cc: Paolo Bonzini , Ard Biesheuvel References: <01020184f66682f9-7696e0c5-f2f6-43e0-962f-38f1d5af4859-000000@eu-west-1.amazonses.com> <20221209150227.wns5mhtcfismxtgd@sirius.home.kraxel.org> <01020185300e504c-6565abf9-f6d1-41ae-975b-4c59e33c2f2e-000000@eu-west-1.amazonses.com> From: "Laszlo Ersek" In-Reply-To: <01020185300e504c-6565abf9-f6d1-41ae-975b-4c59e33c2f2e-000000@eu-west-1.amazonses.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/20/22 16:02, Michael Brown wrote: > On 09/12/2022 15:22, Michael Brown wrote: >> On 09/12/2022 15:02, Gerd Hoffmann wrote: >>>> Add the Nested Interrupt TPL Library (NestedInterruptTplLib) to >>>> provide helper functions that can be used by nested interrupt >>>> handlers in place of RaiseTPL()/RestoreTPL(). >>> >>> >> >>> The idea looks sane to me and I couldn't spot any logic errors in >>> this. >> >> Great! :) > > Ping.  Is there anything else that needs to be done before this gets > merged?  It would be good to have the regression bug fixed. > > Thanks, > > Michael > series Acked-by: Laszlo Ersek Ard, can you please help merge this? Thanks! Laszlo