[RedfishPkg PATCH v5 0/4] Inital RedfishPkg

[RedfishPkg PATCH v5 0/4] Inital RedfishPkg

[Abner Chang]

Note for v5: Add reviewers's tags.

Initial version of RedfishPkg and the CI test
on RedfishPkg.

CI Test result:
https://github.com/tianocore/edk2/pull/982

There is no components in RedfishPkg in this commit,
the further edk2 Redfish components will be committed
base on this version.

Abner Chang (4):
  RedfishPkg: Initial commit of RedfishPkg.
  .pytool: Add CI on RedfishPkg
  .azurepipelines/templates: Add RedfishPkg to target build
  edk2: Add maintainers to RedfishPkg

 .../templates/pr-gate-build-job.yml           |  3 +
 .pytool/CISettings.py                         |  3 +-
 Maintainers.txt                               |  5 ++
 RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
 RedfishPkg/RedfishPkg.dec                     | 18 +++++
 RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
 6 files changed, 135 insertions(+), 1 deletion(-)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

-- 
2.17.1

[RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Abner Chang]

Initial version of RedfishPkg.

Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Signed-off-by: Wang Fan <fan.wang@intel.com>
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
 RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
 RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
 3 files changed, 125 insertions(+)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
new file mode 100644
index 0000000000..75c3b6a8ad
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -0,0 +1,67 @@
+## @file
+# CI configuration for NetworkPkg
+#
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+    "LicenseCheck": {
+        "IgnoreFiles": []
+    },
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        ## Both file path and directory path are accepted.
+        "IgnoreFiles": [
+        ]
+    },
+    "CompilerPlugin": {
+        "DscPath": "RedfishPkg.dsc"
+    },
+    "CharEncodingCheck": {
+        "IgnoreFiles": []
+    },
+    "DependencyCheck": {
+        "AcceptableDependencies": [
+            "MdePkg/MdePkg.dec",
+            "MdeModulePkg/MdeModulePkg.dec",
+            "NetworkPkg/NetworkPkg.dec"
+        ],
+        # For host based unit tests
+        "AcceptableDependencies-HOST_APPLICATION":[],
+        # For UEFI shell based apps
+        "AcceptableDependencies-UEFI_APPLICATION":[
+            "ShellPkg/ShellPkg.dec"
+        ],
+        "IgnoreInf": []
+    },
+    "DscCompleteCheck": {
+        "DscPath": "RedfishPkg.dsc",
+        "IgnoreInf": []
+    },
+    "GuidCheck": {
+        "IgnoreGuidName": [],
+        "IgnoreGuidValue": [],
+        "IgnoreFoldersAndFiles": []
+    },
+    "LibraryClassCheck": {
+        "IgnoreHeaderFile": []
+    },
+
+    ## options defined ci/Plugin/SpellCheck
+    "SpellCheck": {
+        "AuditOnly": True,           # Fails test but run in AuditOnly mode to collect log
+        "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
+        "ExtendWords": [],           # words to extend to the dictionary for this package
+        "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
+        "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+    },
+
+    "Defines": {
+        "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+    }
+}
diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
new file mode 100644
index 0000000000..e95ec5fe10
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+  DEC_SPECIFICATION = 0x0001001b
+  PACKAGE_NAME      = RedfishPkg
+  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
+  PACKAGE_VERSION   = 1.0
+
+[Guids]
+  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
+
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
new file mode 100644
index 0000000000..d5c65f68c3
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -0,0 +1,40 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
+#
+#    SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  PLATFORM_NAME                  = RedfishPkg
+  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
+  PLATFORM_VERSION               = 1.0
+  DSC_SPECIFICATION              = 0x0001001c
+  OUTPUT_DIRECTORY               = Build/RedfishPkg
+  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
+  BUILD_TARGETS                  = DEBUG|RELEASE
+  SKUID_IDENTIFIER               = DEFAULT
+
+[LibraryClasses]
+  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+  PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
-- 
2.17.1

Re: [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Leif Lindholm]

One comment:

On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote:
> Initial version of RedfishPkg.
> 
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
>  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
>  3 files changed, 125 insertions(+)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc
> 
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> new file mode 100644
> index 0000000000..e95ec5fe10
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -0,0 +1,18 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +
> +[Defines]
> +  DEC_SPECIFICATION = 0x0001001b
> +  PACKAGE_NAME      = RedfishPkg
> +  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
> +  PACKAGE_VERSION   = 1.0
> +
> +[Guids]
> +  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> +
> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> new file mode 100644
> index 0000000000..d5c65f68c3
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dsc
> @@ -0,0 +1,40 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> +#
> +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = RedfishPkg
> +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> +  PLATFORM_VERSION               = 1.0
> +  DSC_SPECIFICATION              = 0x0001001c
> +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> +  BUILD_TARGETS                  = DEBUG|RELEASE

v3 included NOOPT here. That was the version Laszlo gave his R-b for.

v4 cover letter does mention NOOPT being removed, but I can see no
conversation in which this is discussed. What have I missed?

/
    Leif

> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +[LibraryClasses]
> +  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> +  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> +  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> +  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> +  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> +  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> +  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> +  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> +  PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +  PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> +  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> -- 
> 2.17.1
> 

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Abner Chang]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, October 6, 2020 10:37 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>;
> Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
> 
> One comment:
> 
> On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote:
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >  RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> >  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
> >  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
> >  3 files changed, 125 insertions(+)
> >  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > RedfishPkg/RedfishPkg.dec  create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >
> > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new
> > file mode 100644 index 0000000000..e95ec5fe10
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dec
> > @@ -0,0 +1,18 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > +
> > +[Defines]
> > +  DEC_SPECIFICATION = 0x0001001b
> > +  PACKAGE_NAME      = RedfishPkg
> > +  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
> > +  PACKAGE_VERSION   = 1.0
> > +
> > +[Guids]
> > +  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > +
> > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > file mode 100644 index 0000000000..d5c65f68c3
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dsc
> > @@ -0,0 +1,40 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > +#
> > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +##
> > +
> > +[Defines]
> > +  PLATFORM_NAME                  = RedfishPkg
> > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > +  PLATFORM_VERSION               = 1.0
> > +  DSC_SPECIFICATION              = 0x0001001c
> > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > +  BUILD_TARGETS                  = DEBUG|RELEASE
> 
> v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> 
> v4 cover letter does mention NOOPT being removed, but I can see no
> conversation in which this is discussed. What have I missed?
No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.
We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Abner
> 
> /
>     Leif
> 
> > +  SKUID_IDENTIFIER               = DEFAULT
> > +
> > +[LibraryClasses]
> > +
> > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn
> > +tryPoint.inf
> > +
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > +BootServicesTableLib.inf
> > +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > +
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > +b/UefiRuntimeServicesTableLib.inf
> > +  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > +
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> ory
> > +AllocationLib.inf
> > +
> > +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > +
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > +izationLib.inf
> > +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > +  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > +
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > +seDebugPrintErrorLevelLib.inf
> > +
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> rt8
> > +0.inf
> > +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > +
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> e
> > +PeCoffGetEntryPointLib.inf
> > +
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > +leLib.inf
> > +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > +
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> xeRe
> > +portStatusCodeLib.inf
> > --
> > 2.17.1
> >
> 
> 
> 
> 

Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Leif Lindholm]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <
abner.chang@hpe.com> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  =
c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between
Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove
NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back
once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.

/
    Leif

[-- Attachment #2: Type: text/html, Size: 2466 bytes --]

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 2504 bytes --]

Yeah, I will send another version for this.
Thanks
Abner

Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Leif Lindholm <leif@nuviainc.com>
Sent: Wednesday, October 7, 2020 12:29:28 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.

/
    Leif

[-- Attachment #2: Type: text/html, Size: 4248 bytes --]

Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Laszlo Ersek]

On 10/06/20 18:29, Leif Lindholm wrote:
> Hi Abner,
> 
> On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <
> abner.chang@hpe.com> wrote:
>>>> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
>>>> file mode 100644 index 0000000000..d5c65f68c3
>>>> --- /dev/null
>>>> +++ b/RedfishPkg/RedfishPkg.dsc
>>>> @@ -0,0 +1,40 @@
>>>> +## @file
>>>> +# Redfish Package
>>>> +#
>>>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
>>>> +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
>>>> +#
>>>> +#    SPDX-License-Identifier: BSD-2-Clause-Patent
>>>> +#
>>>> +##
>>>> +
>>>> +[Defines]
>>>> +  PLATFORM_NAME                  = RedfishPkg
>>>> +  PLATFORM_GUID                  =
> c4352870-5232-11e7-9522-005056c00008
>>>> +  PLATFORM_VERSION               = 1.0
>>>> +  DSC_SPECIFICATION              = 0x0001001c
>>>> +  OUTPUT_DIRECTORY               = Build/RedfishPkg
>>>> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
>>>> +  BUILD_TARGETS                  = DEBUG|RELEASE
>>>
>>> v3 included NOOPT here. That was the version Laszlo gave his R-b for.
>>>
>>> v4 cover letter does mention NOOPT being removed, but I can see no
>>> conversation in which this is discussed. What have I missed?
>>
>> No Leif, you did miss nothing. There was some Q/A conversations between
> Bret and me about the build target of CI.
> 
> This should really be referenced in the cover letter.
> 
>> We would like to keep NO-TARGET for the non-build CI test but remove
> NOOPT for now because we do not have
>> the host-based unit test at the moment. We would like to add NOOPT back
> once we have the corresponding unit test on RedfishPkg.
> 
> Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
> And it's not clear to me that Laszlo noticed this change.

I missed it.

The v4 blurb said, "Note for v4: NOOPT is removed from RedfishPkg.dsc
[...]", and then I wrote in my v4 patch#1 response, "According to the v4
blurb, this patch has not undergone any changes since v3".

So I clearly missed the actual meaning of the blurb. Sorry about that. I
guess I'm more used to patch-granularity changelogs.

Also I believe I didn't expect this series to reach v5, so I didn't do
my usual thing where I apply every version of a patch set separately on
a local topic branch, and then do incremental reviews with git-range-diff.

So it's my fault. A better (patch-granularity) changelog might have
mitigated my mistake, perhaps.

(BTW I've not been CC'd on any version of the blurb.)

Thanks
Laszlo

Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]



From: Leif Lindholm [mailto:leif@nuviainc.com]
Sent: Wednesday, October 7, 2020 12:29 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.
Oops!!!! My fault! Thanks for catching this.

/
    Leif

[-- Attachment #2: Type: text/html, Size: 6628 bytes --]

[RedfishPkg PATCH v5 2/4] .pytool: Add CI on RedfishPkg

[Abner Chang]

Add RedfishPkg to CI test.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .pytool/CISettings.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 0c2dd0181a..b337d046ae 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -55,7 +55,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
                 "FatPkg",
                 "CryptoPkg",
                 "UnitTestFrameworkPkg",
-                "OvmfPkg"
+                "OvmfPkg",
+                "RedfishPkg"
                 )
 
     def GetArchitecturesSupported(self):
-- 
2.17.1

Re: [edk2-devel] [RedfishPkg PATCH v5 2/4] .pytool: Add CI on RedfishPkg

[Laszlo Ersek]

On 10/06/20 12:48, Abner Chang wrote:
> Add RedfishPkg to CI test.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
>  .pytool/CISettings.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index 0c2dd0181a..b337d046ae 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -55,7 +55,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
>                  "FatPkg",
>                  "CryptoPkg",
>                  "UnitTestFrameworkPkg",
> -                "OvmfPkg"
> +                "OvmfPkg",
> +                "RedfishPkg"
>                  )
>  
>      def GetArchitecturesSupported(self):
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

[RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
-- 
2.17.1

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Sean]

On this change i would recommend that you add RedFishPkg to another in 
the list as i don't think the time it takes to compile and test this 
relatively small package makes it worth spinning up another machine, 
syncing sources, installing tools, etc.

Looking at the current matrix it looks like the SecurityPkg only takes 8 
minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is 
faster than the slowest entry.  We generally try to load balance this so 
that CI completes quickly.

vs2019
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=12811&view=results

gcc
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=12810&view=results


Thanks
Sean



On 10/6/2020 3:48 AM, Abner Chang wrote:
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..b5b09c2cca 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -45,6 +45,9 @@ jobs:
>         TARGET_SECURITY:
>           Build.Pkgs: 'SecurityPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_REDFISH:
> +        Build.Pkgs: 'RedfishPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>         TARGET_PLATFORMS:
>           # For Platforms only check code. Leave it to Platform CI
>           # to build them.
> 

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

> -----Original Message-----
> From: Sean Brogan [mailto:spbrogan@outlook.com]
> Sent: Wednesday, October 7, 2020 7:05 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> On this change i would recommend that you add RedFishPkg to another in
> the list as i don't think the time it takes to compile and test this relatively
> small package makes it worth spinning up another machine, syncing sources,
> installing tools, etc.

Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
This is the initial commit of RedFishPkg, more drivers will added to this package later on.
https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.


> 
> Looking at the current matrix it looks like the SecurityPkg only takes 8
> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
> than the slowest entry.  We generally try to load balance this so that CI
> completes quickly.
> 
> vs2019
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12811-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> 2a23G5fMyOkEFrZgBz5M&e=
> 
> gcc
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12810-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> XbXB9yt4&e=
> 
> 
> Thanks
> Sean
> 
> 
> 
> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >         TARGET_SECURITY:
> >           Build.Pkgs: 'SecurityPkg'
> >           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >         TARGET_PLATFORMS:
> >           # For Platforms only check code. Leave it to Platform CI
> >           # to build them.
> >

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Sean]

I am just suggesting that for CI you should put redfishpkg into an 
existing matrix item rather than create a new matrix item.  Each one of 
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml 
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might 
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> 
> 
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
> 
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md
> 
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> 
> 
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>

Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 5820 bytes --]

Ah, yes. Good catch. Agree with Sean.

- Bret

From: Sean Brogan<mailto:spbrogan@outlook.com>
Sent: Tuesday, October 6, 2020 4:45 PM
To: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)<mailto:nickle.wang@hpe.com>
Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

I am just suggesting that for CI you should put redfishpkg into an
existing matrix item rather than create a new matrix item.  Each one of
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
>
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0
>
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.
>
>
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>


[-- Attachment #2: Type: text/html, Size: 10337 bytes --]

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 7259 bytes --]

Ok, v6 sent. Should be the perfect one, I hope so.

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Wednesday, October 7, 2020 8:01 AM
To: Sean Brogan <spbrogan@outlook.com>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
Subject: Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Ah, yes. Good catch. Agree with Sean.

- Bret

From: Sean Brogan<mailto:spbrogan@outlook.com>
Sent: Tuesday, October 6, 2020 4:45 PM
To: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)<mailto:nickle.wang@hpe.com>
Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

I am just suggesting that for CI you should put redfishpkg into an
existing matrix item rather than create a new matrix item.  Each one of
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>; Michael D Kinney
>> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
>
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0>
>
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don't add RedfishPkg to GetPackageSupported for now.
>
>
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
>>> Cc: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>



[-- Attachment #2: Type: text/html, Size: 12888 bytes --]

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sean
> Sent: Wednesday, October 7, 2020 7:46 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> I am just suggesting that for CI you should put redfishpkg into an existing
> matrix item rather than create a new matrix item.  Each one of those is a
> build that spins up when CI/PR is invoked.
> 
> 
> instead of this (your patch)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..b5b09c2cca 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -45,6 +45,9 @@ jobs:
>          TARGET_SECURITY:
>            Build.Pkgs: 'SecurityPkg'
>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_REDFISH:
> +        Build.Pkgs: 'RedfishPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>          TARGET_PLATFORMS:
>            # For Platforms only check code. Leave it to Platform CI
>            # to build them.
> 
> I would just do something like below.  (i hand edited the diff so might not be
> perfect but hopefully you get the idea).
> 
> 
> @@ -45,6 +45,9 @@ jobs:
> -        TARGET_SECURITY:
> +        TARGET_SECURITY_REDFISH:
> -          Build.Pkgs: 'SecurityPkg'
> +          Build.Pkgs: 'SecurityPkg,RedfishPkg'
>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> 
> 
Got you. I will put it with NetworkPkg, more like a family. :)
Thanks

> 
> Thanks
> Sean
> 
> 
> On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> >
> >
> >> -----Original Message-----
> >> From: Sean Brogan [mailto:spbrogan@outlook.com]
> >> Sent: Wednesday, October 7, 2020 7:05 AM
> >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> >> <abner.chang@hpe.com>
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> >> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> >> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> >> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> >>
> >> On this change i would recommend that you add RedFishPkg to another in
> >> the list as i don't think the time it takes to compile and test this relatively
> >> small package makes it worth spinning up another machine, syncing
> sources,
> >> installing tools, etc.
> >
> > Sean, do you mean to add RedFishPkg to another package? Or move
> drivers (currently is none) under RedFishPkg to another package?
> > This is the initial commit of RedFishPkg, more drivers will added to this
> package later on.
> > https://github.com/tianocore/edk2-
> staging/blob/UEFI_Redfish/Readme.md
> >
> > That doesn't make sense to put RedFishPkg to any of another to save CI
> time, but what we can do now is remove RedFishPkg from CI test for the
> time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> >
> >
> >>
> >> Looking at the current matrix it looks like the SecurityPkg only takes 8
> >> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is
> faster
> >> than the slowest entry.  We generally try to load balance this so that CI
> >> completes quickly.
> >>
> >> vs2019
> >> INVALID URI REMOVED
> >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> >> 3D12811-26view-
> >>
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> >> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> >> 2a23G5fMyOkEFrZgBz5M&e=
> >>
> >> gcc
> >> INVALID URI REMOVED
> >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> >> 3D12810-26view-
> >>
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> >>
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> >> XbXB9yt4&e=
> >>
> >>
> >> Thanks
> >> Sean
> >>
> >>
> >>
> >> On 10/6/2020 3:48 AM, Abner Chang wrote:
> >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>> Cc: Nickle Wang <nickle.wang@hpe.com>
> >>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>> ---
> >>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >>>    1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> >>> b/.azurepipelines/templates/pr-gate-build-job.yml
> >>> index 2683687a1c..b5b09c2cca 100644
> >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> >>> @@ -45,6 +45,9 @@ jobs:
> >>>          TARGET_SECURITY:
> >>>            Build.Pkgs: 'SecurityPkg'
> >>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >>> +      TARGET_REDFISH:
> >>> +        Build.Pkgs: 'RedfishPkg'
> >>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >>>          TARGET_PLATFORMS:
> >>>            # For Platforms only check code. Leave it to Platform CI
> >>>            # to build them.
> >>>
> 
> 
> 
> 

Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 8:02 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Sean
> > Sent: Wednesday, October 7, 2020 7:46 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > I am just suggesting that for CI you should put redfishpkg into an
> > existing matrix item rather than create a new matrix item.  Each one
> > of those is a build that spins up when CI/PR is invoked.
> >
> >
> > instead of this (your patch)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >          TARGET_SECURITY:
> >            Build.Pkgs: 'SecurityPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >          TARGET_PLATFORMS:
> >            # For Platforms only check code. Leave it to Platform CI
> >            # to build them.
> >
> > I would just do something like below.  (i hand edited the diff so
> > might not be perfect but hopefully you get the idea).
> >
> >
> > @@ -45,6 +45,9 @@ jobs:
> > -        TARGET_SECURITY:
> > +        TARGET_SECURITY_REDFISH:
> > -          Build.Pkgs: 'SecurityPkg'
> > +          Build.Pkgs: 'SecurityPkg,RedfishPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >
> >
> Got you. I will put it with NetworkPkg, more like a family. :) Thanks
Not quite sure how this yaml file works with CI test.
Does it mean RedfishPkg is involved in NetworkPkg CI test? Even CI only runs on TARGET_NETWORK?
But eventually RedfishPkg would be moved out from TARGET_NETWORK once it grows up to big enough, right?

> 
> >
> > Thanks
> > Sean
> >
> >
> > On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Sean Brogan [mailto:spbrogan@outlook.com]
> > >> Sent: Wednesday, October 7, 2020 7:05 AM
> > >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > >> <abner.chang@hpe.com>
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > >> <michael.d.kinney@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > >> <nickle.wang@hpe.com>
> > >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > >> .azurepipelines/templates: Add RedfishPkg to target build
> > >>
> > >> On this change i would recommend that you add RedFishPkg to another
> > >> in the list as i don't think the time it takes to compile and test
> > >> this relatively small package makes it worth spinning up another
> > >> machine, syncing
> > sources,
> > >> installing tools, etc.
> > >
> > > Sean, do you mean to add RedFishPkg to another package? Or move
> > drivers (currently is none) under RedFishPkg to another package?
> > > This is the initial commit of RedFishPkg, more drivers will added to
> > > this
> > package later on.
> > > https://github.com/tianocore/edk2-
> > staging/blob/UEFI_Redfish/Readme.md
> > >
> > > That doesn't make sense to put RedFishPkg to any of another to save
> > > CI
> > time, but what we can do now is remove RedFishPkg from CI test for the
> > time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> > >
> > >
> > >>
> > >> Looking at the current matrix it looks like the SecurityPkg only
> > >> takes 8 minutes and CRYPTO only takes ~9 minutes.  I also see FMP
> > >> and FAT is
> > faster
> > >> than the slowest entry.  We generally try to load balance this so
> > >> that CI completes quickly.
> > >>
> > >> vs2019
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12811-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> > >> 2a23G5fMyOkEFrZgBz5M&e=
> > >>
> > >> gcc
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12810-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >>
> >
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> > >> XbXB9yt4&e=
> > >>
> > >>
> > >> Thanks
> > >> Sean
> > >>
> > >>
> > >>
> > >> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >>> Cc: Nickle Wang <nickle.wang@hpe.com>
> > >>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> ---
> > >>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >>>    1 file changed, 3 insertions(+)
> > >>>
> > >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> index 2683687a1c..b5b09c2cca 100644
> > >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> @@ -45,6 +45,9 @@ jobs:
> > >>>          TARGET_SECURITY:
> > >>>            Build.Pkgs: 'SecurityPkg'
> > >>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>> +      TARGET_REDFISH:
> > >>> +        Build.Pkgs: 'RedfishPkg'
> > >>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>>          TARGET_PLATFORMS:
> > >>>            # For Platforms only check code. Leave it to Platform CI
> > >>>            # to build them.
> > >>>
> >
> >
> > 
> >

[RedfishPkg PATCH v5 4/4] edk2: Add maintainers to RedfishPkg

[Abner Chang]

Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 Maintainers.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 6a22a14796..cabadac177 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -503,6 +503,11 @@ F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
+RedfishPkg: Redfish related modules
+F: RedfishPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
 SecurityPkg
 F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
-- 
2.17.1

Re: [edk2-devel] [RedfishPkg PATCH v5 4/4] edk2: Add maintainers to RedfishPkg

[Leif Lindholm]

On Tue, Oct 06, 2020 at 18:48:04 +0800, Abner Chang wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>

No objection to this one.
Acked-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Maintainers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cabadac177 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,11 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> -- 
> 2.17.1
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg

[Laszlo Ersek]

On 10/06/20 12:48, Abner Chang wrote:
> Note for v5: Add reviewers's tags.
> 
> Initial version of RedfishPkg and the CI test
> on RedfishPkg.
> 
> CI Test result:
> https://github.com/tianocore/edk2/pull/982
> 
> There is no components in RedfishPkg in this commit,
> the further edk2 Redfish components will be committed
> base on this version.
> 
> Abner Chang (4):
>   RedfishPkg: Initial commit of RedfishPkg.
>   .pytool: Add CI on RedfishPkg
>   .azurepipelines/templates: Add RedfishPkg to target build
>   edk2: Add maintainers to RedfishPkg
> 
>  .../templates/pr-gate-build-job.yml           |  3 +
>  .pytool/CISettings.py                         |  3 +-
>  Maintainers.txt                               |  5 ++
>  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec                     | 18 +++++
>  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
>  6 files changed, 135 insertions(+), 1 deletion(-)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc
> 

Andrew, Leif, Mike: please check patches #1 and #4.

I'd like to have at least one other ACK on those, and then (I think)
Abner can merge the series himself.

Thanks
Laszlo