public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Cc: jaben.carsey@intel.com, edk2-devel@ml01.01.org, ruiyu.ni@intel.com
Subject: Re: [PATCH] GPT Shell Application/Library
Date: Sun, 16 Oct 2016 22:05:26 +0200	[thread overview]
Message-ID: <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> (raw)
In-Reply-To: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com>

On 10/16/16 07:23, Vladimir Olovyannikov wrote:
> This allows managing (create, delete, modify, fat format) of GPT
> partitions from within UEFI Shell.
> Syntax:
> gpt <command> [device_mapped_name] [parameters...]
> See usage examples in the .uni file
> ---
>  .../Library/UefiShellGptCommandLib/FatFormat.c     |  611 +++++++
>  .../Library/UefiShellGptCommandLib/FatFormat.h     |  111 ++
>  .../Library/UefiShellGptCommandLib/GptWorker.c     | 1902 ++++++++++++++++++++
>  .../Library/UefiShellGptCommandLib/GptWorker.h     |  186 ++
>  .../UefiShellGptCommandLib.c                       | 1135 ++++++++++++
>  .../UefiShellGptCommandLib.inf                     |   79 +
>  .../UefiShellGptCommandLib.uni                     |  117 ++
>  ShellPkg/ShellPkg.dec                              |    1 +
>  ShellPkg/ShellPkg.dsc                              |    4 +
>  9 files changed, 4146 insertions(+)
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.c
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.h
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.c
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.h
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.c
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.inf
>  create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.uni

This looks like a supremely welcome, long-awaited addition (latest
request:
<https://lists.01.org/pipermail/edk2-devel/2016-October/002667.html>),
but it really needs your Signed-off-by, and the Contributed-under line
above it:

ShellPkg/Contributions.txt

I would also suggest (simply based on what I've seen elsewhere in edk2)
to keep the copyright notices tightly collected in the file headings.

Someone will have to go over all the licenses too -- does the "Marvell
BSD License Option" for example correspond to the 3-clause BSDL?

On the technical side, I believe that as long as a shell command (or a
command option) is not standardized (in the shell spec), it usually
starts with an underscore (_), so as to prevent future name collisions.
(I could be wrong about this -- I now recall the TFTP command, which is
also not in the 2.2 spec.)

Just my two cents.

Thanks
Laszlo


  reply	other threads:[~2016-10-16 20:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16  5:23 [PATCH] GPT Shell Application/Library Vladimir Olovyannikov
2016-10-16 20:05 ` Laszlo Ersek [this message]
     [not found]   ` <CACmgjazi_K4Qo5=TeO_tCGK2cB26d0rqOEZh6TthP1UYbo6J6w@mail.gmail.com>
     [not found]     ` <CACmgjaziUEF2EsSn73HY5JvL2rmRWrXS+rHMtOQ1HaRwPpXS+g@mail.gmail.com>
2016-10-17  6:49       ` Vladimir Olovyannikov
2016-10-17  7:24         ` Michael Zimmermann
2016-10-17 17:52           ` Vladimir Olovyannikov
2016-10-17 17:56             ` Carsey, Jaben
2016-10-18 13:59               ` Shah, Tapan
2016-10-18 16:58                 ` Vladimir Olovyannikov
2016-10-18 17:04                   ` Carsey, Jaben
2016-10-18 18:03                     ` Shah, Tapan
2016-10-18 19:09                       ` Vladimir Olovyannikov
2016-10-18 17:23                   ` Laszlo Ersek
2016-10-18 18:03                     ` Vladimir Olovyannikov
2016-10-18 18:12                       ` Laszlo Ersek
2016-10-17  9:43         ` Laszlo Ersek
2016-10-17 16:35           ` Carsey, Jaben
2016-10-18  1:45 ` Ni, Ruiyu
2016-10-18  1:48   ` Tim Lewis
2016-10-18  1:55     ` Ni, Ruiyu
2016-10-18  2:59       ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox