From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D26061A1E3A for ; Sun, 16 Oct 2016 13:05:29 -0700 (PDT) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 323A4C049D5B; Sun, 16 Oct 2016 20:05:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-42.phx2.redhat.com [10.3.116.42]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9GK5RfE007257; Sun, 16 Oct 2016 16:05:28 -0400 To: Vladimir Olovyannikov References: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> Cc: jaben.carsey@intel.com, edk2-devel@ml01.01.org, ruiyu.ni@intel.com From: Laszlo Ersek Message-ID: <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> Date: Sun, 16 Oct 2016 22:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 16 Oct 2016 20:05:29 +0000 (UTC) Subject: Re: [PATCH] GPT Shell Application/Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2016 20:05:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 10/16/16 07:23, Vladimir Olovyannikov wrote: > This allows managing (create, delete, modify, fat format) of GPT > partitions from within UEFI Shell. > Syntax: > gpt [device_mapped_name] [parameters...] > See usage examples in the .uni file > --- > .../Library/UefiShellGptCommandLib/FatFormat.c | 611 +++++++ > .../Library/UefiShellGptCommandLib/FatFormat.h | 111 ++ > .../Library/UefiShellGptCommandLib/GptWorker.c | 1902 ++++++++++++++++++++ > .../Library/UefiShellGptCommandLib/GptWorker.h | 186 ++ > .../UefiShellGptCommandLib.c | 1135 ++++++++++++ > .../UefiShellGptCommandLib.inf | 79 + > .../UefiShellGptCommandLib.uni | 117 ++ > ShellPkg/ShellPkg.dec | 1 + > ShellPkg/ShellPkg.dsc | 4 + > 9 files changed, 4146 insertions(+) > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.c > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.h > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.c > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.h > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.c > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.inf > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.uni This looks like a supremely welcome, long-awaited addition (latest request: ), but it really needs your Signed-off-by, and the Contributed-under line above it: ShellPkg/Contributions.txt I would also suggest (simply based on what I've seen elsewhere in edk2) to keep the copyright notices tightly collected in the file headings. Someone will have to go over all the licenses too -- does the "Marvell BSD License Option" for example correspond to the 3-clause BSDL? On the technical side, I believe that as long as a shell command (or a command option) is not standardized (in the shell spec), it usually starts with an underscore (_), so as to prevent future name collisions. (I could be wrong about this -- I now recall the TFTP command, which is also not in the 2.2 spec.) Just my two cents. Thanks Laszlo