Re: [PATCH v4 0/6] read-only UDF file system support

[Paulo Alcantara <pcacjr@zytor.com>]

Laszlo,

On 07/09/2017 08:35, Laszlo Ersek wrote:
> Paulo,
> 
> On 09/07/17 02:23, Ni, Ruiyu wrote:
>> Sure. Please.
> 
> Before pushing the series, I wanted to slightly regression-test OVMF and
> ArmVirtQemu with it.
> 
> However, I've found that the series doesn't build for OVMF IA32. I get
> an error like this:
> 
>> MdeModulePkg/Universal/Disk/UdfDxe/File.c: In function 'UdfRead':
>> MdeModulePkg/Universal/Disk/UdfDxe/File.c:376:7: error: passing argument 8 of 'ReadFileData' from incompatible pointer type [-Werror]
>>         );
>>         ^
>> In file included from MdeModulePkg/Universal/Disk/UdfDxe/File.c:15:0:
>> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h:1008:1: note: expected 'UINT64 *' but argument is of type 'UINTN *'
>>   ReadFileData (
> 
> There could be further such errors (I didn't check, the build stopped
> here).
> 
> Can you please submit a v5 that is 32-bit and 64-bit clean?

Sure. Thanks for catching that up. I'll also make sure to re-test it 
after the changes.

> 
> I expect that any changes you make will be in the first three patches
> somewhere. If they are not trivial, please drop Ray's Reviewed-by from
> the affected patches so he can review them again.
> 
> I'm not sure if Ray uses any tools for supporting incremental review;
> you could help him by including a cumulative diff between v4 and v5 in
> the v5 blurb.

OK.

Paulo