From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pcacjr@zytor.com>
Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 56B2321CEB0FD
 for <edk2-devel@lists.01.org>; Thu,  7 Sep 2017 07:07:22 -0700 (PDT)
Received: from [IPv6:2804:7f4:c480:9cd0::2] ([IPv6:2804:7f4:c480:9cd0:0:0:0:2])
 (authenticated bits=0)
 by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v87E7nCC014486
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Thu, 7 Sep 2017 07:07:52 -0700
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>,
 "Dong, Eric" <eric.dong@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
 "Justen, Jordan L" <jordan.l.justen@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Andrew Fish <afish@apple.com>, "Gao, Liming" <liming.gao@intel.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
References: <cover.1503597107.git.pcacjr@zytor.com>
 <9d28a05c-21de-1d7f-65f2-56c82811973e@redhat.com>
 <734D49CCEBEEF84792F5B80ED585239D5BA26BF3@SHSMSX104.ccr.corp.intel.com>
 <560b0e20-9164-20f2-8cb5-bed753a820db@redhat.com>
From: Paulo Alcantara <pcacjr@zytor.com>
Message-ID: <40d2e3a8-cca1-f0d8-a4f4-e6e11816f7e8@zytor.com>
Date: Thu, 7 Sep 2017 11:07:48 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <560b0e20-9164-20f2-8cb5-bed753a820db@redhat.com>
Subject: Re: [PATCH v4 0/6] read-only UDF file system support
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2017 14:07:22 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Laszlo,

On 07/09/2017 08:35, Laszlo Ersek wrote:
> Paulo,
> 
> On 09/07/17 02:23, Ni, Ruiyu wrote:
>> Sure. Please.
> 
> Before pushing the series, I wanted to slightly regression-test OVMF and
> ArmVirtQemu with it.
> 
> However, I've found that the series doesn't build for OVMF IA32. I get
> an error like this:
> 
>> MdeModulePkg/Universal/Disk/UdfDxe/File.c: In function 'UdfRead':
>> MdeModulePkg/Universal/Disk/UdfDxe/File.c:376:7: error: passing argument 8 of 'ReadFileData' from incompatible pointer type [-Werror]
>>         );
>>         ^
>> In file included from MdeModulePkg/Universal/Disk/UdfDxe/File.c:15:0:
>> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h:1008:1: note: expected 'UINT64 *' but argument is of type 'UINTN *'
>>   ReadFileData (
> 
> There could be further such errors (I didn't check, the build stopped
> here).
> 
> Can you please submit a v5 that is 32-bit and 64-bit clean?

Sure. Thanks for catching that up. I'll also make sure to re-test it 
after the changes.

> 
> I expect that any changes you make will be in the first three patches
> somewhere. If they are not trivial, please drop Ray's Reviewed-by from
> the affected patches so he can review them again.
> 
> I'm not sure if Ray uses any tools for supporting incremental review;
> you could help him by including a cumulative diff between v4 and v5 in
> the v5 blurb.

OK.

Paulo