From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by mx.groups.io with SMTP id smtpd.web09.4414.1603333286142548749 for ; Wed, 21 Oct 2020 19:21:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ImJz/uAC; spf=pass (domain: nuviainc.com, ip: 209.85.216.67, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f67.google.com with SMTP id b6so155649pju.1 for ; Wed, 21 Oct 2020 19:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=nADkLhNT2KTRgpKZTlgkfS0nfJJj/ssJ5fhKTsLjBWg=; b=ImJz/uACZUm8P9PRAYWKFGFbSQ2lZy4f2Fy2BVl+3utLX7/4lAt+qsQ5upPAXBFiWE sA1x7xq2DnYaxIiM0DvbFHN1GOMfEn0rtmg22V74J/o3Edi1ha2FBRUNK1ujFxVzqQqu UlkCN8zcXuhpzsoDxOOKgXZ2CtHJwa+dPkZM9f5IFzxi/PHTg51JuUtA7GpIWl6zLIpM F3c+jA5CD0NK8zPldLkoYHkBLXnXpMgCi/Vp95RqkIHkZRSG5q4VNEYJRxxoV3JnFA1A T8vWpd98vhXn1g0s+0xHU/NbaNZn1Z95b7fb4XRzGFehhZrBTywP/ghASLGfWOWfko9e bxCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=nADkLhNT2KTRgpKZTlgkfS0nfJJj/ssJ5fhKTsLjBWg=; b=Oa4hwTgJUVk97X39R7DnKfl1HJKN9bIpoElcbJJ14t/yyGFTyCN8Fm3LkqivT55nKj LSwi7TBiTui/EbNI7SZkrograZsYqkFHWfW6IeaqWHe1ibd61mn48sHpm5dOpHWLUjQp 3X6O7fmv95kC1vKubZZLXv+RTNv0Tz1EOioGI7Ckw8MF+J3WuHVlrUkZCgpSil1iNKgq DJsp7Q216SmLii6vNtwAm8lJ7ujBdRJCCZvHh/HMJEVlFw0nuKA1RarYeX5d2ps7p+4V 5lfDvSYTk4UE0K5p3oea1zJjuJ1NMQHcKjBmboL/g6cD0FOCfcZwDRpZY2Agbii++U/a 67Vw== X-Gm-Message-State: AOAM530AhfEcKpUsSmd3WTQ7FdU2LWhtK/0n7Loyd5oMOye3P1diHfF7 BDY45mDfqHDEM7Pf2BYQoDVVTw== X-Google-Smtp-Source: ABdhPJxE0eWM4FoBhBBoaBngDQpnEAlhP1H2O784mBfnbCNPvWbccTsbhmYIj2b0IR/hn1thXjf6Kg== X-Received: by 2002:a17:902:968a:b029:d5:a3a0:3c43 with SMTP id n10-20020a170902968ab02900d5a3a03c43mr330783plp.70.1603333285594; Wed, 21 Oct 2020 19:21:25 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id j11sm66980pfe.80.2020.10.21.19.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2020 19:21:25 -0700 (PDT) Subject: =?UTF-8?B?UmU6IFtFWFRFUk5BTF0gW2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIDAvNl0gc21iaW9zdmlldyBhbmQgU21CaW9zLmggZml4ZXMsIGFkZCBTTUJJT1MgMy40LjAgQVJNNjQgU29DIElEIGRlZmluaXRpb24=?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: 'Michael D Kinney' , 'Zhiguang Liu' , 'Ray Ni' , 'Zhichao Gao' References: <20201021184115.25712-1-rebecca@nuviainc.com> <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> From: "Rebecca Cran" Message-ID: <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com> Date: Wed, 21 Oct 2020 20:21:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/21/20 7:46 PM, gaoliming wrote: > They are the good change. But for patch 4/6, it changes the structure > field name. It may bring the impact to the platform code. I don't suggest to > do the renaming field only for typo purpose. Other changes are good to me. From looking at the code in edk2-platforms, it seems the common pattern is to use positional arguments instead of designated initializers. Of course there could be platforms outside of TianoCore which use the field names, but it looks like a relatively safe change. -- Rebecca Cran