From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, richardho@ami.com
Cc: "Andrew Fish" <afish@apple.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Michael Kubacki" <michael.kubacki@microsoft.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Tony Lo (羅金松)" <TonyLo@ami.com>
Subject: Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
Date: Wed, 15 Feb 2023 08:13:03 -0700 [thread overview]
Message-ID: <40f04734-1178-bc8d-cee5-5e6f829b8306@bsdio.com> (raw)
In-Reply-To: <20230215053622.3746-1-richardho@ami.com>
On 2/14/23 22:36, RichardHo [何明忠] via groups.io wrote:
> diff --git a/UsbNetworkPkg/UsbNetworkPkg.dec b/UsbNetworkPkg/UsbNetworkPkg.dec
> new file mode 100644
> index 0000000000..4506be6cf9
> --- /dev/null
> +++ b/UsbNetworkPkg/UsbNetworkPkg.dec
> @@ -0,0 +1,46 @@
> +## @file
> +# This package defines Usb network specific interfaces and library classes
> +# as well as configuration for standard edk2 packages.
> +#
> +# Copyright (c) 2023, American Megatrends International LLC. All rights reserved.<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +
> +[Defines]
> + DEC_SPECIFICATION = 0x00010005
> + PACKAGE_NAME = UsbNetworkPkg
> + PACKAGE_GUID = abfab91e-37ea-4cb4-80a6-563dbb0bcec6
> + PACKAGE_VERSION = 0.1
> +
> +[Includes]
> + Include
> +
> +[Protocols]
> + ## Include/Protocol/EdkIIUsbEthernet.h
> + gEdkIIUsbEthProtocolGuid = { 0x8d8969cc, 0xfeb0, 0x4303, { 0xb2, 0x1a, 0x1f, 0x11, 0x6f, 0x38, 0x56, 0x43 } }
> +
> +[Guids]
> + ## Usb Network package token space GUID
> + gUsbNetworkPkgTokenSpaceGuid = { 0xA1231E82, 0x21B8, 0x4204, { 0x92, 0xBB, 0x37, 0x3A, 0xFB, 0x01, 0xC6, 0xA1 } }
> +
> +[PcdsFeatureFlag]
> +
> + ## Set the PCD 'UsbCdcEcmSupport' to 'TRUE' if 'Usb Cdc Ecm device' need to be enabled.
> + gUsbNetworkPkgTokenSpaceGuid.UsbCdcEcmSupport|FALSE|BOOLEAN|0x00000001
> +
> + ## Set the PCD 'UsbCdcNcmSupport' to 'TRUE' if 'Usb Cdc Ncm device' need to be enabled.
> + gUsbNetworkPkgTokenSpaceGuid.UsbCdcNcmSupport|FALSE|BOOLEAN|0x00000002
> +
> + ## Set the PCD 'UsbRndisSupport' to 'TRUE' if 'Usb Rndis device' need to be enabled.
> + gUsbNetworkPkgTokenSpaceGuid.UsbRndisSupport|TRUE|BOOLEAN|0x00000003
> +
> +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> + ## Support rate limiting
> + gUsbNetworkPkgTokenSpaceGuid.EnableRateLimiting|FALSE|BOOLEAN|0x00010001
> +
> + ## The rate limiting Credit value is check in rate limiter event.
> + # It is to control the RateLimitingCreditCount max value.
> + gUsbNetworkPkgTokenSpaceGuid.RateLimitingCredit|10|UINT32|0x00010002
> +
Is that valid to have all those PCD types in a single section?
--
Rebecca Cran
next prev parent reply other threads:[~2023-02-15 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 5:36 [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support RichardHo [何明忠]
2023-02-15 5:36 ` [PATCH v3 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM " RichardHo [何明忠]
2023-02-15 5:36 ` [PATCH v3 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM " RichardHo [何明忠]
2023-02-15 5:47 ` [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS " Tony Lo (羅金松)
2023-02-15 17:28 ` [edk2-devel] " Rebecca Cran
2023-02-16 7:06 ` RichardHo [何明忠]
2023-02-15 10:23 ` Michael Brown
2023-02-16 2:21 ` RichardHo [何明忠]
2023-02-15 15:13 ` Rebecca Cran [this message]
2023-02-16 11:52 ` Tinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f04734-1178-bc8d-cee5-5e6f829b8306@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox