From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web10.17474.1676473988388239171 for ; Wed, 15 Feb 2023 07:13:08 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=fdEhi3eQ; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9D3AC5C012C; Wed, 15 Feb 2023 10:13:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 15 Feb 2023 10:13:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1676473987; x= 1676560387; bh=/1Og1CQhxYEA2DZOxuCoi+eIllhUkCT2PQpLwApQc8Y=; b=f dEhi3eQ2kdyZnKFS7bH5LLok1q2vzE29KaJTtIkOcdESy4YA86twF+OYk8Dl0lT/ ksgj12K5+j48JscokhTntBvHUVjJWB1ndZktFdSb0kCqcRPTtD7F2NB6V6vg3iwa UUsun/CvgEuefv+EDJ8B2xNwo5yCJqsZW7gdzEE/Lz2P4ZaPkcZFi9xmre9Z/v7n b298qIWuXKmuJiW7WVHqVWEFZNpGc1AldoO/xFLQeNrB+JICxYV8f+JPhS4Yjah7 iiDwruuZtHuvgrTphp+FiFYVO2mUg6Vsy7wScPZ5Af5BdkwtbTq9FpUVNm6BZHvo qqF1P8EBofXKcRdnOWHlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676473987; x= 1676560387; bh=/1Og1CQhxYEA2DZOxuCoi+eIllhUkCT2PQpLwApQc8Y=; b=i CshqeiKhbCGB9oswZFQOBLMSXhGHlubbIJ8CxD2fce4h18Lgs5xHHWNwD9ouXONL u4WNtv0a9qJ2s8d6Sfg8KfenqjpGPRGBFRhcbtoM7ZDgMFRXsJujdOrcj937YDFJ EDI0L7Mj0gAEQoZmNoMrkRa/1unIuu95L4SWM3389G4v2hTnaqy/DY4GZNJl7TT5 Ck0SqYwGmPPluwJJ8HOfU/f4sEjePmaDcoimqHiX5zzE9NrWmi27tArafV+/HKu0 I+Ojza5eXHMPXGYtgbS6Mz/WC1GT3c8Sk47GMJFDVriDYUPdH2fR0vsJn3E5iRO9 caLkGljrIXOvMGOkoCveg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeihedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegfeegveduheejgfduffefhfehleehiefghfetvdejvdelhfeukefhhfdv geehveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Feb 2023 10:13:04 -0500 (EST) Message-ID: <40f04734-1178-bc8d-cee5-5e6f829b8306@bsdio.com> Date: Wed, 15 Feb 2023 08:13:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support To: devel@edk2.groups.io, richardho@ami.com Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , =?UTF-8?B?VG9ueSBMbyAo576F6YeR5p2+KQ==?= References: <20230215053622.3746-1-richardho@ami.com> From: "Rebecca Cran" In-Reply-To: <20230215053622.3746-1-richardho@ami.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/14/23 22:36, RichardHo [何明忠] via groups.io wrote: > diff --git a/UsbNetworkPkg/UsbNetworkPkg.dec b/UsbNetworkPkg/UsbNetworkPkg.dec > new file mode 100644 > index 0000000000..4506be6cf9 > --- /dev/null > +++ b/UsbNetworkPkg/UsbNetworkPkg.dec > @@ -0,0 +1,46 @@ > +## @file > +# This package defines Usb network specific interfaces and library classes > +# as well as configuration for standard edk2 packages. > +# > +# Copyright (c) 2023, American Megatrends International LLC. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x00010005 > + PACKAGE_NAME = UsbNetworkPkg > + PACKAGE_GUID = abfab91e-37ea-4cb4-80a6-563dbb0bcec6 > + PACKAGE_VERSION = 0.1 > + > +[Includes] > + Include > + > +[Protocols] > + ## Include/Protocol/EdkIIUsbEthernet.h > + gEdkIIUsbEthProtocolGuid = { 0x8d8969cc, 0xfeb0, 0x4303, { 0xb2, 0x1a, 0x1f, 0x11, 0x6f, 0x38, 0x56, 0x43 } } > + > +[Guids] > + ## Usb Network package token space GUID > + gUsbNetworkPkgTokenSpaceGuid = { 0xA1231E82, 0x21B8, 0x4204, { 0x92, 0xBB, 0x37, 0x3A, 0xFB, 0x01, 0xC6, 0xA1 } } > + > +[PcdsFeatureFlag] > + > + ## Set the PCD 'UsbCdcEcmSupport' to 'TRUE' if 'Usb Cdc Ecm device' need to be enabled. > + gUsbNetworkPkgTokenSpaceGuid.UsbCdcEcmSupport|FALSE|BOOLEAN|0x00000001 > + > + ## Set the PCD 'UsbCdcNcmSupport' to 'TRUE' if 'Usb Cdc Ncm device' need to be enabled. > + gUsbNetworkPkgTokenSpaceGuid.UsbCdcNcmSupport|FALSE|BOOLEAN|0x00000002 > + > + ## Set the PCD 'UsbRndisSupport' to 'TRUE' if 'Usb Rndis device' need to be enabled. > + gUsbNetworkPkgTokenSpaceGuid.UsbRndisSupport|TRUE|BOOLEAN|0x00000003 > + > +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > + ## Support rate limiting > + gUsbNetworkPkgTokenSpaceGuid.EnableRateLimiting|FALSE|BOOLEAN|0x00010001 > + > + ## The rate limiting Credit value is check in rate limiter event. > + # It is to control the RateLimitingCreditCount max value. > + gUsbNetworkPkgTokenSpaceGuid.RateLimitingCredit|10|UINT32|0x00010002 > + Is that valid to have all those PCD types in a single section? -- Rebecca Cran