From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0D010D80041 for ; Wed, 13 Mar 2024 02:13:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=i3HXaQvgmNXTxxd04sTcSuyhFybI5MJZcn4v6Fw8MhQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710295986; v=1; b=isoY9g3UjeBWXjB5BLjCdI9jjD1jr4RUNNUDE7h0vGPcF+WdHb3ahqiwDzxyl09hTumqpAHu 2x77bjBhEDnHIx5xcDPgb3Ves8BgNeJptg69cpWRdYzqRjtqh6fYksEF/jP4Qhk1Yj4UeFvtP67 iyiTVZ9ptCXYwv4bgqkZHVth4n9piSlbWGt/rua4YaUvVyrr+uxqa11Jg2Vh1KP5Fb42l2M6xmR GySgWi6NVwhcVU4mJoFR4sdcPL+UO3fR8ieFvBgKk8Z60kWLLO2cteO7yIVbz/9VhVGE3sqocIz /nMf3mQcimBz5YCCAnw29DdS/YP3WDKHb0N3ozk8AG8xQ== X-Received: by 127.0.0.2 with SMTP id bEZIYY7687511xpMBKjvu5uQ; Tue, 12 Mar 2024 19:13:06 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.7090.1710295985172483656 for ; Tue, 12 Mar 2024 19:13:05 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxeeisC_Fl_xIYAA--.39380S3; Wed, 13 Mar 2024 10:13:00 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c6rC_FlC_NXAA--.34671S3; Wed, 13 Mar 2024 10:12:59 +0800 (CST) Message-ID: <4103e1a2-47e5-4c97-88c5-6f30edf08fc9@loongson.cn> Date: Wed, 13 Mar 2024 10:12:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx To: devel@edk2.groups.io, qingyu.shang@intel.com Cc: Liming Gao , Zhichao Gao References: From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Ax3c6rC_FlC_NXAA--.34671S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAPCGXwEmcFSwABsp X-Coremail-Antispam: 1Uk129KBj93XoW7tryxWF4kZrW3JF1Duw45Jwc_yoW8WrWkpr W3Zws5KF4rXr1Ykw4UGa17u340ga4Svas093yDG343ZrsYva1xtry3KF4Ut34DJryfA3Wr ZFZ5tFyUua9rArXCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUgSb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x2 0xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx 0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k2 0xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r106r1rMI 8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41l IxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIx AIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1njjDUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 19:13:05 -0700 Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hTu0g4rPi0ybDVT0fepqpeeIx7686176AA= Content-Type: multipart/alternative; boundary="------------tze2Z0oITRJMoFMjwXrcXg0T" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=isoY9g3U; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------tze2Z0oITRJMoFMjwXrcXg0T Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Qingyu, It may not be my domain, I think what you are trying to say is "Refer to UEFI spec 2.10 section 12.3.3",  not 13.3.3, because the 13.3.3 is "Number and Location of System Partitions", see me comment below. I recommend fixing all of the patch commit messages in this series. The changes looks good to me and would recommend Liming and Zhichao to check again. Thanks, Chao On 2024/3/11 16:41, Qingyu wrote: > Refer to Uefi spec 2.10 section 13.3.3, Add a new retval It should be section 12.3.3, not 13.3.3. > EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx > and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). > > Cc: Liming Gao > Cc: Zhichao Gao > Cc: Chao Li > Signed-off-by: Qingyu > --- > ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c b/ShellPkg/Application/Shell/ConsoleWrappers.c > index eae11370e4e0..dbffae30cdf5 100644 > --- a/ShellPkg/Application/Shell/ConsoleWrappers.c > +++ b/ShellPkg/Application/Shell/ConsoleWrappers.c > @@ -67,7 +67,9 @@ FileBasedSimpleTextInReset ( > @param[in] This A pointer to the SimpleTextIn structure. > @param[in, out] Key A pointer to the Key structure to fill. > > - @retval EFI_SUCCESS The read was successful. > + @retval EFI_SUCCESS The read was successful. > + @retval EFI_UNSUPPORTED The device does not support the ability to read > + keystroke data. > **/ > EFI_STATUS > EFIAPI -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116703): https://edk2.groups.io/g/devel/message/116703 Mute This Topic: https://groups.io/mt/104886872/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------tze2Z0oITRJMoFMjwXrcXg0T Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Qingyu,

It may not be my domain, I think what you are trying to say is "Refer to UEFI spec 2.10 section 12.3.3",  not 13.3.3, because the 13.3.3 is "Number and Location of System Partitions", see me comment below. I recommend fixing all of the patch commit messages in this series.

The changes looks good to me and would recommend Liming and Zhichao to check again.


Thanks,
Chao
On 2024/3/11 16:41, Qingyu wrote:
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval
It should be section 12.3.3, not 13.3.3.
EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx
and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Qingyu <qingyu.shang@intel.com>
---
 ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c b/ShellPkg/Application/Shell/ConsoleWrappers.c
index eae11370e4e0..dbffae30cdf5 100644
--- a/ShellPkg/Application/Shell/ConsoleWrappers.c
+++ b/ShellPkg/Application/Shell/ConsoleWrappers.c
@@ -67,7 +67,9 @@ FileBasedSimpleTextInReset (
   @param[in] This      A pointer to the SimpleTextIn structure.
   @param[in, out] Key  A pointer to the Key structure to fill.
 
-  @retval   EFI_SUCCESS The read was successful.
+  @retval EFI_SUCCESS      The read was successful.
+  @retval EFI_UNSUPPORTED  The device does not support the ability to read
+                           keystroke data.
 **/
 EFI_STATUS
 EFIAPI
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#116703) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------tze2Z0oITRJMoFMjwXrcXg0T--