[edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[WangYang]

Adapting memory addresses may not start from 0x0,
for example, the starting memory address starts
from 0x8000_0000.

I understand: LowestMemBase is the lowest DDR
address in the system.

UefiMemoryBase = LowestMemBase +
CodeSize(opensbi+UEFI);

LowestMemSize -= CodeSize(UefiMemoryBase -
LowestMemBase)

Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>

Signed-off-by: Yang Wang <wangyang@bosc.ac.cn>
---
 Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
index df49a17695..a160278eaa 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
@@ -301,8 +301,8 @@ MemoryPeimInitialization (
   }
 
   if (UefiMemoryBase > LowestMemBase) {
+    LowestMemSize -= (UefiMemoryBase - LowestMemBase);
     LowestMemBase = UefiMemoryBase;
-    LowestMemSize -= UefiMemoryBase;
   }
 
   DEBUG ((
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117072): https://edk2.groups.io/g/devel/message/117072
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[Jingyu Li via groups.io]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

I have verified the above patch on the SG2042 platform. I agree with your understanding of the LowestMemBase.

Best Regards,
Jingyu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117213): https://edk2.groups.io/g/devel/message/117213
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 933 bytes --]

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[WangYang]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Hi,Sunil V L

    How about this status.
​


-----原始邮件-----
发件人:"Jingyu Li via groups.io" <jingyu.li01=sophgo.com@groups.io>
发送时间:2024-03-28 21:46:53 (星期四)
收件人: WangYang <wangyang@bosc.ac.cn>, devel@edk2.groups.io
抄送:
主题: Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

I have verified the above patch on the SG2042 platform. I agree with your understanding of the LowestMemBase.


Best Regards,
Jingyu

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117333): https://edk2.groups.io/g/devel/message/117333
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1612 bytes --]

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[Sunil V L]

On Mon, Mar 25, 2024 at 10:09:28AM +0800, Yang Wang wrote:
> Adapting memory addresses may not start from 0x0,
> for example, the starting memory address starts
> from 0x8000_0000.
> 
> I understand: LowestMemBase is the lowest DDR
> address in the system.
> 
> UefiMemoryBase = LowestMemBase +
> CodeSize(opensbi+UEFI);
> 
> LowestMemSize -= CodeSize(UefiMemoryBase -
> LowestMemBase)
> 
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> 
> Signed-off-by: Yang Wang <wangyang@bosc.ac.cn>
> ---
>  Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> index df49a17695..a160278eaa 100644
> --- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> +++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> @@ -301,8 +301,8 @@ MemoryPeimInitialization (
>    }
>  
>    if (UefiMemoryBase > LowestMemBase) {
> +    LowestMemSize -= (UefiMemoryBase - LowestMemBase);
>      LowestMemBase = UefiMemoryBase;
> -    LowestMemSize -= UefiMemoryBase;
>    }
>  
LGTM.

Jingyu, Do you mind adding RB tag?

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117341): https://edk2.groups.io/g/devel/message/117341
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[Jingyu Li via groups.io]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi Sunil V L,

Not at all! Thanks!

Best Regards,
Jingyu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117342): https://edk2.groups.io/g/devel/message/117342
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 867 bytes --]

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[WangYang]

Hi, Sunil V L
   Do I still need to send a v2 version of the RB tag with “Jingyu Li <jingyu.li01@sophgo.com>”? 
   Or did you help add RB tag with “Jingyu Li <jingyu.li01@sophgo.com>” during the merger?

Best Regards,
WangYang

> -----原始邮件-----
> 发件人: "Sunil V L" <sunilvl@ventanamicro.com>
> 发送时间: 2024-04-03 11:48:59 (星期三)
> 收件人: "Yang Wang" <wangyang@bosc.ac.cn>
> 抄送: caiyuqing_hz@outlook.com, devel@edk2.groups.io, USER0FISH <libing1202@outlook.com>, dahogn <dahogn@hotmail.com>, meng-cz <mengcz1126@gmail.com>
> 主题: Re: [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize
> 
> On Mon, Mar 25, 2024 at 10:09:28AM +0800, Yang Wang wrote:
> > Adapting memory addresses may not start from 0x0,
> > for example, the starting memory address starts
> > from 0x8000_0000.
> > 
> > I understand: LowestMemBase is the lowest DDR
> > address in the system.
> > 
> > UefiMemoryBase = LowestMemBase +
> > CodeSize(opensbi+UEFI);
> > 
> > LowestMemSize -= CodeSize(UefiMemoryBase -
> > LowestMemBase)
> > 
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: USER0FISH <libing1202@outlook.com>
> > Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> > Cc: dahogn <dahogn@hotmail.com>
> > Cc: meng-cz <mengcz1126@gmail.com>
> > 
> > Signed-off-by: Yang Wang <wangyang@bosc.ac.cn>
> > ---
> >  Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> > index df49a17695..a160278eaa 100644
> > --- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> > +++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
> > @@ -301,8 +301,8 @@ MemoryPeimInitialization (
> >    }
> >  
> >    if (UefiMemoryBase > LowestMemBase) {
> > +    LowestMemSize -= (UefiMemoryBase - LowestMemBase);
> >      LowestMemBase = UefiMemoryBase;
> > -    LowestMemSize -= UefiMemoryBase;
> >    }
> >  
> LGTM.
> 
> Jingyu, Do you mind adding RB tag?
> 
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> 
> Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117488): https://edk2.groups.io/g/devel/message/117488
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SG2042Pkg/Sec:Modify Calculation LowestMemSize

[Sunil V L]

On Mon, Apr 08, 2024 at 11:00:47AM +0800, WangYang wrote:
> Hi, Sunil V L
>    Do I still need to send a v2 version of the RB tag with “Jingyu Li <jingyu.li01@sophgo.com>”? 
>    Or did you help add RB tag with “Jingyu Li <jingyu.li01@sophgo.com>” during the merger?
> 
Never mind. I have updated the RB tags and merged as #134.

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117489): https://edk2.groups.io/g/devel/message/117489
Mute This Topic: https://groups.io/mt/105131337/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-