Re: [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

[Laszlo Ersek <lersek@redhat.com>]

On 11/02/18 04:23, yuchenlin via edk2-devel wrote:
> From: yuchenlin <yuchenlin@synology.com>
> 
> This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2.
> 
> The VMWare SVGA model now -- since commit 104bd1dc70 in QEMU --
> falls back to stdvga (that is, Bochs) if we don't setup VMWare SVGA
> FIFO.
> 
> To simplify QemuVideoDxe, we don't intend to implement the VMWare SVGA
> FIFO setup feature. It means our current VMW SVGA driver code is
> basically dead. To simplify the problem, we will replace the old
> VMWare SVGA driver to Bochs interface. It should work on all QEMU
> version.
> 
> The first step for using Bochs interface is to revert old driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> ---
>  OvmfPkg/QemuVideoDxe/Driver.c     | 135 +------------------------
>  OvmfPkg/QemuVideoDxe/Gop.c        |  65 +------------
>  OvmfPkg/QemuVideoDxe/Initialize.c | 157 ------------------------------
>  OvmfPkg/QemuVideoDxe/Qemu.h       |  29 ------
>  4 files changed, 7 insertions(+), 379 deletions(-)

I've reviewed this patch as follows:

- I determined that c137d95081690d4877fbeb5f1856972e84ac32f2 was indeed
the commit to revert at this point.

- I applied your series, on top of current master (@ 62ea70e31285),
using local branch name "yuchenlin_v2". Then I checked whether the state
just before c137d9508169 matched the state after this revert -- all
differences would have to be unrelated to the feature in question. My
command was:

  git diff --color \
    c137d95081690d4877fbeb5f1856972e84ac32f2^..yuchenlin_v2~3 -- \
    OvmfPkg/QemuVideoDxe/ \
    OvmfPkg/Include/IndustryStandard/

The differences are indeed orthogonal, so this looks like a valid revert.

In addition, the patch itself looks good, plus OVMF continues to build
fine after this patch (for bisectability's sake).

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo