From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1107721B02822 for ; Tue, 6 Nov 2018 02:36:56 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 752FF394D57; Tue, 6 Nov 2018 10:36:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-95.rdu2.redhat.com [10.10.120.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA6975D757; Tue, 6 Nov 2018 10:36:53 +0000 (UTC) To: yuchenlin@synology.com, edk2-devel@lists.01.org Cc: phil@philjordan.eu, jordan.l.justen@intel.com, anthony.perard@citrix.com References: <20181102032402.19686-1-yuchenlin@synology.com> <20181102032402.19686-3-yuchenlin@synology.com> From: Laszlo Ersek Message-ID: <414b8597-a6c9-3766-9bca-382b7bddfd3d@redhat.com> Date: Tue, 6 Nov 2018 11:36:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181102032402.19686-3-yuchenlin@synology.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 06 Nov 2018 10:36:55 +0000 (UTC) Subject: Re: [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 10:36:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/02/18 04:23, yuchenlin via edk2-devel wrote: > From: yuchenlin > > This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. > > The VMWare SVGA model now -- since commit 104bd1dc70 in QEMU -- > falls back to stdvga (that is, Bochs) if we don't setup VMWare SVGA > FIFO. > > To simplify QemuVideoDxe, we don't intend to implement the VMWare SVGA > FIFO setup feature. It means our current VMW SVGA driver code is > basically dead. To simplify the problem, we will replace the old > VMWare SVGA driver to Bochs interface. It should work on all QEMU > version. > > The first step for using Bochs interface is to revert old driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin > --- > OvmfPkg/QemuVideoDxe/Driver.c | 135 +------------------------ > OvmfPkg/QemuVideoDxe/Gop.c | 65 +------------ > OvmfPkg/QemuVideoDxe/Initialize.c | 157 ------------------------------ > OvmfPkg/QemuVideoDxe/Qemu.h | 29 ------ > 4 files changed, 7 insertions(+), 379 deletions(-) I've reviewed this patch as follows: - I determined that c137d95081690d4877fbeb5f1856972e84ac32f2 was indeed the commit to revert at this point. - I applied your series, on top of current master (@ 62ea70e31285), using local branch name "yuchenlin_v2". Then I checked whether the state just before c137d9508169 matched the state after this revert -- all differences would have to be unrelated to the feature in question. My command was: git diff --color \ c137d95081690d4877fbeb5f1856972e84ac32f2^..yuchenlin_v2~3 -- \ OvmfPkg/QemuVideoDxe/ \ OvmfPkg/Include/IndustryStandard/ The differences are indeed orthogonal, so this looks like a valid revert. In addition, the patch itself looks good, plus OVMF continues to build fine after this patch (for bisectability's sake). Reviewed-by: Laszlo Ersek Thanks Laszlo