From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.1830.1624586105009357700 for ; Thu, 24 Jun 2021 18:55:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=RlCa14Dr; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 6A03F20B6C50; Thu, 24 Jun 2021 18:55:04 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6A03F20B6C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624586104; bh=VdyzU8g5g5k+AMG1y/W8GLhv29Xj3wxsb945r2D2CTE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RlCa14Drs6otLEKAZJ1LGYa8607nWYgnO85h+8/lBxHfaQwGjOHBKwJ6A80xQThSm w32CmYmfE0uayOcjjwXc1FPsSwMmVhQiw/qocs3OZT2w7+WM+NMcqX3kaRYhJb3lpU q4Ouivl7EDz3IYOthVHqbIDu0dmv2Y2td+Kw5ojE= Subject: Re: [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" Cc: "Ni, Ray" , "Desimone, Nathaniel L" References: <20210618020726.5991-1-mikuback@linux.microsoft.com> <20210618020726.5991-7-mikuback@linux.microsoft.com> From: "Michael Kubacki" Message-ID: <41521b7c-2b91-b4db-e40a-1bc3318bc6b6@linux.microsoft.com> Date: Thu, 24 Jun 2021 21:55:05 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Sai, That sounds fine to me. I'll send it in a v4 soon. Thanks, Michael On 6/24/2021 5:56 PM, Chaganty, Rangasai V wrote: > Hi Michael, > Since there is a change in SPI protocol/PPI services (enum to EFI_GUID type for Flash region types), perhaps defining a new GUID would be better, just to make sure there are no collisions. > Do you see any downside to it? > > Regards, > Sai > > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, June 17, 2021 7:07 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L > Subject: [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 > > This SPI PPI definition is intended to serve as the single definition for Intel platform and silicon packages. > > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h | 25 ++++++++++++++++++++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ > 2 files changed, 28 insertions(+) > > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h b/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h > new file mode 100644 > index 000000000000..b2410bd17300 > --- /dev/null > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi.h > @@ -0,0 +1,25 @@ > +/** @file > + This file defines the PCH SPI PPI which implements the > + Intel(R) PCH SPI Host Controller Compatibility Interface. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ #ifndef > +_PCH_SPI_PPI_H_ #define _PCH_SPI_PPI_H_ > + > +#include > + > +// > +// Extern the GUID for PPI users. > +// > +extern EFI_GUID gPchSpiPpiGuid; > + > +/** > + Reuse the PCH_SPI_PROTOCOL definitions > + This is possible becaues the PPI implementation does not rely on a > +PeiService pointer, > + as it uses EDKII Glue Lib to do IO accesses **/ typedef > +PCH_SPI_PROTOCOL PCH_SPI_PPI; > + > +#endif > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index fb8391000347..70f030e3a295 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -71,6 +71,9 @@ [Guids] > gEdkiiMicrocodeStorageTypeFlashGuid = { 0x2cba01b3, 0xd391, 0x4598, { 0x8d, 0x89, 0xb7, 0xfc, 0x39, 0x22, 0xfd, 0x71 } } > > [Ppis] > + ## Include/Ppi/Spi.h > + gPchSpiPpiGuid = {0xdade7ce3, 0x6971, 0x4b75, {0x82, 0x5e, 0xe, 0xe0, > + 0xeb, 0x17, 0x72, 0x2d}} > + > gEdkiiVTdInfoPpiGuid = { 0x8a59fcb3, 0xf191, 0x400c, { 0x97, 0x67, 0x67, 0xaf, 0x2b, 0x25, 0x68, 0x4a } } > gEdkiiVTdNullRootEntryTableGuid = { 0x3de0593f, 0x6e3e, 0x4542, { 0xa1, 0xcb, 0xcb, 0xb2, 0xdb, 0xeb, 0xd8, 0xff } } > > -- > 2.28.0.windows.1 >