From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.89]) by mx.groups.io with SMTP id smtpd.web12.11692.1636551025878665173 for ; Wed, 10 Nov 2021 05:30:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=zPgosv8c; spf=pass (domain: arm.com, ip: 40.107.4.89, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZgPY86W862WB9RX/PeakhFEHPSVVBic1f/6Nnl4eRM=; b=zPgosv8cxvQMU7IKc2gNl4D5KVDpGLsPF+giJ1ceudWROGZnXuXoblY/6cK/bWTjlLGag/PQchmbsQcFpt5jx+Al0OkAVYtkUsxWwV8s6K03aX6h6OgqWiLjlBhxyZeF2XQsLqQOHZqNcwgrRKeDu6triz7tce5uMH6WYM1m450= Received: from AS8PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:20b:459::24) by AM9PR08MB7199.eurprd08.prod.outlook.com (2603:10a6:20b:3de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 13:30:23 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::8a) by AS8PR07CA0031.outlook.office365.com (2603:10a6:20b:459::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.8 via Frontend Transport; Wed, 10 Nov 2021 13:30:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 10 Nov 2021 13:30:22 +0000 Received: ("Tessian outbound 4ce13939bd4a:v108"); Wed, 10 Nov 2021 13:30:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 673e7236740cb9fb X-CR-MTA-TID: 64aa7808 Received: from 9f41a5670569.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E551DE6-C092-4871-98AD-63E9741295D2.1; Wed, 10 Nov 2021 13:30:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f41a5670569.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Nov 2021 13:30:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0oFNLJol4AQbV8qPH6iKxIOGjp9jeO9hCFprOsO+B5glSnp0nJZEz5x63zKcsrbavklyqgyM75+7hgcHQFDAazBGbP2j+Da8fJ3gniKS/0rfYll+AAauQPJbgfGz/G1tv1ynYZYOhzFKwkwg/L2QNtkNPqo9JQLY5kWKura0N3R6yFdvKwHvXO5HLJie4Cb9w/xuCkfJxwXnWDIbNkcczeRhOcE5vvkwlCvts9cQMlG/KNT0tZ91pWEC5t336S6/jz10cS8L3xlgUWJxZQh632ewv8O2hup1NkbFAf0JR+TmgzFawKTJaWzKsyxKybjpluA6Pf9B7wPHdAqeqpJkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yZgPY86W862WB9RX/PeakhFEHPSVVBic1f/6Nnl4eRM=; b=kSEYqdcPCxj/KmAe34D3PmaoImVegiFDyrqXijKxryJ7SD8hgkz5eQaleExvJRzoRV9fS06a+WYR+O88dncNDihLek08fgkaGnPdNg3nUWmLrj7BYfaHQ8MNvHaLjF3jzyXNv05M1568JC51BsPxzFx9bRyk6NsNmjuxJ+fqT8MdqFFpXFUzKvTPNy/QJkG0d1wioy1LMIgUuI8mvk6+WrQ4kDS3fPF7zkkkRRhO4nGWlfbSlv+nsWQBu+67u6KZ7lMRpiD3S/io4CzyfIF8/UtLsfolky/FiIYmH8Y/I5Uw0ca97/2X0FyPU75SeKSr/iXxmuwXw2cNIWAlmofLUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZgPY86W862WB9RX/PeakhFEHPSVVBic1f/6Nnl4eRM=; b=zPgosv8cxvQMU7IKc2gNl4D5KVDpGLsPF+giJ1ceudWROGZnXuXoblY/6cK/bWTjlLGag/PQchmbsQcFpt5jx+Al0OkAVYtkUsxWwV8s6K03aX6h6OgqWiLjlBhxyZeF2XQsLqQOHZqNcwgrRKeDu6triz7tce5uMH6WYM1m450= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB5077.eurprd08.prod.outlook.com (2603:10a6:20b:e6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 13:30:13 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4669.010; Wed, 10 Nov 2021 13:30:13 +0000 Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 00/11] Fix build breaks and update IORT revision macro To: Ard Biesheuvel , edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , Pierre , Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, "Liming Gao (Byosoft address)" , Peter Batard , Thomas Abraham , Chandni.Cherukuri@arm.com, Khasim.Mohammed@arm.com, nd References: <20211110110117.31160-1-sami.mujawar@arm.com> From: "Sami Mujawar" Message-ID: <4152d2d7-9c91-c105-4972-aafd8b5697ad@arm.com> Date: Wed, 10 Nov 2021 13:30:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: X-ClientProxiedBy: LO2P265CA0507.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0507.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16 via Frontend Transport; Wed, 10 Nov 2021 13:30:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0747df72-8151-4649-1397-08d9a44e3f8b X-MS-TrafficTypeDiagnostic: AM6PR08MB5077:|AM9PR08MB7199: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NXLDiQOtL5IfaksmZgYwfsXGDzRseO1pIpv0rsP0WfIkiuvsv7ct12ORC8RhBDQLK2LeDpnuABQVc77f3NQNFiWQ16e9i645HHQ9oqERWHAeqXXvGkCVdmMHwFeVQOXpBja41HVIm8wzKxSooeKjvxN4ZzltOat30828Mt6hUDCz8RUaebu1ge/rzt+YApO13aykah7CQQNNw7hb9rlc0TP/ek7AAWEaLWOmBJzKo7O9L8k6vU8g3MiNfbECZajnJcSRUP+dbJfOLYL37VNFLnADua8X+3vgs/+36csxHXqui3mg5jV5sQBxqxpyvzzgWmCYRG0FSC0SSCgNmPK6bv97nOmO5gnDlPwtlVjQLV6jM4Fd7UBMqDELkQ+TMjmfgMjt3yJsAsqPyrUAwiVKF5W2dC/qcScmK4mruSmvFY5kq2wRiE2ob8CsrgRbcrySCFR+f6IDBxaU+lnY2jz3JmWor3vxNvP7IUekDQBW83ZIiylWpAqfTWn5GHAmsdqcH481hHloejTy8J0lAG0ShnJdJmmtN+KoIjoo/43lwEheTJf/CYG5FmKFFp3XUgYfLpRHr7o1aCiJyXPOu4ynUDkFR/iAfzsHaaFrJ99KEd0hKoPGMnkJrzRpunEtko0hdOEOyinLOYBH159AQjiyrd6ZK9zT/iMKWybrC6907tUJByzrSZpO3VCbcRFSI3TFZ2z5O9Q9xX5dzZWeRXbo4prJPOxNnVN/G2U3/oOF2tQI8NMFKcJAeazHIIEzQcGKjr6MDUWgQfB48Dc/pWAesOTHZPTTGzNmtGPfaApyQ9zrtbIUV6EMVxOqmPQovee3lgUUKKv3N27oiDuy1/GnxiLkfrU3xE3QqXHapw+uwGo9aXDanJoiK1teckTwJ2ImKS7cQiCIHbbAQnnwZCQZQOfh/qQDu/+zdjQBs7w8gOw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(15650500001)(2616005)(956004)(8936002)(52116002)(83380400001)(966005)(508600001)(4326008)(6486002)(36756003)(31696002)(8676002)(44832011)(5660300002)(38350700002)(31686004)(38100700002)(66476007)(26005)(66556008)(54906003)(53546011)(2906002)(186003)(110136005)(66946007)(16576012)(86362001)(316002)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5077 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1920a876-33ae-4aff-6143-08d9a44e399c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bf3ljUl/oMb8UYoYxW8G7y9xL4HRcRV/OxwRLPln6BTqw3NzAKUQuKjdQxI6XVc3TBqO0UeXqvx7pVAjkph/udLUnt6PAXV54BaWDWFL41j/Y5u6lr9L5pzlwyPQ8pagIfNAXGbyu1M8NPoLT4ASJjllJeNjmIhiFrl5c57xcNofmiIcAeZIJDcFcoOOvQPJ7ZzUnS8wpQmgWq8hSYM6FwaYsLhdD5u2k41GOH1SSVHL1CsUW8o1j4NfjxbVL/3lWg04fUmfDYJXOjLWJQ8DmCHwalHqO9cvKTUlpbkke7X5BwxDkA0pQFEJ45Sija9ND0/+aHDrWsS6CpHuzg9WhFqUAJXAsQKPpdTvqhS4a7mNYcRUU9odfA9m0Q2qr+oB+v5cmwp10YpHLAQ8UpBCIH56b1niWUagY5BuGXt1xSqRQoZqv8pYabCiavstZIZ94M7pNbaX/72X+yCcaqTXm3XcnXWEAAVo2GFKTYqC+hJf5hfMK/Q954fbuv1vgQKxdk7ivYEa7XjwODh6gT0oy6pGGHdkbqj1OdowQFjqIf2D81akCTrTbpstYknm+MEWNfrpqEx03xU/280w4WHDEaYug0uqGO7s7lMEr9/3g+UUOUz7qsZyqtX6Dft3a5va8xK6EYWW7alo9Uwm6h9IxzbNt8Uj19BHUZIWU5tQkavuFzW/UFq38qeFIAmV1id2jIaAyrDXQK2n7Ba8bDb44whFtUVg2Iwp45JTxT0IPQb5wAlUuuDSOp6URVhwYxsHl36oAIloVWQHmHs3ahbUTdsHKYN/Yz/t5ncUXSUFD4cYzOK01WSfQ2qkMprGxILsM61mx9WEwpsj0DhAMgPBeEq7DylU5RU0SksAsIDkQd8NgAGYVifa1MaHDmv8cuwG X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(31686004)(8676002)(8936002)(15650500001)(2906002)(54906003)(356005)(16576012)(508600001)(5660300002)(26005)(36860700001)(47076005)(6486002)(36756003)(70586007)(82310400003)(966005)(70206006)(110136005)(44832011)(186003)(86362001)(81166007)(83380400001)(2616005)(4326008)(336012)(956004)(316002)(53546011)(31696002)(21314003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 13:30:22.8659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0747df72-8151-4649-1397-08d9a44e3f8b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7199 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 10/11/2021 11:33 AM, Ard Biesheuvel wrote: > On Wed, 10 Nov 2021 at 12:01, Sami Mujawar wrote: >> The first 4 patches in this series fix build breaks in upstream >> edk2-platforms code for Socionext, Lemaker and SynQuacerEvalBoard. >> >> The IORT Rev E.b specification updates the IORT table revision >> to 3. Following this the IORT table revision macro >> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has >> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. > I *really* don't like this. All other ACPI tables are set up in a > forward compatible way, where an existing definition in code is > guaranteed to comply with later versions of the spec, and can always > claim to be the newest revision. This is the reason why > xxx_TABLE_REVISION macros exist in the first place. > > So I suppose that means that the IORT was modified in a non-forward > compatible fashion? Does that mean that newer firmware has to stick > with the old revision in order to remain able to boot older OS > versions? [SAMI] I don't think the OS compatibility is broken by the IORT spec. In edk2, the revision macro for IORT is defined differently when compared to the other ACPI table version macros. e.g. The IORT revision macro was defined as "#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0" compare this to MADT table version macro which is "#define EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION 0x05". Note the EFI_ACPI_x_x prefix in MADT macro name. This allows existing tables to work, as for ACPI 6.3 the version in Acpi63.h i.e. EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION will be used. Since IORT table version macro does not have any version information in the macro name EFI_ACPI_IO_REMAPPING_TABLE_REV0 is introduced. The IORT Rev E.b introduces updates the table vertion to 3 and therefore EFI_ACPI_IO_REMAPPING_TABLE_REV3 has been introduced. Ref: https://edk2.groups.io/g/devel/message/83547 This IORT Rev E.b patch series essentially retrofits the version tag missing in the IORT table revision macro and this edk2-platform series is a corresponding adotption. [/SAMI] > > >> Therefore, >> the last 7 patches in this series are added to reflect this >> change for the following platforms: >> - FVP >> - Morello FVP >> - SGI >> - AMD/Styx >> - Socionext/SynQuacer >> - RaspberryPi >> - N1SDP >> >> Note: This patch series is dependent on the edk2 patch series: >> "[PATCH v3 0/8] IORT Rev E.b specification updates" >> (https://edk2.groups.io/g/devel/message/83545), which must >> be merged in edk2 before this patch series can be integrated. >> >> The changes can be seen at: >> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_eb_platforms_v1 >> >> Sami Mujawar (11): >> Platform/Socionext: Fix build break for SynQuacerEvalBoard >> Platform/LeMaker: Fix build break for CelloBoard >> Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib >> Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 >> builds >> Platform/ARM: FVP: Update for IORT revision macro renaming >> Platform/ARM: Morello: Update for IORT revision macro renaming >> Platform/ARM: SGI: Update for IORT revision macro renaming >> Silicon/AMD/Styx: Update for IORT revision macro renaming >> Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming >> Platform/RaspberryPi: Update for IORT revision macro renaming >> Platform/ARM: N1SDP: Update for IORT revision macro renaming >> >> Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +- >> Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- >> Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- >> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- >> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 +++- >> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +- >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 11 +++++++++-- >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 8 +++++++- >> Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +- >> Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +- >> 10 files changed, 26 insertions(+), 11 deletions(-) >> >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >> >> >> >> >> >>