From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 13 Jun 2019 07:45:18 -0700
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id B7B7A30860C8;
	Thu, 13 Jun 2019 14:45:17 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 6D9142C9FA;
	Thu, 13 Jun 2019 14:45:16 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v1 6/6] OvmfPkg/Csm/CsmSupportLib: Drop IntelFrameworkPkg dependency
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Ray Ni <ray.ni@intel.com>, David Woodhouse <dwmw2@infradead.org>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190527051922.5280-1-hao.a.wu@intel.com>
 <20190527051922.5280-7-hao.a.wu@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <41614ec4-cee0-0beb-1dc4-f7088321e031@redhat.com>
Date: Thu, 13 Jun 2019 16:45:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190527051922.5280-7-hao.a.wu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 13 Jun 2019 14:45:17 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
> 
> This commit will update the INF file of the CsmSupportLib to drop its
> dependency on IntelFrameworkPkg:
> 
> gEfiLegacyBiosPlatformProtocolGuid
> gEfiLegacyBiosProtocolGuid
> gEfiLegacyInterruptProtocolGuid
> 
> The above dependencies have already been addressed by the duplication of
> these definitions from IntelFrameworkPkg to OvmfPkg.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
>  OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf b/OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf
> index 229f2e0b4b..45f201f07b 100644
> --- a/OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf
> +++ b/OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Platform CSM Support Library
>  #
> -#  Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2008 - 2019, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> @@ -34,7 +34,6 @@ [Sources]
>  
>  [Packages]
>    MdePkg/MdePkg.dec
> -  IntelFrameworkPkg/IntelFrameworkPkg.dec
>    OvmfPkg/OvmfPkg.dec
>  
>  [Pcd]
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>