From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 886242034C8DD for ; Fri, 27 Apr 2018 15:33:02 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 15:33:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,336,1520924400"; d="scan'208";a="54252837" Received: from jcarsey-desk1.amr.corp.intel.com ([10.7.159.144]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2018 15:32:59 -0700 From: Jaben Carsey To: edk2-devel@lists.01.org Cc: Liming Gao , Yonghong Zhu Date: Fri, 27 Apr 2018 15:32:37 -0700 Message-Id: <416b1af9225e09c98e01c3c727506c0d20f1a406.1524868034.git.jaben.carsey@intel.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: References: In-Reply-To: References: Subject: [PATCH v1 23/42] BaseTools: refactor __init__ functions to not compute temporary variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 22:33:03 -0000 just assign correct value to member variable in __init__ or call parent __init__ Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 37 ++++---------------- 1 file changed, 7 insertions(+), 30 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py index 70c7db7ca7c4..4929bcf899ae 100644 --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py @@ -282,13 +282,9 @@ def toHex(s): # class DbItemList: def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] self.ItemSize = ItemSize - self.DataList = DataList - self.RawDataList = RawDataList + self.DataList = DataList if DataList else [] + self.RawDataList = RawDataList if RawDataList else [] self.ListSize = 0 def GetInterOffset(self, Index): @@ -357,11 +353,8 @@ class DbItemList: # class DbExMapTblItemList (DbItemList): def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbItemList.__init__(self, ItemSize, DataList, RawDataList) + def PackData(self): Buffer = '' PackStr = "=LHH" @@ -379,11 +372,8 @@ class DbExMapTblItemList (DbItemList): # class DbComItemList (DbItemList): def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbItemList.__init__(self, ItemSize, DataList, RawDataList) + def GetInterOffset(self, Index): Offset = 0 if self.ItemSize == 0: @@ -443,11 +433,8 @@ class DbComItemList (DbItemList): # class DbVariableTableItemList (DbComItemList): def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbComItemList.__init__(self, ItemSize, DataList, RawDataList) + def PackData(self): PackStr = "=LLHHLHH" Buffer = '' @@ -465,10 +452,6 @@ class DbVariableTableItemList (DbComItemList): class DbStringHeadTableItemList(DbItemList): def __init__(self,ItemSize,DataList=None,RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbItemList.__init__(self, ItemSize, DataList, RawDataList) def GetInterOffset(self, Index): @@ -511,11 +494,8 @@ class DbStringHeadTableItemList(DbItemList): # class DbSkuHeadTableItemList (DbItemList): def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbItemList.__init__(self, ItemSize, DataList, RawDataList) + def PackData(self): PackStr = "=LL" Buffer = '' @@ -531,11 +511,8 @@ class DbSkuHeadTableItemList (DbItemList): # class DbSizeTableItemList (DbItemList): def __init__(self, ItemSize, DataList=None, RawDataList=None): - if DataList is None: - DataList = [] - if RawDataList is None: - RawDataList = [] DbItemList.__init__(self, ItemSize, DataList, RawDataList) + def GetListSize(self): length = 0 for Data in self.RawDataList: -- 2.16.2.windows.1