Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Adds ACPI HPET Table generator

["PierreGondois" <pierre.gondois@arm.com>]

Hello Abdul,

On 3/4/24 16:43, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> Adds generic ACPI HPET table generator library.
> Register/Deregister HPET table.
> Update the HPET table during boot as per specification.
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
>   DynamicTablesPkg/DynamicTables.dsc.inc        |   2 +
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml     |   3 +-
>   DynamicTablesPkg/Include/AcpiTableGenerator.h |   1 +
>   .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf  |  35 +++
>   .../Library/Acpi/AcpiHpetLib/HpetGenerator.c  | 216 ++++++++++++++++++
>   5 files changed, 256 insertions(+), 1 deletion(-)
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c
> 
> diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc
> index 92f3a138e4..b2ef36eb8a 100644
> --- a/DynamicTablesPkg/DynamicTables.dsc.inc
> +++ b/DynamicTablesPkg/DynamicTables.dsc.inc
> @@ -34,6 +34,7 @@
>     # Generators
>     #
>     DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
> +  DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>   
>   [Components.IA32, Components.X64]
>     #
> @@ -42,6 +43,7 @@
>     DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf {
>       <LibraryClasses>
>         NULL|DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
> +      NULL|DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>     }
>   
>   [Components.ARM, Components.AARCH64]
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> index 1ad5540e24..cacdaa1df6 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> @@ -53,7 +53,8 @@
>               "EmbeddedPkg/EmbeddedPkg.dec",
>               "DynamicTablesPkg/DynamicTablesPkg.dec",
>               "MdeModulePkg/MdeModulePkg.dec",
> -            "MdePkg/MdePkg.dec"
> +            "MdePkg/MdePkg.dec",
> +            "PcAtChipsetPkg/PcAtChipsetPkg.dec"

Cf. the comment in:
    [PATCH v2 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator
I think this depenency should be removed. A HPET CmObj should be created
instead.
Sorry for not saying this in the v1.

[snip]

Regards,
Pierre


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116632): https://edk2.groups.io/g/devel/message/116632
Mute This Topic: https://groups.io/mt/104724516/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-