From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7144CAC12D7 for ; Mon, 11 Mar 2024 14:16:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6Y2F8XdTUtDdrFDWdchzZV6fVpwV+/Gd2Pv4VbU6AA4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:From:Subject:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710166561; v=1; b=16GCm4FOE94lPyETB8kD8Ai+wa436fAO4PGow0JHFJJ08a0jTLDRqk0wSYjiA+gkqEXduK0D eYFnYIcNVIWJqy6antY3lNcwGdv/UsZGnsD19ogKBs4lnHO5PNZvxF0xLgq8DN/DktO/hZOSYx6 a0TUZR8phPTndK5moZLQt0tfooIpt7NoUPHswcmzU6xO6sgKb0X/BPiJeMcpNBWvHVH/QeGQpbf UeJoJam6bWVEupQNilM827WzZ0msbaO1qnRpnSwVRbwIFLY620yfnYZfrUZQZsaF134S6VPSbW9 HUZ1auYVFP1IiyKNms8q2fLPhE4SkdiA9rWBqIllicGRg== X-Received: by 127.0.0.2 with SMTP id QaigYY7687511xw3x6g5ACla; Mon, 11 Mar 2024 07:16:01 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.63861.1710166560564119446 for ; Mon, 11 Mar 2024 07:16:00 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07DDBFEC; Mon, 11 Mar 2024 07:16:37 -0700 (PDT) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B5843F762; Mon, 11 Mar 2024 07:15:59 -0700 (PDT) Message-ID: <417ec259-f70b-46f5-9a3d-f28cedd347f6@arm.com> Date: Mon, 11 Mar 2024 07:16:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "PierreGondois" Subject: Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Adds ACPI HPET Table generator To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Sami Mujawar References: In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aR2mOLgf4TJ0iKM2YZRXGzbIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=16GCm4FO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Abdul, On 3/4/24 16:43, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar >=20 > Adds generic ACPI HPET table generator library. > Register/Deregister HPET table. > Update the HPET table during boot as per specification. >=20 > Cc: Sami Mujawar > Cc: Pierre Gondois > Signed-off-by: Abdul Lateef Attar > --- > DynamicTablesPkg/DynamicTables.dsc.inc | 2 + > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 1 + > .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 35 +++ > .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 216 ++++++++++++++++++ > 5 files changed, 256 insertions(+), 1 deletion(-) > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenera= tor.c >=20 > diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dy= namicTables.dsc.inc > index 92f3a138e4..b2ef36eb8a 100644 > --- a/DynamicTablesPkg/DynamicTables.dsc.inc > +++ b/DynamicTablesPkg/DynamicTables.dsc.inc > @@ -34,6 +34,7 @@ > # Generators > # > DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf > + DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > =20 > [Components.IA32, Components.X64] > # > @@ -42,6 +43,7 @@ > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.inf { > > NULL|DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf > + NULL|DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > } > =20 > [Components.ARM, Components.AARCH64] > diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg= /DynamicTablesPkg.ci.yaml > index 1ad5540e24..cacdaa1df6 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > @@ -53,7 +53,8 @@ > "EmbeddedPkg/EmbeddedPkg.dec", > "DynamicTablesPkg/DynamicTablesPkg.dec", > "MdeModulePkg/MdeModulePkg.dec", > - "MdePkg/MdePkg.dec" > + "MdePkg/MdePkg.dec", > + "PcAtChipsetPkg/PcAtChipsetPkg.dec" Cf. the comment in: [PATCH v2 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator I think this depenency should be removed. A HPET CmObj should be created instead. Sorry for not saying this in the v1. [snip] Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116632): https://edk2.groups.io/g/devel/message/116632 Mute This Topic: https://groups.io/mt/104724516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-