Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

["Laszlo Ersek" <lersek@redhat.com>]

On 11/7/23 16:52, Laszlo Ersek wrote:
> On 11/7/23 06:38, Ranbir Singh wrote:
>> From: Ranbir Singh <Ranbir.Singh3@Dell.com>
>>
>> The function USBMouseDriverBindingStart do have
>>
>>     ASSERT (UsbMouseDevice != NULL);
>>
>> after AllocateZeroPool, but it is applicable only in DEBUG mode.
>> In RELEASE mode, if for whatever reasons UsbMouseDevice is NULL
>> at this point, the code proceeds to dereference "UsbMouseDevice"
>> afterwards which will lead to CRASH.
>>
>> Hence, for safety add NULL pointer checks always.
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4222
>>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com>
>> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
>> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
>> index 451d4b934f4c..67072d476196 100644
>> --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
>> +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
>> @@ -160,7 +160,10 @@ USBMouseDriverBindingStart (
>>    }
>>  
>>    UsbMouseDevice = AllocateZeroPool (sizeof (USB_MOUSE_DEV));
>> -  ASSERT (UsbMouseDevice != NULL);
>> +  if (UsbMouseDevice == NULL) {
>> +    Status = EFI_OUT_OF_RESOURCES;
>> +    goto ErrorExit;
>> +  }
>>  
>>    UsbMouseDevice->UsbIo     = UsbIo;
>>    UsbMouseDevice->Signature = USB_MOUSE_DEV_SIGNATURE;
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 

sorry I missed that I gave R-b for this previously, and that you had
picked it up already!



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110859): https://edk2.groups.io/g/devel/message/110859
Mute This Topic: https://groups.io/mt/102437986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-