From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2F84780091 for ; Tue, 7 Nov 2023 15:54:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NUKRoKOiqmRNv+9udFZRSM/XHRnKE0Fx3ufYZV/MLu4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699372482; v=1; b=ui0DOjniqVUlEPyW9Zh7mQheyhxSrQSrgkmZTYgbxLeyoOBsDeS9IL66hj1NrFYI1fsW4Eqw euy9bEOdUV7AK/1g59CV3S6cGTDofh22D6S1Jek9DQwAWidMxpvKZbjzMdjfm0rlXnQNdmJMScR /qvrLqAe7jcjwCI4aAFcZmBA= X-Received: by 127.0.0.2 with SMTP id sqjUYY7687511xR46Okga8J1; Tue, 07 Nov 2023 07:54:42 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.14351.1699372482025012304 for ; Tue, 07 Nov 2023 07:54:42 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-Pzv3BnPgMLm_xFBVYqNOFA-1; Tue, 07 Nov 2023 10:54:37 -0500 X-MC-Unique: Pzv3BnPgMLm_xFBVYqNOFA-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F198E2806668; Tue, 7 Nov 2023 15:54:36 +0000 (UTC) X-Received: from [10.39.193.64] (unknown [10.39.193.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4788CC1290F; Tue, 7 Nov 2023 15:54:36 +0000 (UTC) Message-ID: <41866d8a-f551-14d4-d4de-688cf4a4cc7a@redhat.com> Date: Tue, 7 Nov 2023 16:54:35 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue From: "Laszlo Ersek" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Ray Ni , Veeresh Sangolli References: <20231107053853.76448-1-rsingh@ventanamicro.com> <20231107053853.76448-2-rsingh@ventanamicro.com> <48627b68-18cc-1363-91f7-f4659d61ebec@redhat.com> In-Reply-To: <48627b68-18cc-1363-91f7-f4659d61ebec@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ERVd6tdtYCpH4IOCcGikIcovx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ui0DOjni; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/7/23 16:52, Laszlo Ersek wrote: > On 11/7/23 06:38, Ranbir Singh wrote: >> From: Ranbir Singh >> >> The function USBMouseDriverBindingStart do have >> >> ASSERT (UsbMouseDevice !=3D NULL); >> >> after AllocateZeroPool, but it is applicable only in DEBUG mode. >> In RELEASE mode, if for whatever reasons UsbMouseDevice is NULL >> at this point, the code proceeds to dereference "UsbMouseDevice" >> afterwards which will lead to CRASH. >> >> Hence, for safety add NULL pointer checks always. >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4222 >> >> Cc: Ray Ni >> Co-authored-by: Veeresh Sangolli >> Signed-off-by: Ranbir Singh >> Signed-off-by: Ranbir Singh >> Reviewed-by: Laszlo Ersek >> --- >> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c b/MdeModulePkg/= Bus/Usb/UsbMouseDxe/UsbMouse.c >> index 451d4b934f4c..67072d476196 100644 >> --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c >> +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c >> @@ -160,7 +160,10 @@ USBMouseDriverBindingStart ( >> } >> =20 >> UsbMouseDevice =3D AllocateZeroPool (sizeof (USB_MOUSE_DEV)); >> - ASSERT (UsbMouseDevice !=3D NULL); >> + if (UsbMouseDevice =3D=3D NULL) { >> + Status =3D EFI_OUT_OF_RESOURCES; >> + goto ErrorExit; >> + } >> =20 >> UsbMouseDevice->UsbIo =3D UsbIo; >> UsbMouseDevice->Signature =3D USB_MOUSE_DEV_SIGNATURE; >=20 > Reviewed-by: Laszlo Ersek >=20 sorry I missed that I gave R-b for this previously, and that you had picked it up already! -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110859): https://edk2.groups.io/g/devel/message/110859 Mute This Topic: https://groups.io/mt/102437986/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-