From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 15B0A210FCF55 for ; Tue, 12 Jun 2018 06:01:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E780380401A8 for ; Tue, 12 Jun 2018 13:01:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-239.rdu2.redhat.com [10.10.120.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EFC12035721; Tue, 12 Jun 2018 13:01:13 +0000 (UTC) To: Gerd Hoffmann Cc: edk2-devel@lists.01.org References: <20180608113942.17009-1-kraxel@redhat.com> <20180608113942.17009-3-kraxel@redhat.com> <20180612091552.uoo74cvqfzuf364t@sirius.home.kraxel.org> From: Laszlo Ersek Message-ID: <41879b09-b5e2-744a-ab66-cd48c4ab1750@redhat.com> Date: Tue, 12 Jun 2018 15:01:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180612091552.uoo74cvqfzuf364t@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 12 Jun 2018 13:01:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 12 Jun 2018 13:01:13 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 2/4] OvmfPkg: add QemuRamfbDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 13:01:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/12/18 11:15, Gerd Hoffmann wrote: > Hi, > >>> + { >>> + .HorizontalResolution = 640, >>> + .VerticalResolution = 480, >>> + },{ >>> + .HorizontalResolution = 800, >>> + .VerticalResolution = 600, >>> + },{ >>> + .HorizontalResolution = 1024, >>> + .VerticalResolution = 768, >>> + } >>> +}; >> >> (10) In edk2 we cannot use designated initializers. I suggest (for >> example) assigning these values in the entry point function. > > Really? C99 is almost 20 years old now ... > Are there compilers left without C99 support which edk2 still supports? Visual Studio has never committed to *full* C99 support, to my knowledge. I don't know whether VS happens to support designated initializers specifically; either way, we can't use them in edk2. ... After some googling, I see "signs" that VS >=2013 supports designated initializers. However, edk2 targets VS 2003, 2005, 2008, 2010, and 2012 too, before 2013. Refer to "Supported Tool Chains" in "BaseTools/Conf/tools_def.template". > >> In general, in edk2 there are two accepted indentation styles for >> function calls that extend to multiple lines: >> >> variant #1: all arguments (including the first one) on separate lines, >> with the closing paren also on a separate line: >> >> Status = StructPointer->Function ( >> Arg1, >> Arg2, >> Arg3 >> ); > > Hmm, pretty unusual, Yes, very much. I believe this indentation style might originate from Windows, but I'm not sure. > which is bad for editor auto-indent support. > Anyone knows tricks to teack emacs that style? I don't use emacs, apologies! Laszlo