From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.78]) by mx.groups.io with SMTP id smtpd.web12.52043.1658311413756972009 for ; Wed, 20 Jul 2022 03:03:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=IkIgeWa0; spf=pass (domain: arm.com, ip: 40.107.6.78, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wbbddx1ssSuLYceNMMxXH/JfODCIDMW2YG36Z6SBaVg+vm09YJIJa4G27xE4KlBi9a95n7A45ev5v4SiTd5++5y0jxAqPSNzPhH7hyK9uRdlWxezXvRfRwikSCT98k7gM7D5VWpTZfuQdWcohadwjfoczIohNIXbDEhRsq8kRPsYGqxlRglMQ6jBels5lqo3+7kDKzV0kLsWmfNSEySy9l5SlwxlJIkVx2Q2pysjh1aJva/n5jHZ5ISDfzfx7bGFTOCjNYpDElBjELAdyklh1EP7KxYCpKJnNHsl60h4KoJFPuybHdrAiaJGxAEMUJ+QLT806wY8A0KsmVv8vdD/Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wznByqFFAEnP+ydLbxIchAcoG/3ynTlDWDGJZE183iI=; b=hsPw5U+6AiiCCdcYJCUZWLDEau/Y2RCyOGPH1Fm92wVaQPbCsnI7WF/z3LY3QaH05jRAcuy7nXzmSBU4rHdPtIcU35vTUamWDY3sIl9/mCjx8U73ApEWXaqiFR99Q61/ethnUJh8wzWmG3Af8/4g8DQWXNoRH5+7Lf/Y1vSJaPJ+xjaaxwYkG+LII7rYe7JaLBEKbYCNuSininZcbuX8/0CBBcFaCrsGD0HkyTGJ5YIOZHriPm3mb5xyLW3aUEnb5oJmL1EUkktmo7myldfqm9Fy2W7yxgiEjSTR5TFpimRVHbzCIFN24huZJYMjo3DYA2g7cW11skWbqs59NIh7aQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wznByqFFAEnP+ydLbxIchAcoG/3ynTlDWDGJZE183iI=; b=IkIgeWa0C/FWmbcMS0EPmi+NAs+zvKRoPkZ59WM0jmW5DM4UVFV2lW5IYpXGbE0+jQy3KyShv9tIEyOdk9E6K+If3MsBpp0kS2PvNNxRQjMiLDZPvwIMmVdOi759UFZzH+ZYEZb0i/mEErlo3wkaRlDDFmgkM9KqdullFReVbCU= Received: from DB6PR0301CA0095.eurprd03.prod.outlook.com (2603:10a6:6:30::42) by AM0PR08MB4068.eurprd08.prod.outlook.com (2603:10a6:208:12b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 20 Jul 2022 10:03:29 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::c5) by DB6PR0301CA0095.outlook.office365.com (2603:10a6:6:30::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Wed, 20 Jul 2022 10:03:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Wed, 20 Jul 2022 10:03:29 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 20 Jul 2022 10:03:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ab23dea2d4358ed0 X-CR-MTA-TID: 64aa7808 Received: from 3851ec8f3e49.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1181423-1D33-476D-9CBC-3883C3897AFF.1; Wed, 20 Jul 2022 10:03:19 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3851ec8f3e49.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Jul 2022 10:03:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVElbO4/6JOtAzFpgtWGzUaT4ojC0GLy7feFnQCWH9HY+OUAcmho67ZQk1q/dz2g525oH8HpBcVzJ3mjS7W2g87lAsivnLWlzz+K/ot36f0GQJ6rgWo2csFJWb7Zucr2qyOMSvBds7t+RTQOrPewS3UJMSdOTTpXMHF5WIoCatQtu2mam1UeUWqAYihg4hKgpTZDB+5L+ScY7/E1i7MPIEV5ExuMp88t/b6i1A1+H0p9F2GzbwZuA2PgMoAGYeUtyYQ4R7mTzBqQAG5thGoWgu9n2lJDRZ3nOZEnxDHP1LvVqJGyJ2ynCAua8HoKy/mHfurhZt2KKmV5Vbumww0ulA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wznByqFFAEnP+ydLbxIchAcoG/3ynTlDWDGJZE183iI=; b=inAWxS5eoxNb7HrM/sduFrUI0/QaisZuuWVPFVbUwN7X2pX2oMtpihcIgek8Y+hE7e3/s1Yg6I8FK4aodseRtqpS0Oz9fvG/bYe3iduJV8Zsec373TxwRZ1dfmd9OYUBr34njvofG8fF8MmRYuDtGKKX9K1Ghz/PioHYQ/KqlNb6x5ZSC7yvk0CD9LRcFrzuzlhYOclmrMQwH2NboQDjvKcpC80ggwGEU7IG0vXho4FfFei2bVT22hDOCX4lF853Pj702R5MFGSopLLF36pGhvRel56BnLKH8atnAQl/BAGrBqmR3ABFcRCEv74mtUPasv4ryvn57SUiPgn4BF0Y0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wznByqFFAEnP+ydLbxIchAcoG/3ynTlDWDGJZE183iI=; b=IkIgeWa0C/FWmbcMS0EPmi+NAs+zvKRoPkZ59WM0jmW5DM4UVFV2lW5IYpXGbE0+jQy3KyShv9tIEyOdk9E6K+If3MsBpp0kS2PvNNxRQjMiLDZPvwIMmVdOi759UFZzH+ZYEZb0i/mEErlo3wkaRlDDFmgkM9KqdullFReVbCU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VI1PR08MB4431.eurprd08.prod.outlook.com (2603:10a6:803:fe::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Wed, 20 Jul 2022 10:03:14 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5458.018; Wed, 20 Jul 2022 10:03:13 +0000 Message-ID: <418f64c1-46b0-6e7d-be64-1d583169ee60@arm.com> Date: Wed, 20 Jul 2022 11:03:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 1/6] DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf To: Kun Qin , devel@edk2.groups.io Cc: Alexei Fedorov , Joe Lopez , nd@arm.com References: <20220719002254.1891-1-kuqin12@gmail.com> <20220719002254.1891-2-kuqin12@gmail.com> From: "Sami Mujawar" In-Reply-To: <20220719002254.1891-2-kuqin12@gmail.com> X-ClientProxiedBy: LO2P265CA0183.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::27) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5b30b04b-b4b7-476f-4d7a-08da6a3718b4 X-MS-TrafficTypeDiagnostic: VI1PR08MB4431:EE_|DBAEUR03FT042:EE_|AM0PR08MB4068:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8BvmawaFF7KyWc9B53J/3iBXoSr1Ex2EucniD48r4dSQ6HY4RxAK2Hd1j3Ko69GKKZ3Qt65KPc63yRFkxynI2ARexJwuR/1UY0j8tbOU1tN8jxsqWrsmg5OLQPyMOTr77oOAiSQClM+CbX45gkbYRhvwahkaYevUZ8VXNAA9o8xl4U1pRC5ewxCnBik2yx2WBhQqTBl0YVN0bbdPLKBhKaC24ta0Y7vryjG+XJ0nuPDS63UEaFdOpVpkQqUcQCkWycdzBZ12hGgXe8qSxZUdfBVwbRvpGThpgiBNlux8l9fFGczutaPnd/wIkbxCJOCA+7ue1A6JThq+R3l2vvMMLeHijG9T7nQQl2yrQ5+Vv2J5UZNWjir4ylALdVVXtnRaRLdT5s/gcv1gPVRtnGcaDYfdX9I/ZnUa2KWQlLI3s4+3Imbk6jFQbE2mXG77Ssfxd9oeIXserGri4/dQQdIlaytT1IMW1dRxtMAfhbukbgr4/yu3JfPcy+0wT0OybAVNae9fYGG5Kgqr9pOAcq75UtnMNah/b3j+algNqMHtTXNg3eHEdH65XmomAjTiHiiJoDH66eJluIZglH2sKbUQun1ru9kOPyCsA7OPD1r96TWGPmFYmaGK6nd4vbSjcQQS/Ym3Blt2aFvBSJgrakTGV4u3BD21qUmPCYO6HBXyfiU7TnSE2cP9FmQ2MZ8HF36ZHT5NaFFlW1FOpukL+zfh3ETWiM3FyRCOyVSDcJOplEK8q5ekrbjxbnGFa15hE0iiRoVKAsLZ13O9sZW3j1wWjBl8Kh1bPkGdFjmh/o6iiivBuPI8DYCvGPtYPimA7lk/1g4gGpfZVd2HQR51Htjf/QtiTEIBZ5M/U5QX312PoGs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(8676002)(66946007)(4326008)(8936002)(66476007)(316002)(54906003)(66556008)(86362001)(36756003)(2906002)(38100700002)(31686004)(6486002)(5660300002)(26005)(45080400002)(53546011)(6506007)(41300700001)(966005)(2616005)(31696002)(44832011)(6512007)(478600001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4431 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5e12695d-e461-47a5-27a3-08da6a370ef1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6GbIhJvyzbBgkI6WtinLndJpaL8FZxKXGCHlE/xvhmDNSvlGSRXxgbQl09hsOMVRC9zN1CPaiz/QQb0oCfdyuWT2zbSmeS5UuFV+43I3Tqop5f1UHZLt+D6zT6eTkyBXqYBimP2S7ldBlUkYQjSxB+hLK5dAtNgxK1PhsnoAlph0dn2YEkiv91i9HqvmwcIq+v5b4cweLGDDzPMmwjNY7kmyXFOYDmg/7mOpJxD8tQuAqxZbQ+3nPXh0kAbdqIh3zP8rrDkS7iwFLI2zs6iNiRuT1L3ZpDNro60w0txDnXZbOUG25sPby+lTJIu4KMY55J+TjofB8D8VDsD8xY2w/f1hB+xe+RbuYZMje0OX1yKrj2HrqJb2k9nz0adYxy5PyefHi704qLk/vDk1MFTuvJcyCY9SbUhFYPJgXQiBkoBrbEvOyqOZxkCsGRiFpXQng95FwWIkNN/oW2Wggqc8ydAOFlipOiO+sGvaxgYONRVIZ7xnKo7SUDEw3d4X6GsXHN9bPY/+TD2HLchg618Vs7fXQkW10XsXLRscHy102Z4aEua5DTrawhp/Zf4nmVL7zJDivBwkjFxIaZ+b5tUNNTeEQRjQGoaPD3NQ0LB2RXddU+uzJTeLXB8E8VAaaLErCaBwfPcrTUvFwAYnupdDqu3WdkURWaio8ndnO5xOkRR0UUJiWKnLnzUVZiu7nnhQX9Eq7lYEFHIzjVYSgYgnnEtlJgdCt9AFO2skftNSpWm7vZPJdVWYCK5+AWzTO2bVAYiuee7ue7FkdT8igoH5VsnBwLDJMeo7KWzGOEx/xdjTglZgrCg7A64dLFFkrRyeA0SQNy4v+OaPzHnW8DcLLyOMFfZZYbLAXf0GnW1oJdagtHLtFh4EvuRn/DJ8JNMx X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(40470700004)(46966006)(36840700001)(5660300002)(4326008)(8936002)(40460700003)(2616005)(70206006)(8676002)(70586007)(44832011)(40480700001)(2906002)(82310400005)(36860700001)(31696002)(6506007)(86362001)(81166007)(356005)(47076005)(54906003)(6486002)(26005)(45080400002)(966005)(336012)(82740400003)(478600001)(36756003)(53546011)(186003)(6512007)(316002)(31686004)(41300700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 10:03:29.6561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b30b04b-b4b7-476f-4d7a-08da6a3718b4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4068 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kun, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/07/2022 01:22 am, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 > > The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib, > such as DynamicPlatRepo.c and TokenMapper.c. Not including it in the > library inf file could lead to potential build break. > > This change added the MemoryAllocationLib into this inf file. > > Cc: Sami Mujawar > Cc: Alexei Fedorov > > Co-authored-by: Joe Lopez > Signed-off-by: Kun Qin > --- > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > index 9a3cc87fd91d..8423352550c2 100644 > --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > @@ -31,3 +31,4 @@ [Packages] > [LibraryClasses] > > AcpiHelperLib > > BaseLib > > + MemoryAllocationLib >