From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED24A21CF25C1 for ; Wed, 9 Aug 2017 18:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1502327035; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LM8vcDtztGHvAVp02UdDF3YV6J2z1YWxDK0b1w9UAMs=; b=GZljgH5CWxrWwesYC8KAhFFWKXEaImgivumxHVQrYQ1yC2yBQt8plLELH7n1qJb5 0ty/bciMhZdm1x3vo5RDKk58MoftG96Z+ohAhwcRtpqmPZGOvUiD6l6vM3GoZ9wC JosDhjvPv1M/Tss3pp3+QT4H2ZOJx4EMGekGevaF8Rjmt1u8BabGAfKLSD3VBrQ/ Nxcl/koyx2t+EuJb0ue3yUIZPlXOFL5NnBxeoq1q2iDymPu8IDx/YJ6n/+F5z044 aUCXeObURsxwUPUPo8TPk/xKs76QBF+EJpd5IyogyTvE4//CccE5sLrqZ7fbSMvw afPkD1ARZKeUVblOKECplw==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id 9F.90.06195.BF0BB895; Wed, 9 Aug 2017 18:03:55 -0700 (PDT) X-AuditID: 11973e16-8b5f19c000001833-d0-598bb0fbe781 Received: from nwk-mmpp-sz10.apple.com (nwk-mmpp-sz10.apple.com [17.128.115.122]) by relay6.apple.com (Apple SCV relay) with SMTP id 42.58.24226.BF0BB895; Wed, 9 Aug 2017 18:03:55 -0700 (PDT) MIME-version: 1.0 Received: from [17.235.57.129] by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170621 64bit (built Jun 21 2017)) with ESMTPSA id <0OUG005CW2YHJ610@nwk-mmpp-sz10.apple.com> for edk2-devel@lists.01.org; Wed, 09 Aug 2017 18:03:55 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <41A7B048-4140-4889-AE7C-36A0ED3B8C1C@apple.com> Date: Wed, 09 Aug 2017 18:03:52 -0700 To: edk2-devel X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsUi2FAYpft7Q3ekwbtbchZ7Dh1ldmD06J79 jyWAMYrLJiU1J7MstUjfLoEr4+W/L0wFvY4VvUdjGhi/WXQxcnJICJhIzFs8i7WLkYtDSGA1 k8Sn37OZYRJNizaxQCQOMUqsvHCJCSTBKyAo8WPyPRYQm1kgTGL6p16ooolMEn1LNrOCJIQF xCXendkENolNQFlixfwP7BDxPIk7i7awQwyykeid0MUGYrMIqEr8mvsBzBYR0JDY2t0KdYWs xK3Zl5hBFkgI9LBJvLrdwz6BkX8WkkNmITkEwtaS+P6oFcjmALLlJQ6el4UIa0o8u/eJHcLW lnjy7gLrAka2VYxCuYmZObqZeeZ6iQUFOal6yfm5mxhB4TrdTmwH48NVVocYBTgYlXh4E0S7 I4VYE8uKK3MPMUpzsCiJ87q1AoUE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUw9h0WfpMhXdT/ LNsgVkjzimbf/xtBotu2dmUxW28qurIlx12/9z8jp2zglLQjIqrqnzzKeZfdCRI7Grn2SLSf 8je+XeEVLU9tY/2rHt6+JB0vyLBlCbty0az2iFmtN3s2iEiU902/N0vP+0zgusKu0z/Ul17c u+4FY7Xv8rt/ttxnNhcoWr1diaU4I9FQi7moOBEAkouJWTgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42IRbCiu0v29oTvSoGO3lMWeQ0eZHRg9umf/ YwlgjOKySUnNySxLLdK3S+DKePnvC1NBr2NF79GYBsZvFl2MnBwSAiYSTYs2sXQxcnEICRxi lFh54RITSIJXQFDix+R7LCA2s0CYxPRPvVBFE5kk+pZsZgVJCAuIS7w7s4kZxGYTUJZYMf8D O0Q8T+LOoi3sEINsJHondLGB2CwCqhK/5n4As0UENCS2drcyQ1whK3Fr9iXmCYw8s5DsnoVk N4StJfH9USuQzQFky0scPC8LEdaUeHbvEzuErS3x5N0F1gWMbKsYBYpScxIrzfQSCwpyUvWS 83M3MYLDqzBqB2PDcqtDjAIcjEo8vBzC3ZFCrIllxZW5wADgYFYS4X2yFijEm5JYWZValB9f VJqTWnyIcSIj0AMTmaVEk/OBwZ9XEm9oYmJgYmxsZmxsbmJOS2Elcd5pHUAXCaQnlqRmp6YW pBbBHMXEwSnVwGjdFbd6r03HnwduTSV/Hk7dknlw4jr/V1xSzPYHawOsjrxRrn989rPcx8Vr 4vni38+9tCtsyTx1u8o97iZOiu8WMO0v0wybXn8mZDZPwbOJgUF3WFZvD1bOffjSVFfe9fvr Q442pT9mMu6+2LBbZcZ7bjkOK40fuZ2RH5l7xd/fWsIhvuCJgq4SS3FGoqEWc1FxIgCkRVr3 ogIAAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Does a double Page free report "ConvertPages: Incompatible memory types", maybe we could do better. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 01:01:37 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT It looks to me like if you Free pages, after you free pages you hit this DEBUG message. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Mem/Page.c#L790 if (!(NewType == EfiConventionalMemory ? 1 : 0) ^ (Entry->Type == EfiConventionalMemory ? 1 : 0)) { DEBUG ((DEBUG_ERROR | DEBUG_PAGE, "ConvertPages: Incompatible memory types\n")); return EFI_NOT_FOUND; } I'm not sure I've thought out all the paths, but would it make more sense if you are trying to convert EfiConventionalMemory to EfiConventionalMemory that you are trying to free pages that are already freed. That is not very obvious from the above DEBUG print. Could there be an if in the error path to print a better DEBUG message for a free pages bug? Also to be pedantic the function change names to: CoreConvertPagesEx(). Thanks, Andrew Fish