From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ching.jenx.cheng@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 10 Sep 2019 23:25:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 23:25:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="384588623" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 10 Sep 2019 23:25:28 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Sep 2019 23:25:28 -0700 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Sep 2019 23:25:27 -0700 Received: from bgsmsx105.gar.corp.intel.com ([169.254.3.241]) by BGSMSX109.gar.corp.intel.com ([169.254.10.210]) with mapi id 14.03.0439.000; Wed, 11 Sep 2019 11:55:25 +0530 From: "Cheng, Ching JenX" To: "devel@edk2.groups.io" , "Cheng, Ching JenX" Subject: Re: [edk2-devel] [PATCH 0/2] *** Add VS2019 Support *** Thread-Topic: [edk2-devel] [PATCH 0/2] *** Add VS2019 Support *** Thread-Index: AQHVaGdXmRNtsSr3+0i8uICyoHCefqcmANOQ Date: Wed, 11 Sep 2019 06:25:24 +0000 Message-ID: <41C441B9D06FFF49AD23ED447CFBE8B160A1A2@BGSMSX105.gar.corp.intel.com> References: <15C34D4FF34E9960.28990@groups.io> In-Reply-To: <15C34D4FF34E9960.28990@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: ching.jenx.cheng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Cheng, Ching JenX Sent: Wednesday, September 11, 2019 2:08 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/2] *** Add VS2019 Support *** REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2182 In order to support VS2019 on EDK2, the following patches was modified def= and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with com= mand vswhere Because VS2019 and VS2017 using the same vswhere to get the Installat= ionPath Ching JenX Cheng (2): Add VS2019 Toolchain def Add VS2019 Support on ToolSetup Batches BaseTools/Conf/tools_def.template | 134 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ++++++------------ BaseTools/get_vsvars.bat | 39 +++++++++++++++++++++++++++++++-------- BaseTools/set_vsprefix_envs.bat | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ +++++++----- BaseTools/toolsetup.bat | 16 +++++++++++++--- edksetup.bat | 6 ++++-- 5 files changed, 235 insertions(+), 30 deletions(-) -- 2.21.0.windows.1