From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ching.jenx.cheng@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Tue, 17 Sep 2019 18:51:32 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 18:51:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,518,1559545200"; 
   d="scan'208";a="180974725"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga008.jf.intel.com with ESMTP; 17 Sep 2019 18:51:32 -0700
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 17 Sep 2019 18:51:32 -0700
Received: from bgsmsx154.gar.corp.intel.com (10.224.48.47) by
 FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 17 Sep 2019 18:51:31 -0700
Received: from bgsmsx105.gar.corp.intel.com ([169.254.3.241]) by
 BGSMSX154.gar.corp.intel.com ([169.254.7.62]) with mapi id 14.03.0439.000;
 Wed, 18 Sep 2019 07:21:28 +0530
From: "Cheng, Ching JenX" <ching.jenx.cheng@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
Thread-Topic: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
Thread-Index: AQHVbQZ9gPkmRD//C0OdrVvNCnXNcqcvM4rAgABmdoCAARIqwA==
Date: Wed, 18 Sep 2019 01:51:28 +0000
Message-ID: <41C441B9D06FFF49AD23ED447CFBE8B160AD1D@BGSMSX105.gar.corp.intel.com>
References: <15C51B795F616549.24469@groups.io>
 <41C441B9D06FFF49AD23ED447CFBE8B160A9CB@BGSMSX105.gar.corp.intel.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD83B@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD83B@SHSMSX104.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.223.10.10]
MIME-Version: 1.0
Return-Path: ching.jenx.cheng@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Liming,

The VS2017 is still working fine with this changes,
I have verified it with VS2019, VS2017 and VS2015 build,

Thanks,
Allen

> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, September 17, 2019 10:57 PM
> To: devel@edk2.groups.io; Cheng, Ching JenX
> <ching.jenx.cheng@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>=20
> Ching:
>   The change is good. With this change, have you verified VS2017 tool ch=
ain?
>   I want to make sure there is no impact on VS2017.
>=20
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Cheng, Ching JenX
> > Sent: Tuesday, September 17, 2019 11:23 AM
> > To: devel@edk2.groups.io; Cheng, Ching JenX
> > <ching.jenx.cheng@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2182
> >
> > In order to support VS2019 on EDK2, the following patches was modified
> > def and batch files 1. Add VS2019 x86/64 definitions on tools_def.temp=
late
> 2. Add VS2019 support on toolsetup batches, and add version check with
> command vswhere
> >      Because VS2019 and VS2017 using the same vswhere to get the
> > InstallationPath
> >
> > v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST
> and
> > VS2019_HOST to VS_HOST
> >
> > Ching JenX Cheng (2):
> >   Add VS2019 Toolchain def
> >   Add VS2019 Support on ToolSetup Batches
> >
> >  BaseTools/Conf/tools_def.template | 220
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++-------------------
> >  BaseTools/get_vsvars.bat          |  37
> ++++++++++++++++++++++++++++++-------
> >  BaseTools/set_vsprefix_envs.bat   |  70
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++-----
> >  BaseTools/toolsetup.bat           |  16 +++++++++++++---
> >  edksetup.bat                      |   6 ++++--
> >  5 files changed, 313 insertions(+), 36 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
> >
> >
> >=20