From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.26981.1611146466177499315 for ; Wed, 20 Jan 2021 04:41:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.24, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: pF9lVThPGKUmFyH24l61zLtKOhm5hy72jUrYa5M9N9kLFNb/7x+ExxeoQ+Ers0w2mXNeCb/Ptw ZG7a9ZRXEuSw== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="179244147" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="179244147" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 04:41:05 -0800 IronPort-SDR: HOiA9mT3x2n+pdGG+ZMbJkbP+vtRJqe0/6iSAT35m7B3TbB0jNS1jM929scNv64BVc4n4b/6Nd +US3hkjfh5bA== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="426882291" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.249.156.97]) ([10.249.156.97]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 04:41:04 -0800 Subject: Re: [edk2-devel] [PATCH] NetworkPkg/Library/DxeHttpIoLib: Http boot failure with no initializes timeout value. From: "Maciej Rabeda" To: devel@edk2.groups.io, gregx.yeh@intel.com Cc: Jiaxin Wu , Siyuan Fu Reply-To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com References: <20210115062256.17672-1-gregx.yeh@intel.com> <165BEEA0E105E3C7.2239@groups.io> Message-ID: <41a22aa8-1a78-c003-6b72-f3fa55a9c8f9@linux.intel.com> Date: Wed, 20 Jan 2021 13:40:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <165BEEA0E105E3C7.2239@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: pl Patch merged. PR: https://github.com/tianocore/edk2/pull/1371 Commit: https://github.com/tianocore/edk2/commit/ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3 On 20-Jan-21 12:54, Maciej Rabeda wrote: > Thanks for the patch! > > Reviewed-by: Maciej Rabeda > > On 15-Jan-21 07:22, GregX Yeh wrote: >> https://bugzilla.tianocore.org/show_bug.cgi?id=3170 >> Using PcdHttpIoTimeout to set default timeout value to HttpIoLib. >> >> Cc: Maciej Rabeda >> Cc: Jiaxin Wu >> Cc: Siyuan Fu >> Signed-off-by: GregX Yeh >> --- >>   NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c   | 1 + >>   NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf | 1 + >>   NetworkPkg/NetworkPkg.dec                        | 6 +++++- >>   3 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c >> b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c >> index 67583fb220..04b01adec5 100644 >> --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c >> +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c >> @@ -189,6 +189,7 @@ HttpIoCreateIo ( >>     HttpIo->Http        = Http; >>     HttpIo->Callback    = Callback; >>     HttpIo->Context     = Context; >> +  HttpIo->Timeout     = PcdGet32 (PcdHttpIoTimeout); >>       if (ConfigData != NULL) { >>       if (HttpIo->IpVersion == IP_VERSION_4) { >> diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf >> b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf >> index 25f5eb2ec6..347f8d5508 100644 >> --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf >> +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf >> @@ -43,3 +43,4 @@ >>     [Pcd] >>     gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer  ## >> SOMETIMES_CONSUMES >> +  gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout         ## >> SOMETIMES_CONSUMES >> diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec >> index 2d0d7fd2dc..87725674e9 100644 >> --- a/NetworkPkg/NetworkPkg.dec >> +++ b/NetworkPkg/NetworkPkg.dec >> @@ -3,7 +3,7 @@ >>   # >>   # This package provides network modules that conform to UEFI 2.4 >> specification. >>   # >> -# Copyright (c) 2009 - 2019, Intel Corporation. All rights >> reserved.
>> +# Copyright (c) 2009 - 2021, Intel Corporation. All rights >> reserved.
>>   # (C) Copyright 2015-2020 Hewlett Packard Enterprise Development >> LP
>>   # >>   # SPDX-License-Identifier: BSD-2-Clause-Patent >> @@ -96,6 +96,10 @@ >>     ## The maximum size of total HTTP chunk transfer. >>     # @Prompt Max size of total HTTP chunk transfer. the default >> value is 12MB. >> gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer|0x0C00000|UINT32|0x0000000E >> + >> +  ## The Timeout value of HTTP IO. >> +  # @Prompt The Timeout value of HTTP Io. Default value is 5000. >> + gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout|5000|UINT32|0x0000000F >>     [PcdsFixedAtBuild, PcdsPatchableInModule] >>     ## Indicates whether HTTP connections (i.e., unsecured) are >> permitted or not. > > > > > >