Re: [edk2-devel] [PATCH v3 6/6] BhyvePkg: Add AcpiPlatformDxe

["Laszlo Ersek" <lersek@redhat.com>]

On 04/21/20 05:09, Rebecca Cran wrote:
> Make a copy of OvmfPkg/AcpiPlatformDxe under BhyvePkg, with the changes
> needed to support the bhyve hypervisor.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c      | 250 +++++++++++++++++++
>  BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h      |  76 ++++++
>  BhyvePkg/AcpiPlatformDxe/AcpiPlatformDxe.inf |  64 +++++
>  BhyvePkg/AcpiPlatformDxe/Bhyve.c             | 138 ++++++++++
>  BhyvePkg/AcpiPlatformDxe/EntryPoint.c        |  90 +++++++
>  BhyvePkg/AcpiPlatformDxe/PciDecoding.c       | 192 ++++++++++++++
>  6 files changed, 810 insertions(+)
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/Bhyve.c
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/EntryPoint.c
>  create mode 100644 BhyvePkg/AcpiPlatformDxe/PciDecoding.c
> 
> diff --git a/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c b/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c
> new file mode 100644
> index 0000000000..4814a9f1e6
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c
> @@ -0,0 +1,250 @@
> +/** @file
> +  OVMF ACPI Platform Driver
> +
> +  Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/

(1) Please add your (C) notice, with the year 2020.


> diff --git a/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h b/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h
> new file mode 100644
> index 0000000000..157ff42c07
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h
> @@ -0,0 +1,76 @@
> +/** @file
> +  Sample ACPI Platform Driver
> +
> +  Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/

(2) Same as (1).

> diff --git a/BhyvePkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/BhyvePkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> new file mode 100644
> index 0000000000..6e931d85c0
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> @@ -0,0 +1,64 @@
> +## @file
> +#  OVMF ACPI Platform Driver
> +#
> +#  Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
> +#
> +#  SPDX-License-Identifier: BSD-2-Clause
> +##

(3) Same as (1).

> diff --git a/BhyvePkg/AcpiPlatformDxe/Bhyve.c b/BhyvePkg/AcpiPlatformDxe/Bhyve.c
> new file mode 100644
> index 0000000000..7f1a5fd664
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/Bhyve.c
> @@ -0,0 +1,138 @@
> +/*
> + * Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
> + * Copyright (C) 2012, Red Hat, Inc.
> + * Copyright (c) 2014, Pluribus Networks, Inc.
> + *
> + * This program and the accompanying materials are licensed and made
> + * available under the terms and conditions of the BSD License which
> + * accompanies this distribution.  The full text of the license may be
> + * found at http://opensource.org/licenses/bsd-license.php
> + *
> + * THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> + * BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> + * EXPRESS OR IMPLIED.
> + */

(4) please use the SPDX ID format.

> diff --git a/BhyvePkg/AcpiPlatformDxe/EntryPoint.c b/BhyvePkg/AcpiPlatformDxe/EntryPoint.c
> new file mode 100644
> index 0000000000..f66f892911
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/EntryPoint.c
> @@ -0,0 +1,90 @@
> +/** @file
> +  Entry point of OVMF ACPI Platform Driver
> +
> +  Copyright (C) 2015, Red Hat, Inc.
> +  Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.<BR>
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +**/

(5) Same as (1).

> diff --git a/BhyvePkg/AcpiPlatformDxe/PciDecoding.c b/BhyvePkg/AcpiPlatformDxe/PciDecoding.c
> new file mode 100644
> index 0000000000..73894106c9
> --- /dev/null
> +++ b/BhyvePkg/AcpiPlatformDxe/PciDecoding.c
> @@ -0,0 +1,192 @@
> +/** @file
> +  Temporarily enable IO and MMIO decoding for all PCI devices while QEMU
> +  regenerates the ACPI tables.
> +
> +  Copyright (C) 2016, Red Hat, Inc.
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +**/

(6) Same as (1).

Thanks
Laszlo